From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CA3348164A for ; Thu, 13 Aug 2026 14:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786632044; cv=none; b=QaDOoj33PV3jmerPXqwM8CJ1BThf62Iz1g+Ey2UFb9FxcZWymDOz0wohQM3fgkvOhRfAzRpOJT2xBm0/w9EKm6u1RGO2VDHxTYD0lAfrevbW/IG9KIb7HDklOnBuc5+Ibl4mPI8Ra5QKaDVtLtMcJGN5TZZC02Tb2PZxiJ62ruw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786632044; c=relaxed/simple; bh=Fn7/Kun1Xj3zANVPU/qpma4EzgtzFyOKv79nRQkl1r0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q9IAqhhq9M3cWrdEyYUd2WiTrBe58IWYaZVrRspwIZTfofEIRkNNFjhm4j1tK4pm4W6o03uxaz+o3v0dkPnoCKFiAcejGtOWBQ2tapjpHRB5FRnwV8vphbDEuhcE47nh6VwlXbdui73pccu3NJdh1gteLG8W2Q8B/CyobJGD8Ks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=EUWElDDd; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="EUWElDDd" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-51c0ecfaee7so1571cf.0 for ; Thu, 13 Aug 2026 07:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1786632042; x=1787236842; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BsutUma4J7k9K1EQrc1L+Fl5PhES1nmDAUI72Bdk2Yg=; b=EUWElDDdwSH+FXakMZvZr8rw3pV6Wo5e/XbPyv3TtWhHFLmdO+HYs0benH7AsirNWk rNZ7H9SzFGU472kbpI66kX/fFeX4kjxmbUnE/rU+olCLI7flRMJcczxrO4xZ41SuDhdQ oDy7HZgIWvZu18g8XEkvehJcts1kQ8XCH4pZ1MwahgE+JhnZcBC2FROeSKt8kbRh+oeh +qMpbf6yxAqrPmTs1EwCwBrL8Jy8JwzvqLHB21rh6tyyFO9Ona8Ihk84YXiAXVRPMQom tQQqMRKWCFx+nHkRT4LCOpiylFpATwkFQ8QCtXsdpqJ14W0muF1JNq3y3mqDUNXA+ZGI pG/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786632042; x=1787236842; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BsutUma4J7k9K1EQrc1L+Fl5PhES1nmDAUI72Bdk2Yg=; b=lt1bGcvNOvGiRcaLt4rsOrhyJH22ta3oVoYSzttiYEi+x/KOHFZx3vhOY0qFQU8XmS V0hj+a4NpVoA04N4khOKE24f0WGW3DsmaRtP6BWlZ2NPMD9tKYfcMMPoGvFJ3z+g+CR1 4xSKP0NL3uEs8lBVWcegXDA2vn02E3DI5HSho/vId1iRNsDFjE1z6FbhW5CnbEukch3p n8DT7Hn+F69DdGOZKtUwAeTxOYK+rNFqPqcTVVRrKD31CKpCW+4nzHuQlOwB34zIelrL 5qbPAsRX2cVpzfK37gFIgOeKzeQ8NzErAA6kP/8tPziWvYt9FoedLglr3iWiH1FI35t7 u8CA== X-Forwarded-Encrypted: i=1; AHgh+Ro4BNMBqIJ1NvLRqG3IuDihV2cS20UDJh9T7E//9EK7zIURRGmYi8c4+xWbd5P8J/cmO80qd08ZM1+bBZA=@vger.kernel.org X-Gm-Message-State: AOJu0YywQ8dQZWCr+bsaPjowkp3od1uUyZLyrL2cg54wGUwPF0HJYaqf BnQtNvIu1qiaHk54vFVhU2NX60lwdUeuzLDx/QtdzpLhH3Z/zh2ELv776UlwubW997k= X-Gm-Gg: AR+sD111zUnHFexNal4gUUIuVY2+yFfmRv57fQ9nfcJt/VJf4d9b+mcdiFXHeU2crdH /IFfiWNKnoCUhmAj/WAg1OgVqNuOSR/B9qTp+avP4d85FcpUkxcoZu3h3BNaXOVL2ooIjnQnIea 0vccO/AsO59+qutHdfSsnL6dv/9k3OzJCdX7mwgV5Xs3uVC4szm5reI2jSa2KsObTWuhB5nox+Z Xqoo/UZh3O+jskWLsDd9LsOsTVonYAklfudGwHkUZuKVnWXd4sU6aZVMj0VZxeULa7Dgy2Hcb3A iQs+TNMgI+fYGIsmOKr3nZUtgTRT5DnobtvTTlD06gYAdGa7mIKf5WUM0ra9HIDyCTZBXr7sgEQ HXBOndkyB79XLiH05AADw6RsFuyUvdItKFxp28DzW4FExI9vDH/aEE32xrOykbFEoMhv3BTdTYh 1S7G+VRzCqsgLMagP2yAe+0IRUEh8qq2H7BCbNmXVg+HPFVHWAviOx/iMqrag0 X-Received: by 2002:a05:622a:2299:b0:51c:857f:9c12 with SMTP id d75a77b69052e-52d73c272demr67730661cf.4.1786632041981; Thu, 13 Aug 2026 07:40:41 -0700 (PDT) Received: from ziepe.ca ([142.166.156.215]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52d74005849sm18256301cf.30.2026.08.13.07.40.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 07:40:40 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wuWbn-00000003oi2-45RH; Thu, 13 Aug 2026 11:40:39 -0300 Date: Thu, 13 Aug 2026 11:40:39 -0300 From: Jason Gunthorpe To: Sean Christopherson Cc: David Woodhouse , Michal Hocko , Steven Rostedt , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Sebastian Andrzej Siewior , Clark Williams , Simona Vetter , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Christian =?utf-8?B?S8O2bmln?= , "Paul E. McKenney" , Paolo Bonzini , linux-mm@kvack.org, kvm@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mmu_notifier: Remove non_block_start/end() from notifier invocation Message-ID: <20260813144039.GA905583@ziepe.ca> References: <44c51ace9b0dc44b795f6f48c91cda440eed910b.camel@infradead.org> <20260812122759.GA662699@ziepe.ca> <20260812134934.GC662699@ziepe.ca> <20260812142659.GD662699@ziepe.ca> <9e65be44430e7d013fedf9a1626caba020ad6d94.camel@infradead.org> <8ba4860fec45afeaa305bcb011d732ef0da302d6.camel@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Aug 13, 2026 at 06:59:36AM -0700, Sean Christopherson wrote: > > On the other hand, they are basically *all* false positives from the > > point of view of what the check was actually trying to do. And in KVM. > > FWIW, all of the KVM false positives are due to PREEMPT_RT turning mmu_lock into > a sleepable lock on x86. So killing off the restriction for PREEMPT_RT would > "fix" the KVM issues. Yes.. Still, if you want to get rid of the non-blocking feature then it should be replaced with something else that still achieves the same end of preventing recursion into the OOM flow. Maybe some smart lockdep scheme or something. The non-blocking thing is pretty nasty, and it would be nice to upgrade the drivers using sleeping locks without MM entanglements to be able to work with the OOM killer, but I don't think anyone should attempt that without some robust scheme to detect the invalid cases. Jason