From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2342C3AE198 for ; Thu, 13 Aug 2026 17:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786643263; cv=none; b=hocOUatAsS74nSLMyTs3a3Nu2prcNlQKo18y/aQV1hZq/f/J6nTMAcyms34UZS9fGzF96Z6HivqNJE4ZusVieCT1zt2GF+9oICezHh8a3CoOsbdwPlCwIGTleMm1vlWYNamUeEbClMLszyI0UguXIp/UVpZTKT9vwYtEeFdYZ+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786643263; c=relaxed/simple; bh=q5930mDZa8nyXDAn+W2zn/rpNIQ+KxznOLcbAGh3aPM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mqoI4O2QuI6/v5zu2/z8Eayi0CWVjk2DxFv9QrCo2zkOH+/dpBif2KvMcQ5sP/rWlGXQOsKl+tZOPdf1t7Ihu54QY9Z/JytE9NNYUbqQE+dracURUniy8d507ZxFwyxlx2JFyXwv0BONJS3GZcxJusUvt4zFlA7zH9bJmcOGz/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z3t9CcOw; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z3t9CcOw" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49800c6a846so1897395e9.3 for ; Thu, 13 Aug 2026 10:47:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786643255; x=1787248055; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=c7wvD5wo2/av6+IbmyK7GMULA2iVsXLMzj4pik6CuA8=; b=Z3t9CcOwAncqE7QhT4dlnAP7AaOzRcPET7QKI/nHHfHHWkuS+VeRwIYoBS9ud9oI/D BkuVYOgvYULyONTTMkD2amDWLQTwB6POfC8JkqKNVsZqb0FDqJSJT20243uASOLHvfye YHMJIsbLXzwme/A7C1UuQzs8HLLDLM8PUQchadkeLPjx4Vjs8vKbJ4J4Qa4fJ/OAJzkN RUy61alhxpdGSqUTGPjMU/d2M5MXBtALvWfbNFHRMKRunn8aFIyxw8xDEB31BpavXIzz Rr3M1wmKqpxi9rRQ6D7xzx+21sJaSTi9i3VHd4mFAT+69uMC2++NnNEXwncSWqCK6oqp CMzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786643255; x=1787248055; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=c7wvD5wo2/av6+IbmyK7GMULA2iVsXLMzj4pik6CuA8=; b=lVYEIN8P9KPkwrzuK+tvxZUrVpe6DeqeV9IoAyLI8ob3iB/TM/imQvr80p8LCsXuXq USE3u7La0x6y9+UzQvHOZurykO7KdHlbFCrgNlZi4oLIqC1YjUZZmrD4COTzSbjliHbq IaSgEFmWStSd37f1ThVDO+owbHstNRx5Lyz1ClEhgFF/OnCf5np2qFEcxcJn2vrqumd1 WCYo7hRdwooXfjrkwtMWYCXOA1SMHwkLsyNqnPYKvrPE5981TpMfjXhTvO4Nqh7ryFEW WaYf5N2yHE+QbIcOpE+7X52zLjvtojoSzE0tj945Za+yLCG0GzTeUzlea2Ex+Q07lkza 1viw== X-Gm-Message-State: AOJu0YyP29r9tmaIufB214OffXdCY5irQCwH+gaTg6cyKwRPseLzbRlL Sl2jj7P0ExfpZOY+V5EBfEGuOIjxGuvAHM1ltxvryMXaeCdU5eFVicIdIE+tZg== X-Gm-Gg: AR+sD10dY6CJsLDP1UQmwQIxd1agS63H6B0o+WOF02oC562kWNkQyacL2m7fXcyQIu1 lwFJnKxoG97Lf/d7mQcbJuhUL36yQDneeW74v9Gp9WA+GL6VBst1YEcJ2PtBIpyltfTnb0bqyyd YxPXQphrP/gGXgz5SwBjONx57knpFjl2ZQIgsa4dMZGzjz8/FtGL6ehik2bzq1MsfaG3o1BZYpi w/Q3RAqR+UqE5ghR5OY511Ko0wg9TGIEtaY6S/KHXi1ZFshgMEvQ0GVd21kiUFs38cOIxGNBEaM YhO1BSHsVgZn8VhZUcLDk93swGZm5av/OFHSUnvD9SK8qwcBogj15lUn1pYGWGURkH7weOTIA9W j/i8rPQ+pq3bFp+dA/aRgWAdE1EO3p/6aR/KwF7fkiUn7ux1vZ+aeDoYNtjXBJQP/1HEQZJ995y o975aDaJ5cN57/+gKtNFW1SnR+Ihc9n3q9vLLBNlGs1vDGCv0yXN7y3ZzPqIFsCldVkmc= X-Received: by 2002:a05:600c:34cf:b0:499:48bb:417e with SMTP id 5b1f17b1804b1-49987929750mr3080675e9.2.1786643254529; Thu, 13 Aug 2026 10:47:34 -0700 (PDT) Received: from SurHub.localdomain ([102.218.51.180]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49981b62437sm81694175e9.12.2026.08.13.10.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 10:47:34 -0700 (PDT) From: Abdifatah Suruur To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, quic_subashab@quicinc.com, quic_stranche@quicinc.com, doruk@0sec.ai, Abdifatah Suruur Subject: [PATCH net] net: qualcomm: rmnet: require CAP_NET_ADMIN in the real device netns for changelink Date: Thu, 13 Aug 2026 20:47:27 +0300 Message-ID: <20260813174727.14857-1-suruurism@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A changelink() on an rmnet device mutates the rmnet port state attached to the real device (endpoint mux table, port->data_format and, via rmnet_vnd_update_dev_mtu(), the real device MTU). The real device may live in a different netns than the rmnet device (rmnet_newlink() resolves it in link_net), but the rtnl path only checks CAP_NET_ADMIN against dev_net(dev). A caller privileged only in the rmnet device's netns can therefore rewrite the shared cellular data-path state owned by another netns. Gate rmnet_changelink() with rtnl_dev_link_net_capable(), matching the "require CAP_NET_ADMIN in the device netns for changelink" series (vxlan/geneve, CVE-2026-68432). Fixes: 2abb5792387e ("net: qualcomm: rmnet: Allow configuration updates to existing devices") Reported-by: Abdifatah Suruur Cc: stable@vger.kernel.org Signed-off-by: Abdifatah Suruur --- --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c @@ -312,6 +312,14 @@ if (!rmnet_is_real_dev_registered(real_dev)) return -ENODEV; + /* + * The rtnl path only checks CAP_NET_ADMIN against dev_net(dev), + * but the port state mutated below is attached to real_dev, which + * may live in a different netns. + */ + if (!rtnl_dev_link_net_capable(dev, dev_net(real_dev))) + return -EPERM; + port = rmnet_get_port_rtnl(real_dev); if (data[IFLA_RMNET_MUX_ID]) {