From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: Jiri Slaby <jirislaby@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 2/2] serial: 8250_port: properly handle runtime PM in IRQ
Date: Fri, 14 Aug 2026 13:16:30 +0200 [thread overview]
Message-ID: <20260814112435.3290545-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20260814112435.3290545-1-andriy.shevchenko@linux.intel.com>
We can't and basically don't need to call runtime PM in IRQ handler.
If IRQ is ours, the device must be powered on. Otherwise check if
the device is powered off and return immediately.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/tty/serial/8250/8250_port.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index c0bcc0742a60..01703a707c22 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -1880,11 +1880,21 @@ static int serial8250_default_handle_irq(struct uart_port *port)
{
struct uart_8250_port *up = up_to_u8250p(port);
unsigned int iir;
+ int pm_status;
+ int ret;
- guard(serial8250_rpm)(up);
+ /* if driver suspended, return, probably shared interrupt */
+ pm_status = pm_runtime_get_if_active(port->dev);
+ if (!pm_status)
+ return 0;
iir = serial_port_in(port, UART_IIR);
- return serial8250_handle_irq(port, iir);
+ ret = serial8250_handle_irq(port, iir);
+
+ if (pm_status > 0)
+ pm_runtime_put_autosuspend(port->dev);
+
+ return ret;
}
/*
--
2.50.1
next prev parent reply other threads:[~2026-08-14 11:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 11:16 [PATCH v1 0/2] serial: 8250_port: Update runtime PM flow Andy Shevchenko
2026-08-14 11:16 ` [PATCH v1 1/2] serial: 8250_port: Remove redundant pm_runtime_mark_last_busy() call Andy Shevchenko
2026-08-14 11:16 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-25 12:41 [PATCH v1 1/2] serial: 8250_pci: Remove empty stub pci_quatech_exit() Andy Shevchenko
2021-10-25 12:41 ` [PATCH v1 2/2] serial: 8250_port: properly handle runtime PM in IRQ Andy Shevchenko
2021-10-25 12:43 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814112435.3290545-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox