The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Lance Yang <lance.yang@linux.dev>
To: david@kernel.org
Cc: akpm@linux-foundation.org, jgg@ziepe.ca, jhubbard@nvidia.com,
	peterx@redhat.com, yang.lee@linux.alibaba.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	cuiyunhui@bytedance.com, Lance Yang <lance.yang@linux.dev>
Subject: Re: [PATCH] mm/gup_test: keep longterm pin state per file
Date: Sun, 16 Aug 2026 20:53:44 +0800	[thread overview]
Message-ID: <20260816125344.9813-1-lance.yang@linux.dev> (raw)
In-Reply-To: <20260810-gup_test_data-v1-1-fb1d41be5bb4@kernel.org>


On Mon, Aug 10, 2026 at 01:31:14PM +0200, David Hildenbrand (Arm) wrote:
>The pin longterm test currently stores its data globally, shared among
>multiple concurrent users of the interface (multiple open file
>descriptors -> multiple "struct file"'s). That makes
>the gup_test interface problematic to use concurrently: two users, such
>as concurrent selftest runs, can interfere with the same longterm
>pin state.
>
>While this has not been observed as a problem so far in practice, let's
>just handle it cleanly. There could be a way to trigger selftest
>failures by e.g., running the cow.c and gup_longerm.c selftests
>concurrently, but we usually run them sequentially. Let's add a "Fixes"
>tag to be safe, but not need to CC stable.
>
>Fixes: c77369b437f9 ("mm/gup_test: start/stop/read functionality for PIN LONGTERM test")
>Reported-by: yunhui cui <cuiyunhui@bytedance.com>
>Closes: https://lore.kernel.org/r/20260608025043.88087-1-cuiyunhui@bytedance.com
>Tested-by: Yunhui Cui <cuiyunhui@bytedance.com>
>Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
>---

Gave it a spin on x86_64 QEMU. All good, shared-state mess is gone :)

Tested-by: Lance Yang <lance.yang@linux.dev>

      reply	other threads:[~2026-08-16 12:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 11:31 [PATCH] mm/gup_test: keep longterm pin state per file David Hildenbrand (Arm)
2026-08-16 12:53 ` Lance Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260816125344.9813-1-lance.yang@linux.dev \
    --to=lance.yang@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=cuiyunhui@bytedance.com \
    --cc=david@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterx@redhat.com \
    --cc=yang.lee@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox