From: Jakov Novak <jakovnovak30@gmail.com>
To: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
Ulf Hansson <ulfh@kernel.org>
Cc: Johan Hovold <johan@kernel.org>,
Guangshuo Li <lgs201920130244@gmail.com>,
Runyu Xiao <runyu.xiao@seu.edu.cn>,
Shuah Khan <skhan@linuxfoundation.org>,
Jakov Novak <jakovnovak30@gmail.com>,
syzbot+1ee4f3b9228e35f14677@syzkaller.appspotmail.com
Subject: [PATCH] mmc: vub300: fix sleeping function call from invalid context in vub300_inactivity_timer_expired
Date: Sun, 16 Aug 2026 17:38:09 +0200 [thread overview]
Message-ID: <20260816153809.7067-1-jakovnovak30@gmail.com> (raw)
Currently, the function vub300_inactivity_timer_expired, which gets
called in a softirq context, calls a sleeping function in the following
call chain:
vub300_inactivity_timer_expired -> kref_put -> vub300_delete ->
mmc_free_host -> cancel_delayed_work_sync -> __cancel_work_sync ->
might_sleep -> BUG
Fix this by replacing kref_put(&vub300->kref, vub300_delete) with
vub300_queue_dead_work(vub300), which does the same thing, but in a
workqueue context.
Fixes: 88095e7b473a ("mmc: Add new VUB300 USB-to-SD/SDIO/MMC driver")
Reported-and-tested-by: syzbot+1ee4f3b9228e35f14677@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=1ee4f3b9228e35f14677
Signed-off-by: Jakov Novak <jakovnovak30@gmail.com>
---
drivers/mmc/host/vub300.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
index 2dae474dcd06..df0096bc53db 100644
--- a/drivers/mmc/host/vub300.c
+++ b/drivers/mmc/host/vub300.c
@@ -744,7 +744,7 @@ static void vub300_inactivity_timer_expired(struct timer_list *t)
struct vub300_mmc_host *vub300 = timer_container_of(vub300, t,
inactivity_timer);
if (!vub300->interface) {
- kref_put(&vub300->kref, vub300_delete);
+ vub300_queue_dead_work(vub300);
} else if (vub300->cmd) {
mod_timer(&vub300->inactivity_timer, jiffies + HZ);
} else {
--
2.55.0
reply other threads:[~2026-08-16 15:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260816153809.7067-1-jakovnovak30@gmail.com \
--to=jakovnovak30@gmail.com \
--cc=johan@kernel.org \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=runyu.xiao@seu.edu.cn \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+1ee4f3b9228e35f14677@syzkaller.appspotmail.com \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox