From: Triet Hoang <triet.hoang.dev@gmail.com>
To: don.brace@microchip.com
Cc: James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, storagedev@microchip.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Triet Hoang <triet.hoang.dev@gmail.com>
Subject: [PATCH] scsi: smartpqi: Handle pqi_alloc_io_request() failure
Date: Mon, 17 Aug 2026 10:35:05 +0700 [thread overview]
Message-ID: <20260817033505.736519-1-triet.hoang.dev@gmail.com> (raw)
Check the return value of pqi_alloc_io_request() before dereferencing
the returned request in pqi_submit_raid_request_synchronous() and
pqi_lun_reset().
Return SCSI_MLQUEUE_HOST_BUSY when a request cannot be allocated so that
the operation can be retried instead of dereferencing a NULL pointer.
Signed-off-by: Triet Hoang <triet.hoang.dev@gmail.com>
---
drivers/scsi/smartpqi/smartpqi_init.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index 5ec583dc2e7d..0930decef404 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -4667,6 +4667,10 @@ static int pqi_submit_raid_request_synchronous(struct pqi_ctrl_info *ctrl_info,
}
io_request = pqi_alloc_io_request(ctrl_info, NULL);
+ if (!io_request) {
+ rc = SCSI_MLQUEUE_HOST_BUSY;
+ goto out;
+ }
put_unaligned_le16(io_request->index,
&(((struct pqi_raid_path_request *)request)->request_id));
@@ -6353,6 +6357,9 @@ static int pqi_lun_reset(struct pqi_ctrl_info *ctrl_info, struct pqi_scsi_dev *d
struct pqi_task_management_request *request;
io_request = pqi_alloc_io_request(ctrl_info, NULL);
+ if (!io_request)
+ return SCSI_MLQUEUE_HOST_BUSY;
+
io_request->io_complete_callback = pqi_lun_reset_complete;
io_request->context = &wait;
--
2.53.0
reply other threads:[~2026-08-17 3:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817033505.736519-1-triet.hoang.dev@gmail.com \
--to=triet.hoang.dev@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=don.brace@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=storagedev@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox