The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jiebin Sun <jiebin.sun@intel.com>
To: namhyung@kernel.org
Cc: acme@kernel.org, mingo@redhat.com, peterz@infradead.org,
	adrian.hunter@intel.com, alexander.shishkin@linux.intel.com,
	irogers@google.com, james.clark@linaro.org, jolsa@kernel.org,
	mark.rutland@arm.com, dapeng1.mi@linux.intel.com,
	thomas.falcon@intel.com, tianyou.li@intel.com,
	wangyang.guo@intel.com, jiebin.sun@intel.com,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v9 2/9] perf c2c: add function view model skeleton
Date: Mon, 17 Aug 2026 17:46:16 +0800	[thread overview]
Message-ID: <20260817094623.3288456-3-jiebin.sun@intel.com> (raw)
In-Reply-To: <20260817094623.3288456-1-jiebin.sun@intel.com>

Add the initial common model for the c2c function view: model state and
small helpers shared by the hierarchy construction and formatting added
in later patches.

Build the model from util/ so it remains independent of the TUI and
command-private symbols.

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Dapeng Mi <dapeng1.mi@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Falcon <thomas.falcon@intel.com>
Reviewed-by: Tianyou Li <tianyou.li@intel.com>
Reviewed-by: Wangyang Guo <wangyang.guo@intel.com>
---
 tools/perf/util/Build          |  1 +
 tools/perf/util/c2c-function.c | 66 ++++++++++++++++++++++++++++++++++
 2 files changed, 67 insertions(+)
 create mode 100644 tools/perf/util/c2c-function.c

diff --git a/tools/perf/util/Build b/tools/perf/util/Build
index 1dfd92cbe3b7..b26a0b1ddfa3 100644
--- a/tools/perf/util/Build
+++ b/tools/perf/util/Build
@@ -12,6 +12,7 @@ perf-util-y += block-info.o
 perf-util-y += block-range.o
 perf-util-y += build-id.o
 perf-util-y += c2c.o
+perf-util-y += c2c-function.o
 perf-util-y += cacheline.o
 perf-util-$(CONFIG_LIBCAPSTONE) += capstone.o
 perf-util-y += config.o
diff --git a/tools/perf/util/c2c-function.c b/tools/perf/util/c2c-function.c
new file mode 100644
index 000000000000..ca82425a28dc
--- /dev/null
+++ b/tools/perf/util/c2c-function.c
@@ -0,0 +1,66 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * C2C function model - function-level cacheline sharing analysis
+ *
+ * Displays a 3-level hierarchy showing which functions share cachelines:
+ *   Level 1: Read-side functions sorted by Cycles % (estimated load cycles)
+ *   Level 2: Functions sampled writing the shared lines read by level 1
+ *   Level 3: The specific cachelines where the two functions contend
+ *
+ * Builds the hierarchy from the existing cacheline histograms
+ * (c2c_hist_entry->hists), reusing the shared c2c data structures.
+ */
+
+#include <errno.h>
+#include <inttypes.h>
+#include <stdlib.h>
+#include <string.h>
+#include <tools/libc_compat.h> /* reallocarray */
+#include <linux/list.h>
+#include <linux/rbtree.h>
+#include <linux/zalloc.h>
+
+#include "addr_location.h"
+#include "c2c.h"
+#include "cacheline.h"
+#include "hist.h"
+#include "map.h"
+#include "mem-events.h"
+#include "mem-info.h"
+#include "sort.h"
+#include "symbol.h"
+#include "thread.h"
+
+struct c2c_function_model {
+	struct c2c_hists	function_hists;
+	/* Total estimated cycles across all level-1 entries. */
+	u64			total_cycles;
+	/* Source cacheline histograms; not owned here. */
+	struct c2c_hists	*cl_hists;
+	/* --coalesce field list, used to require iaddr. */
+	const char		*cl_sort;
+	/* Do not cap long symbol names. */
+	bool			 symbol_full;
+};
+
+static struct c2c_function_model c2c_ext __maybe_unused;
+
+static inline __maybe_unused u64 c2c_hitm_count(const struct c2c_stats *stats)
+{
+	return stats->tot_hitm;
+}
+
+static inline __maybe_unused bool symbol_name_equal(struct symbol *a, struct symbol *b)
+{
+	/* Two unknown symbols compare equal, matching cmp_null() in util/sort.c. */
+	if (!a || !b)
+		return a == b;
+	return arch__compare_symbol_names(a->name, b->name) == 0;
+}
+
+static inline __maybe_unused u64 hist_entry__iaddr(struct hist_entry *he)
+{
+	if (he->mem_info)
+		return mem_info__iaddr(he->mem_info)->addr;
+	return he->ip;
+}
-- 
2.52.0


  parent reply	other threads:[~2026-08-17  9:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17  9:46 [PATCH v9 0/9] perf c2c: add a function view Jiebin Sun
2026-08-17  9:46 ` [PATCH v9 1/9] perf c2c: extract shared data structures into util/c2c.h Jiebin Sun
2026-08-17 20:34   ` Ian Rogers
2026-08-17  9:46 ` Jiebin Sun [this message]
2026-08-17 20:53   ` [PATCH v9 2/9] perf c2c: add function view model skeleton Ian Rogers
2026-08-17 22:48     ` Namhyung Kim
2026-08-17 22:53       ` Ian Rogers
2026-08-17  9:46 ` [PATCH v9 3/9] perf c2c: add column rendering for function view Jiebin Sun
2026-08-17 20:58   ` Ian Rogers
2026-08-17  9:46 ` [PATCH v9 4/9] perf c2c: add HPP list parsing for function view columns Jiebin Sun
2026-08-17 21:04   ` Ian Rogers
2026-08-17  9:46 ` [PATCH v9 5/9] perf c2c: add function view stats merge and memory management Jiebin Sun
2026-08-17 21:05   ` Ian Rogers
2026-08-17  9:46 ` [PATCH v9 6/9] perf c2c: add function view hierarchy entry creation Jiebin Sun
2026-08-17 21:06   ` Ian Rogers
2026-08-17  9:46 ` [PATCH v9 7/9] perf c2c: build and finalize the function view hierarchy Jiebin Sun
2026-08-17 21:11   ` Ian Rogers
2026-08-17  9:46 ` [PATCH v9 8/9] perf c2c: add function view browser UI and cacheline detail Jiebin Sun
2026-08-17 21:12   ` Ian Rogers
2026-08-17  9:46 ` [PATCH v9 9/9] perf c2c: document function view in perf-c2c man page Jiebin Sun
2026-08-17 21:16   ` Ian Rogers
2026-08-18 21:23 ` [PATCH v9 0/9] perf c2c: add a function view Namhyung Kim
2026-08-20  2:10   ` Jiebin Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260817094623.3288456-3-jiebin.sun@intel.com \
    --to=jiebin.sun@intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=thomas.falcon@intel.com \
    --cc=tianyou.li@intel.com \
    --cc=wangyang.guo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox