From: Jakub Kicinski <kuba@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org, Marc Dionne <marc.dionne@auristor.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v7 00/11] rxrpc: Fix CHALLENGE packet handling
Date: Tue, 18 Aug 2026 07:49:10 -0700 [thread overview]
Message-ID: <20260818074910.5618ecb9@kernel.org> (raw)
In-Reply-To: <2038699.1787058233@warthog.procyon.org.uk>
On Tue, 18 Aug 2026 14:03:53 +0100 David Howells wrote:
> Okay, there are only a couple of things that might merit producing a v8:
>
> (1) There's a missing key_put() in afs_open_socket()'s error path.
>
> (2) I should probably require READ permission on the key holding the appdata
> provided by usespace through RXRPC_RESPONSE_APPDATA rather than SEARCH
> permission to prevent this being used to pull the data out of keys that
> can't otherwise read directly with keyctl().
Let's do a full v8 if you don't mind.
I gotta wrap things up for the -next PR and still ~260 patches
in the queue 😣️
next prev parent reply other threads:[~2026-08-18 14:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 11:01 [PATCH net v7 00/11] rxrpc: Fix CHALLENGE packet handling David Howells
2026-08-12 11:01 ` [PATCH net v7 01/11] rxrpc: Fix sendmsg to not return an error if last packet queued David Howells
2026-08-12 11:01 ` [PATCH net v7 02/11] rxrpc: Fix sendmsg length David Howells
2026-08-12 11:01 ` [PATCH net v7 03/11] rxrpc: Fix packet encryption error handling David Howells
2026-08-12 11:01 ` [PATCH net v7 04/11] rxrpc: Fix update of call->tx_pending without holding lock David Howells
2026-08-12 11:01 ` [PATCH net v7 05/11] rxrpc: Fix generation of notifications after call completion David Howells
2026-08-12 11:01 ` [PATCH net v7 06/11] rxrpc: Expand abort trace enum David Howells
2026-08-12 11:01 ` [PATCH net v7 07/11] keys: Add refcounting to user-defined key type payload David Howells
2026-08-12 11:01 ` [PATCH net v7 08/11] afs: Create a server appdata key David Howells
2026-08-12 11:01 ` [PATCH net v7 09/11] rxrpc: Pass appdata key to rxrpc_call and thence to rxrpc_bundle David Howells
2026-08-12 11:01 ` [PATCH net v7 10/11] rxrpc: Fix CHALLENGE packet overqueuing and simplify RESPONSE generation David Howells
2026-08-12 11:01 ` [PATCH net v7 11/11] rxrpc: Remove OOB challenge/response code David Howells
2026-08-18 1:58 ` [PATCH net v7 00/11] rxrpc: Fix CHALLENGE packet handling Jakub Kicinski
2026-08-18 13:03 ` David Howells
2026-08-18 14:49 ` David Howells
2026-08-18 14:49 ` Jakub Kicinski [this message]
2026-08-18 15:05 ` David Howells
2026-08-18 14:58 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818074910.5618ecb9@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox