From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59A34175A8B for ; Wed, 19 Aug 2026 15:20:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787152846; cv=none; b=PHT9WuuYESoc+uBPh0ES+PxVRPCiBVclQNZklF+PGAfKRcChKJE67OmO8DULyoid27V1LcBzyETQCE2zA8lC+44Gz+b7IglVFeI1VV+Hw5YI0Ou7S5eTHlPWPAU8KyQp6Djpi7RIskDacuAwqHBMYMHQV49OMIUtZh3i5ECfdWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787152846; c=relaxed/simple; bh=NktYR13aQGEZKI3EO5FCbGzBjpVy+3k0GIvRZjmI+vY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=d1/EHnl1NNSf1CI2YdOP6Rhd5p8aOl94eNZh75RjhwVZkgnyLj9IScDlrb+OBsErVu2feTLOKgiMVBc8+hQFTKBjkBYZ34jjbIJlBxxTwbemOmPhKEcr+W7q3Kjzu6zzeQOBZF20uQdP+NNLqLeCPiKMqaA30bLYkSalP19BXUs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dd6iIWOz; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dd6iIWOz" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2ce7d2adef4so14956615ad.3 for ; Wed, 19 Aug 2026 08:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787152845; x=1787757645; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=OWrkfvF0AtjljV0m6J5emA4PqOIDBL9kVxpQPrwf6n0=; b=Dd6iIWOzy3GbggjuL47hl2sDCZumb4GQnaXyWMYEOvVlcEu+3b+/G+/jTz7EOE7T6Z 7XHQFcQGqvAJxq7zUFbOSUfyQvNXTXlnOIdpTCCYe8/XDIrD179TQp/1uItGVDm5G0VU yjcC+rI8JjhFpRoiozaq9+EX5/EcUTGKtbalbnNGLi8g9ciV5NtCzp1VUj4SAB+Ow44R w3/ZVmlTawrvTDnFyi8KtY6w+2+GMtysUMpSdfpFfJvy2eDdUGquI4rdIAeERtaM3Jdy 2aLIvTBbVXVsC6KB8tob9hH0NRazxltYp/O+hB2W85uS/NhTRnS3p1QaCGTJPrqOdvs7 Sxew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787152845; x=1787757645; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OWrkfvF0AtjljV0m6J5emA4PqOIDBL9kVxpQPrwf6n0=; b=WDqlADPCI2x5TX4CVx45EbJbg37F3py9j9hXpCGibTMOQClGbS72WdBq2N3yZ/TzWY bq9L6jPcdPaKUItQEekX1TIQKw/31X5fS4bxO4hFOtswoAEeoWZtq8qFh/OyHNXZ7ubM ir+g6WuEBvCKr94Dga0Ta+2gT2povekHbnohFR8pnJ+FViI80qUwqYgdK9CGx1eiZYTu 59Ae0nj85ud5RUdMaTVk3WbeXMEazvSoKv/V51r8PwQ53srMdD1HPTmGDldVtCJR03bn +JGqMdFeV8tgifgP+2TtZAYGRLVmRDle01sy5hJN9D4GzcOjAgeBpQX2cVujII7Uucyk S+5w== X-Forwarded-Encrypted: i=1; AHgh+Rrsrr1ABAza5Ru3wX6XbIFk0Q+nt6lHjg6zJ+IySwY9B1apviuhn36EvDs0JGc1EbXxVzX2rQ+Yp7ZPq14=@vger.kernel.org X-Gm-Message-State: AFuF++nxEmYMls7+Gzw/mDhp2w6fKPZXOTK6u8n9lLakdmeTqZlTuiav kyS7h4/KJW+QKzAJTzhdC7QtNkWl5lPwQIdHwzf1xYBG5rGVQjY7Xuw9 X-Gm-Gg: AR+sD10eMvW6dwHJmgMYetwR6756hccJMLBZWkrsc/4lIr6UhkNY9hXSNQKRwz275DK BpiKX0aDr06YBvnDlZ4d1/9dRk4Umma1rqJGEa+KdSwvb7UNdD4+jyq+33wmHt80Oc45GMLDY65 aOyiI4u7SkXlGsJGU+YytTp5BoVjPsS5kQTnlMld3apZCn2AcNVih6ppi7ZUwXYZ/dt+UWVHRJf 9xb+0aJ/BxVo0NixvsM0HezLEMNEt/njlmtVyn7x7Lm0feK7sMuJiKyzOUH3w7rdHwD+/Q8ONI5 1ALWFuwdc8S55OlWkolmmURxohRb7EqqQyEBwuyzGiK4siTrOgp8lmuHJ4xjO2/rR3h4nXJEnof BSc8D6A/y/3UXtaHHfNZRCMS6v2kJiscXY+IftyUVqmi+iHsXPPkYCZNuwzG4NRGIYBpfzw6LsR o8jDkOOL9V0kbtoT6Zr7R1Cp4GwqEKqmDVPsjDRB8RIESLSEfc1nfEw5uA+PpLMRES9I5V/qIod huIMQ== X-Received: by 2002:a17:903:1987:b0:2ca:61bc:317c with SMTP id d9443c01a7336-2d601a8baf8mr98123875ad.13.1787152843091; Wed, 19 Aug 2026 08:20:43 -0700 (PDT) Received: from localhost.localdomain ([188.253.118.67]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d5c1ecb1c1sm27294945ad.66.2026.08.19.08.20.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 19 Aug 2026 08:20:42 -0700 (PDT) From: Chang Wu To: Heikki Krogerus , Greg Kroah-Hartman Cc: Jan Remmet , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Chang Wu , stable@vger.kernel.org Subject: [PATCH] usb: typec: hd3ss3220: track VBUS enable state per consumer Date: Wed, 19 Aug 2026 23:20:27 +0800 Message-ID: <20260819152027.90994-1-kunjinkao.jp@gmail.com> X-Mailer: git-send-email 2.48.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit regulator_is_enabled() reports the aggregate regulator state, not whether this consumer holds an enable reference. If another consumer enables VBUS first, the driver can skip its own regulator_enable() call and later attempt to drop a reference it never acquired, triggering an unbalanced regulator disable warning. Track successful enable and disable calls locally. Keep the state unchanged when an operation fails so a later role or ID notification retries the operation while this consumer keeps balanced references. Fixes: b3f9d6e491fd ("usb: typec: hd3ss3220: Check if regulator needs to be switched") Cc: stable@vger.kernel.org Link: https://github.com/qualcomm-linux/kernel/issues/472 Signed-off-by: Chang Wu --- Testing: - scripts/checkpatch.pl --strict: passed - Qualcomm CI checkpatch, sparse, DT and UAPI checks: passed - Not tested on hardware drivers/usb/typec/hd3ss3220.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c index d0de5a2488f9..4eec90c82bae 100644 --- a/drivers/usb/typec/hd3ss3220.c +++ b/drivers/usb/typec/hd3ss3220.c @@ -62,6 +62,7 @@ struct hd3ss3220 { int id_irq; struct regulator *vbus; + bool vbus_enabled; }; static int hd3ss3220_set_power_opmode(struct hd3ss3220 *hd3ss3220, int power_opmode) @@ -208,7 +209,7 @@ static void hd3ss3220_regulator_control(struct hd3ss3220 *hd3ss3220, bool on) { int ret; - if (regulator_is_enabled(hd3ss3220->vbus) == on) + if (hd3ss3220->vbus_enabled == on) return; if (on) @@ -216,9 +217,13 @@ static void hd3ss3220_regulator_control(struct hd3ss3220 *hd3ss3220, bool on) else ret = regulator_disable(hd3ss3220->vbus); - if (ret) + if (ret) { dev_err(hd3ss3220->dev, "vbus regulator %s failed: %d\n", on ? "enable" : "disable", ret); + return; + } + + hd3ss3220->vbus_enabled = on; } static void hd3ss3220_set_role(struct hd3ss3220 *hd3ss3220) base-commit: e1e6e541c5c9cf548e9fdc35fc26808c82074440 -- 2.48.0