From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6058E2DEA86 for ; Thu, 20 Aug 2026 10:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787221980; cv=none; b=qeZZFrWfdd1JzUpsQFPWEBm3K2n13lOJck7o5H86EXVBjaLH5U0dPAcEy5KPo5wIxrvbZPL005pl7m97VKWcEGG07+ytl1cEQ/uPUFuaGkuRqBbGViPXrrPEk2ZaDBP/xq/5c2XY1VA5VC7d4uTEDsKclFEMWKOfxk8hhj9qhRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787221980; c=relaxed/simple; bh=rU0inurGfuVNqiivnFFxonhbpYxf2IoFX7ZqKOZ6q6s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aUQ3iGCbPN0eCJVEb9LHOfjvFlFdk8zR10h0dPzbGg/j5Ar4Jfe6WdXaCnXVLMAqJZyEhZTF0I7+XH9j1pN07hF5Iyu2tRDs96zXsactxI2EhF/src954G0s80A3v86KiQ81NSYbEeG8ClP3/yJhLp6xmgV07j+zSqhh8Z7bQWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oHhcvJkI; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oHhcvJkI" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-382ef647e20so2019347a91.1 for ; Thu, 20 Aug 2026 03:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787221979; x=1787826779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=HJMXBFUIIiKJNcYXXTC8I0y6i6qk6AHSMlYQbxaA2yA=; b=oHhcvJkIl8zI31PUMhwXlQKuNCk8a5mPFLFl7qiEM2vHanQOHsIwNKPeIOrGlWIUTu LbMXQz+TB2puI4DjzgNuYcBB26zfenFFATmVIFWJsGnblP4N/KkZDCqEr129TBxEsM2h jlqTs4eqySpJ4cxJWIb4T5SyRn7O9Z6sLXrZYpRrz4mzD5mK7pcv9g98f20PyiAv9XMz PK0a2XDnVErkmbZCnrdi2967MgLKPBgAin/SNmCoTyoE1jLWLtJsXL5TeEytUxvR9lPo UhrVLG6/10s5uKdKDAy4TnwFzdTZNfWaDK701HP4eMgIqS4NeF8rTkhhYpClGAwDPd1M 3yzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787221979; x=1787826779; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HJMXBFUIIiKJNcYXXTC8I0y6i6qk6AHSMlYQbxaA2yA=; b=b6c7yw2NwXjcE/rhBvItHehClmJwoIMV4nBtMTprXTBe7EFcafkJsWwTQT+bHNlIOT 1VQw6vRIeeq7pHIXUQiAJzuHq8r/MNnPugOCFW2hmzV5AAO4c0CVWvzbC0F28tOMVpU6 0QMLwbob/fBHV7MTk2lpKPYGLVUGgqPB9xgg26CnP/YlgFGks/yiSoo6TbPTLl7XRChj vUjU/NbOpkF4YSU0d6Zq8dRFwmeURm5kq7rXCQUGudgyW+viF8ipJFdarLypyjj4UioZ TLO/Mry7Xmc0AORS+tH9y3+vdt/H7KLlD8mfYPmthdMxBj7c8spw7FTaMlnrNlyBMoF2 zffg== X-Forwarded-Encrypted: i=1; AHgh+Rp5q0DTmc/MtNl0twrOVoeK+erwlEgqlxFPrrAINbXdRbnbY2PZYO6J+cQcYWWuLm/mPdlGbPiqMyXMeg4=@vger.kernel.org X-Gm-Message-State: AFuF++mY9A5P4EUrJj8NpCJHFKFnfZsMDo9/Fl7lE7oOtTGl+95wfzjO /Z8ibZ/f9xRGIauy/ZubBQCeiiLvojv/BY9GEWtn+vSLdPxPCj14TAe6 X-Gm-Gg: AR+sD12U557bKSFVIZnaIY6j01rDwW+noCcW+R3G636Ufaw5+HnhDBAQJJWqbP5zO6e M2mclUPH9+ymQRBvo5bRLnzMnl1c+msU6orQFezwWtTWg4y9GgWIUqfSJlFJymLN/VcKd6RWHlk CWYVBX+0IDqB3o7R9sX49OQK0scaVMh4oGd/4CV4S78/fnZka1niRrXF+J3HDRh7O6HgNHeG8Bm CddVgcfMt85RGRBiVqWDxaVURmmftV4VeRqNZqRTrLf0XZNSXx6lLuEApKsqs7Otrb3im0CSgfB Psrua78F9/KWSHrd1c0++bFQxkO/cB/yz9k3QGej/ZUF3QGF5waO5YvV192CPajQ7WR5XkzbdYD mPOLCi3+90ZhzgrL1XDKm6LGM63BOr9OMQt8nXLUGk4iH8jY2+hvjPxG2VchMiyHDtwwFJFcbiE jQAzRANqRvrlC8Ws/S8nHqtXuLfWv6u/zd14oXuHBJ96PhNPg/ntGGoncjwQ== X-Received: by 2002:a17:90b:5250:b0:381:9028:5945 with SMTP id 98e67ed59e1d1-3958125375amr23371093a91.14.1787221978516; Thu, 20 Aug 2026 03:32:58 -0700 (PDT) Received: from dio ([103.161.231.135]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1416ad3dd15sm14130550c88.2.2026.08.20.03.32.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 03:32:57 -0700 (PDT) From: singh.supreet14@gmail.com To: Viresh Kumar Cc: Rui Miguel Silva , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Supreet Singh Subject: [PATCH] staging: greybus: spilib: Remove the local unused Date: Thu, 20 Aug 2026 16:02:35 +0530 Message-ID: <20260820103235.12306-1-singh.supreet14@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Supreet Singh The return value of spi_new_device() is only used to check whether device creation succeeded. Remove the unnecessary local variable and check the return value directly. Signed-off-by: Supreet Singh --- drivers/staging/greybus/spilib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/greybus/spilib.c b/drivers/staging/greybus/spilib.c index 39d5bf234c61..0e8711fdc429 100644 --- a/drivers/staging/greybus/spilib.c +++ b/drivers/staging/greybus/spilib.c @@ -444,7 +444,6 @@ static int gb_spi_setup_device(struct gb_spilib *spi, u8 cs) struct gb_spi_device_config_request request; struct gb_spi_device_config_response response; struct spi_board_info spi_board = { {0} }; - struct spi_device *spidev; int ret; u8 dev_type; @@ -480,8 +479,7 @@ static int gb_spi_setup_device(struct gb_spilib *spi, u8 cs) spi_board.chip_select = cs; spi_board.max_speed_hz = le32_to_cpu(response.max_speed_hz); - spidev = spi_new_device(ctlr, &spi_board); - if (!spidev) + if (!spi_new_device(ctlr, &spi_board)) return -EINVAL; return 0; -- 2.55.0