From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF86C35DA4C for ; Fri, 21 Aug 2026 04:45:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787287519; cv=none; b=O48/LCgTluUCMpbW2O8Kjc6Y87f6UVn4BTnDJ5HYXZ1+mPsnQuOXZLdxSY4lOqWNRgzPn/vC8Gu/clgpHH3Lvgtf0vC8QDEV07QfKhkpL6yHygt/2hMo7XyaBGdnaUvMVPXjMrHW/OJtpenfrEGW0MPuZ0ITq833EOxcM7T9qcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787287519; c=relaxed/simple; bh=/rYyAsNpnn77q2igHIHzF4U7Fm87W/o/oL+fIIbim9U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Zzxmu7lSHyRXTlijzPeojfIf/e3w6RMTMeiD5yfGtw9oq5BzK8lIDCTthKMEoghC3vEOXyPpLPkscjyUMSI7dW6ZIS0fGiizPxUjApe5CdWA+/b63Em0oObOLN+GkFPpzmD4v+gd6R0lmvg6rsYfK/2rCE83pozCpvIqdR7etH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GAGV8D9u; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GAGV8D9u" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2d5335cf904so4487405ad.2 for ; Thu, 20 Aug 2026 21:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787287516; x=1787892316; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wNiPWMLMvfqsRA/zVJD9oMR3HcxqazZt4gxnCgRbrbE=; b=GAGV8D9uydTqJTbGazZqKjbSL4ysh++H3Yopl7QRbWu86tFLgBdDHP2ACLvPmePdv7 wD1AwRqnmvpoxiOek93XBAqWAbsR012DMnJ6SRxgYDaX1O98yTByi4c6oRrEsjevpcoM ++kmnNmaujqktpT55DOONAm8skphjvRgPQdCAOTwCf7xx8TNhn34qWHxqaIBBrN3O/a5 OZ9f9u8aeHZjCk91ksLs/bcXfWQeNr+EK0e/bXnUBjFwc/LNIbHWqiLRTxee4O408jA0 JdJblXWD+PWYAeZTjt25rd+UAtBS4Q6NBs4Dz6Pq1x6bedts2FdH+zUxJj1X6NRMD6WI 21EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787287516; x=1787892316; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wNiPWMLMvfqsRA/zVJD9oMR3HcxqazZt4gxnCgRbrbE=; b=NpNM0Ox2wkXD1y16SdWWb5zd3P2BeXE7fWxMCfwS9e8WfI+4vf9V7GYlQFxRSTX9rU OAf5Z2A+ltSX59wUTtA1KJiDXbTUpDc72FncCD9Pm07VjV1op4C2+pdUMGARqLlElFkD rPLP9tovJaarjbny2uRErfjzFdLulYqLFshycCau3sW6SZw0OqA8d1REf7sY6/DJmdkC bP+X5d1SOLdjeWyGfYHHrZSUu2uT+BSIaL/PSpSTOZYpD7/sO61Kl9yo2PYyASnKeIaq X8UlijeEkf55/72wAIZGK96yeU7H0eMtmRGiIEeaqjhk/8C411uP8GTT2cK0bFEFRytX /PAQ== X-Forwarded-Encrypted: i=1; AHgh+RodcoqP4PGeRc25AQJe1hS/uOH7rmnP+n3M+urFGBnViCPWjJohDn2tfLXC7Iye9TG2Rb1s+I2RKLp9+30=@vger.kernel.org X-Gm-Message-State: AFuF++kp6p9Tp22RFpEK5+VGIHXOhFdUsQ03YYo39V716hIcl589JW1n QoiM5uTI6Z4+BmLrhQozYULI6T4vxe9k2VNtoQgzrOOgzU0OSFt/xaY/ X-Gm-Gg: AR+sD1360Am1PFVxwRDPAj3LywVUyN0VS2MnMXVJH98p5fkb+T5zeobvPM45d7jDHb+ LQnba6m3XtRLIKxlZOErwNF5aQkQRdt5AtlXTP1wSv79lMC6ncDf7NWI3lUkq5Yiqudp9t03x6J dMHMChuprKuftlvboW+hz//qrKvSrcyOExcxCJ1v7aysmXlE8SRpc9H9g6/eGE93ZbyPzIpw1XA KH7tyZtYyyYsk4xFCHbqlQzjQXpf7uvtwjqTU1EX4hjnR02r6SrtRxkQvyfoU8Gd7fIPxZnE9ul oA7dvp4+5GoMz34B5dDjp1IZm+EGIrMT1oAzbb7gdA09L5OvlgKEH6V9Qqn8Vypn5MfhcpGmaH9 bMhec3u8pRKFEEAfOnzYOLrwQ5foAGDMicrek1+QQZ7w76+fbi+OcD43bf6sYjBvxWlnboE2NCn yI+cUvdvASrhL5vKgS/5G/edMfo8yWUdGNsZJhrSBR5mDi6fq4iCSbZZc0uA+eSZmgg7d0AHP+g U81mBJWTfJ+9g== X-Received: by 2002:a17:903:19c7:b0:2b7:975c:dacc with SMTP id d9443c01a7336-2d64ada9e7bmr78105145ad.1.1787287516141; Thu, 20 Aug 2026 21:45:16 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf15ff5dsm22352792eec.25.2026.08.20.21.45.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 21:45:14 -0700 (PDT) Sender: Guenter Roeck From: Guenter Roeck To: Michael Chan Cc: Pavan Chebbi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , Kalesh AP Subject: [PATCH] bnxt_en: Fix call to hardware monitoring event handler Date: Thu, 20 Aug 2026 21:45:12 -0700 Message-ID: <20260821044512.663941-1-linux@roeck-us.net> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The first parameter of hwmon_notify_event() is supposed to be the hardware monitoring device. The bnxt driver calls it with the platform device as first parameter instead. This API break results in undefined behavior and may result in a crash. Pass the hardware monitoring device as parameter instead to fix the problem. Fixes: a19b4801457b0 ("bnxt_en: Event handler for Thermal event") Cc: Kalesh AP Signed-off-by: Guenter Roeck --- drivers/net/ethernet/broadcom/bnxt/bnxt_hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_hwmon.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_hwmon.c index de3427c6c6aa..faed0cf726e1 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_hwmon.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_hwmon.c @@ -40,7 +40,7 @@ void bnxt_hwmon_notify_event(struct bnxt *bp) return; } - hwmon_notify_event(&bp->pdev->dev, hwmon_temp, attr, 0); + hwmon_notify_event(bp->hwmon_dev, hwmon_temp, attr, 0); } static int bnxt_hwrm_temp_query(struct bnxt *bp, u8 *temp) -- 2.45.2