From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AECC4746B1 for ; Fri, 21 Aug 2026 10:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307919; cv=none; b=WPF4iwHaN7AYY9YzGQ1gujVBuWlFuCVkkST4Qs8jHE/tqJSl9kFRHDkleW+dlvSCWRq7C9ncmggp/d4VhCdyYwQv2Gg1NnLFxnkrRSvJo71K6rWonH8t1F4pGiIJhiM2rSxf4S4tAQnr++9JFoPSDfiBgJpnHi3TcE5tGDPdEXs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307919; c=relaxed/simple; bh=qh4p6NiaYYKZWRo5SdC+29bJh1njzkmd5IdAQaiKg10=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Czd4EiMCIKe1qOrU72CfskI8oLaLzaTtpoury5Vg/o3Es7kbbpMk1Bh/T/JFX9LQOzgutIAW4oOtIl7hvM4NJvdQTQbPkaLTATwBvj9bIUmwAFulNLYxMRZ1z3yVVPaqXr1ie/lc9GzQXBGknBFG77W/S2puQHa4FvZWHVuBdrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QwmKueW8; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QwmKueW8" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4980dc26022so5985685e9.1 for ; Fri, 21 Aug 2026 03:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787307911; x=1787912711; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XsQREIODkCao/QDK0V814PCMzSICvR9cgatjnm3y9Ns=; b=QwmKueW8i3NewAouoHlS1hrLhhNRGwI78Scj5VmDnm1ASoYnMgXDG15HIN2cOIVxCz mi59CO1xr9c6JtjXPgftU/f9kbaP8zNNjsp/oIJ+5X5vxniZDKFyNDITl2JivjhUS9wV D76OrnMiEOnF8HZP1aI4TiEGSC7Ihapj8JofYEe55D7B2quA0wtAu+ZwlwOAg54ArZqt HtDVUJQ8qN7VQIS7AWzxDHt6u0jEBeg/+7IJIgjH55xJeIctl2ugmCtNH1LBydEtkj8e 80nthjybcL50DdYNH5SdX9uy5zy1xjdW+rXH/cjaX3jxjJnahXMWRVG4L3hVmhNZ7RpW vFpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787307911; x=1787912711; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XsQREIODkCao/QDK0V814PCMzSICvR9cgatjnm3y9Ns=; b=gqzf834vUiQwzEitd4YhsGZemDd+xcatNDRpjFW0crhLKdGdvTMedb2zm2HrczcGOK niJeQ62wyMCWQ6mmf7lJtyeoAV/nsEuxxsciAqlBoZaY38/LTF2ub6fmwVe9Q4ZXfzVy idBY1EnkMwvqBfypay2YYQclIpHl3j2QBCYQfpXB1x338Z2iWZr03povfTQudl0JBd9w 5Z1SMTwJzkAURYycbR3ZvT9EkQVeCTB4p8bXUGKax3wSULoK9uy0y/oGtPYu1QbO9DlJ 8Dn27m+zP5TMGlaHhywtJb462ygjAMT51ZUlUt5qeO1DB0pK9S1k25nYroZRbp3qZf7P aOlA== X-Forwarded-Encrypted: i=1; AHgh+RoculfQ+CpTZ0aI/Qu5n4DXvlPANc+RchleTRlKeQ5soNQZ8t2ctOrMOPOPP58z5/yBRSRWHnGg4ZVMcI4=@vger.kernel.org X-Gm-Message-State: AOJu0YxjIAtu0zJvWLu4FPVB7OYq0WWYddkBizY4qEP/q4FSrBkf1Cdb I3tPIMctbZZvKjGTwqMqiairf+ArrHxIdV2IPKrFEiWmQrV6GgCv0j6R X-Gm-Gg: AR+sD10CYC0nhOUoFy0F6YhIzXYqLf6dkZo+n9ZXCX414hc2f6E3GU1pC3yRnqZyCpo 9vhMdWQiJ2YnZZ55/sFkVzHa8x8Ks86ko5NeLJxt86B/86yqe/Ovi9p5I0iIKBsv7Tb1EG2KPZl nDJZL4Kp1ibhK75pacQfjW8bBX3i4Ypr2H7L5fhbsW/g40cURNV4Dn7zUkEZOQ8LvnYMgezD5j+ gYuc1tEv7LKe0PIMBzpya/+kpWdUtMBKf1aYhCbHjG/3KKAZaMvU3+aAwDjosM/15JFKyNYcuwa FKvdNgqPoPxmlj7fosFNaeQt3JPMV3+RivEukyRF72bpcF8jdpNyNtmWBxNfi0sbb7q2enKC12v 5p1xhyH/zQlnd27PPu6Fgzt5CqJ+A8IsLnIpQOO5t8q35TC59Z4/EeYhgjHy5ggKskaOZoo25iS DBYe1K0B/z7j2NqZcJNJowNQxBZd/e+Dx4i6bvTnxACSeOPkqzUe9OHVu2+h/MxhpHZp995Nr8T MeO3X9R02iTjw== X-Received: by 2002:a05:600c:3550:b0:499:8777:ccba with SMTP id 5b1f17b1804b1-499b830156bmr76380145e9.12.1787307911253; Fri, 21 Aug 2026 03:25:11 -0700 (PDT) Received: from fedora ([105.74.130.192]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499b9ba5139sm11663155e9.2.2026.08.21.03.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 03:25:11 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: jic23@kernel.org, lars@metafoo.de Cc: Michael.Hennerich@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v5 3/6] iio: dac: ad5504: separate ACPI and DT paths Date: Fri, 21 Aug 2026 06:24:45 -0400 Message-ID: <20260821102452.37407-4-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260821102452.37407-1-0rayn.dev@gmail.com> References: <20260821102452.37407-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver relied on a fragile -ENODEV check from the regulator framework to bypass voltage configuration on ACPI platforms, sharing the same fallback path as legacy pdata. Fork probe on is_acpi_device_node() to explicitly handle each path. On ACPI, skip the regulator and use a fixed 60V default via AD5504_VREF_ACPI_DEFAULT_mV. The pdata fallback remains for non-ACPI systems in this commit; it is removed in the next. Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 5c9c66b04154..6f70c57c7a82 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -5,6 +5,7 @@ * Copyright 2011 Analog Devices Inc. */ +#include #include #include #include @@ -12,10 +13,12 @@ #include #include #include +#include #include #include #include #include +#include #include #include @@ -24,6 +27,10 @@ #include +/* + * In case of ACPI, we use the 60 V as default voltage reference. + */ +#define AD5504_VREF_ACPI_DEFAULT_mV (60 * MILLI) #define AD5504_RES_MASK GENMASK(11, 0) #define AD5504_CMD_READ BIT(15) #define AD5504_CMD_WRITE 0 @@ -285,16 +292,20 @@ static int ad5504_probe(struct spi_device *spi) st = iio_priv(indio_dev); - ret = devm_regulator_get_enable_read_voltage(dev, "vcc"); - if (ret < 0 && ret != -ENODEV) - return ret; - if (ret == -ENODEV) { - if (pdata->vref_mv) - st->vref_mv = pdata->vref_mv; - else - dev_warn(dev, "reference voltage unspecified\n"); + if (is_acpi_device_node(dev_fwnode(dev))) { + st->vref_mv = AD5504_VREF_ACPI_DEFAULT_mV; } else { - st->vref_mv = ret / 1000; + ret = devm_regulator_get_enable_read_voltage(dev, "vcc"); + if (ret < 0 && ret != -ENODEV) + return ret; + if (ret == -ENODEV) { + if (pdata->vref_mv) + st->vref_mv = pdata->vref_mv; + else + dev_warn(dev, "reference voltage unspecified\n"); + } else { + st->vref_mv = ret / 1000; + } } st->spi = spi; -- 2.55.0