From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06FE647ACF8 for ; Fri, 21 Aug 2026 12:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315600; cv=none; b=XiEKJtAtr5MfDErDvQbVh93hGjF/9gLNqM1jl1XQCK/5Fd4YH3F02aIWkPF18EWih3B4EaskHwR9R5wLcKFVHjkJuA8VF1Nr06xND+NPcC4JoT22Pb+BsHXkBYiDko6ezWvNiOfSWU0a6NjnO+roCiIVk5hpuNlF38z7pvsReQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315600; c=relaxed/simple; bh=vc9oGAqRaMzb6Xdaj+3NGIpap5QZHwRnk2S+pTd4Ur0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TWce69lHx6wCNUS7JjFizkt/p8QhvC9B2vjYHgo5tTLN/XstKXFrDdV4e4x7l0Yvqb1FNTpBDv5YXaNvZ0qMFfrthdniSc64NfEXe8DdBfBwyzQAcOBB9QrqvTa3yCy3Cb1r332fmI07xGuW4nMyY4fCCmCasx1cjHCm3Npr100= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=tINavzeZ; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tINavzeZ" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2cedda2ce6fso5498005ad.1 for ; Fri, 21 Aug 2026 05:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787315595; x=1787920395; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vwKd+TdvIX9ZItYpiwc95hBpIK2+IZI68PvC5hF8oBU=; b=tINavzeZOKMANcMRwKeEUWydp5nWIoCKCrIuctzNkQTHBo31qrRTSBUTIDJjtxHnsi h4p/Wt+VS7MgdRRg1DeUNAnR5t+m9OXzxQGaGegxWFUNw8MynWuU63q93KlaLtzkt4tD fRwMOkbWF8ApoG2dkDeCd0zoPmtpuv5aAqb2Tk47BR2+tXh8Q+GHmkikR+BZQ9rGo+xf dSOJbOnrTCWLmv5W7rnGfhmNWha2CKjeBYNugHvOkpy+wj3UeqxabEacwOhYBZ814Wz2 meBrQK5cu/cUu6nENqQie/qHivE0WKpUZoNslaNbFVDJ0EZdODKp8Ra9D5MwnMAdPIVX tP3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787315595; x=1787920395; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vwKd+TdvIX9ZItYpiwc95hBpIK2+IZI68PvC5hF8oBU=; b=XHkPd6noxMfOuM8IidkcAbXWgvlfaNW0mIV1j6a15q9lhT0BSWyyc50aWWyTG8ema4 igwq5u3wrTv97Hh+ZVfMELXXZnoNYexqg354mkqoko/xp7/4J1eNtSucjgDq5Ls0EHf4 kkLaVQG/dlUa9vcgCHJ/eGWkpVF7W30XJSxMvxj6N+r9xl+6zdXNN1b6KSe2Ca45NCvy kFD7OlJsP1rEumThYYDDA0PLUdybYJpok85AsNzeVDfFBO6Lyhax2Gn7Vx/FLG0bpjcT jN6KWxs6GQB7yUv9NrI14mfPu9flO3sN+VbLMN9moAfvqHwjyNE1x4Xg0R/2SSvhyzk4 tE2Q== X-Forwarded-Encrypted: i=1; AHgh+RpMqR347oe4W+L3DeeFT4KagyUONWK5QYIlZLNa5hj3CcYR6mpIt40wpNulwWW6OzXoyBTf/Y2NI1A36NU=@vger.kernel.org X-Gm-Message-State: AFuF++l7ujn4W7d4XOI2av9beWFprgoUv3ORY5wdRHqDKKKOdlI7BJtG BRBaYUN4NJ4piq4d1MfEDdu25wQsmgfqyJW7uSBhf422FF6QNdfDYZVH X-Gm-Gg: AR+sD12AswdIk1IBtuMAz1j4s25lV4/7KNbHmA33qflNia5Ms14TKoWrlYiay3pT/19 IUP/UKb+QbycD04TtLo2w2y/uokZWeWgncQVlQRJvma9vXBkMdAIluSFy5HUcG/KZXHatHkn79P Px6llsjzGzvyNTL5AbwibE2tkLlEJiOw+nBHha1/rmbgxI4Mz0ZteaP8z76M/J+vy/22+OFRdKJ Wqffn/SjlfwJeLKiYB4aZ5DFCfnLBNsoQbbY7ixgmPCjx2gYfsMj8Le3qUBxbh7eGwHMzTB224c s3nFlGQJwBTs721mN72PoGPD4QLd3wQ8B6njHgn3FxTPI+/B/KGcWCJprhvV4BVH+Sc2ncgoX3e xksCkhA5kWLiFV/RW950RrWEvq6rFDqLkBhzHLN5o2iH5Gxr57LhEVsEjKjX4ga+RHnFynpp81i EdIw8OSCH8dX72LwL86ornRIthLfhvXQt6OFp4V/Q8POm7L8QfiNYip11P7twslI3FT1TS7cRUu 2ugHouOrFh+XAcFXLcdaFScGfGbzY1UIob4tuyKJ/UW27ubgK6oTHwOoRuNhQinPADmsv4nuEm+ bOZ89DPKDhG5BFw= X-Received: by 2002:a17:903:3c6c:b0:2ca:9d5a:8b6c with SMTP id d9443c01a7336-2d64adc5f3emr120824505ad.5.1787315594849; Fri, 21 Aug 2026 05:33:14 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d62e36e1d8sm18402285ad.52.2026.08.21.05.33.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:33:14 -0700 (PDT) From: phucduc.bui@gmail.com To: Radhey Shyam Pandey , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Simon Horman Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH net v4 2/3] net: xilinx: axienet: Handle optional IRQ return value correctly Date: Fri, 21 Aug 2026 19:32:48 +0700 Message-ID: <20260821123249.41527-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821123249.41527-1-phucduc.bui@gmail.com> References: <20260821123249.41527-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc lp->eth_irq is assigned from platform_get_irq_optional(), which returns a non-zero interrupt number on success or a negative error number on failure. Errors other than -ENXIO are handled before this check, so -ENXIO is the only error value that can reach this point. Check for a negative value instead of treating 0 as an undefined IRQ. Fixes: 522856cefaf0 ("net: axienet: Add optional support for Ethernet core interrupt") Reviewed-by: Radhey Shyam Pandey Signed-off-by: bui duc phuc --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 207aecb5f8b9..3927ababf833 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -3052,7 +3052,7 @@ static int axienet_probe(struct platform_device *pdev) ndev->ethtool_ops = &axienet_ethtool_ops; } /* Check for Ethernet core IRQ (optional) */ - if (lp->eth_irq <= 0) + if (lp->eth_irq < 0) dev_info(&pdev->dev, "Ethernet core IRQ not defined\n"); /* Retrieve the MAC address */ -- 2.43.0