From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 913A93CAA2F for ; Fri, 21 Aug 2026 12:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315607; cv=none; b=jIPwHDpG0fbRoHKkM1hFMfXxHeQ1rDem8u5UyCirzvZcAk2V53c2p6C6JOckxHQoOtYOVmxVtR2cFIlOoyikoLb2LdYc8a3UcFZlKdRYFWqzRtXpsR/DkgB3cOfkplRMwHJHs5RLEm0ztTSTUbYZX2+ODwlFwa/qXHw0pe50u24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787315607; c=relaxed/simple; bh=qWwV76eXl8pi9NZ1itpMyPueAYtNcqe/axydeitklGc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B4bRiMUcexGmMl0Nm9WAdJeRaYkWdZ8A08I0PKJoWHZXN5MZmE01G0aYNHWc5Z4mIS+DuAcU4DBAApGxWTVQAABMaBJXjKJd3MnUfVRpkO76A3pZoBt/gVKoqtPALgglnC4XWhlGcnua4KPVezjvmGvMzbzgT1kStO5r1SMBACs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ivjc4975; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ivjc4975" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cacb8416a1so8875785ad.1 for ; Fri, 21 Aug 2026 05:33:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787315601; x=1787920401; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/AXB9IQGSbDb13imfwWL/kXTtQeUapOU81HM4JBB/5w=; b=ivjc4975SoQw545ulJPyewVPDufA0w9A9lQVJM1aMPAGO5ub1bKTyOjyWlq0CgQ86T 3Tw/YWZdddM00AoeAI9dHQwBaZSx2f01n7PAXWTqG5XkArs9S7MJKlCIwhL44R/VsWNC FhmhDuLCZOEp4sCdIKxdW4nVQaW9DQrjJ9np6HFi6MmF3+Pvf6Mq1DtpS3a9qEINEF3m Kip0bPIhruHUzMohafiJcHNw4RnTiNCdRuw/rcrKCkxGV70pugCUlOGOLdL4d/KsHNs1 +4JYuePWs9WoPG12mwGkPWYpKVfVVgBl6/dr0m7rpuyh9RCE92sveZSmjEn/2jFhCZUS eRSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787315601; x=1787920401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/AXB9IQGSbDb13imfwWL/kXTtQeUapOU81HM4JBB/5w=; b=duk6qJdoqFExrjoFz7jJSj64SGwSWoP2qV09pUiyvLGQiFiJEkDfPbQqvvIqUVnhzZ GxiZVxm1V/rnOq6Rsjl2gRUNq+eGuiOrMKMJOGwONwDPMX+ufASWGYjKSl2NzOmnYmDt Jnk7UVJuDxNkKuKZsw/K9sNxNL7sAAGMrpk57xmtm9ScSKIqaqSOF+jCc/+Jk/YHw7M3 5vgM+oVkQDmUeFgoNJDukse+a+qkg0WGGfZSQmKmOJyImTF8L0CCTN1hz0/kN+xt3+yY xgoP38X7v8c9xOhxJR4dfy6VcFpoK7P0WB+lCjYacKX9sjOQUcCrm/HiPOBb2uBzbGmy 5VMQ== X-Forwarded-Encrypted: i=1; AHgh+RqSM1Xsh/rmPsbini+9RBWtBJr0FYjSAUjqMJzTsORjVGe1SOcIDWOghRNR+jVHF4Ei4VSfmyf3JXE6gFA=@vger.kernel.org X-Gm-Message-State: AFuF++lKo4VKpc4RTVDHmbegD/Dx1H5O6+Q0lVAKMNmKEmysPURQ/t43 /h7+ZSieZIIT4vxKjkiCKStj1BpevjNFoZQnNFQ453IXJf7Nib8kDxV2 X-Gm-Gg: AR+sD126zk4xpEw9Q8oP6fVjOVFE0D9x5gue0rkR26gP1FuVFZ9//TFIt3WlQemeh5v ndMa3xTD7WDIyfZnDH7CI52cNzMpzVbrozk/nbCvucoE/Zkt59tpn5ZHZD15UkBrKJC7v0Ojyj2 Twi4ILKwRMFYqe4XY+BTy/U9zp0IjiWNAtPEAcr0loBPphJRmiiGqVIDIervNQl0IEBa87gSd+6 JuRYUsMkt47+oYwX11KI7khGIinj1YK3AUZFjn+W7JOI3qst2AT14Pa0tMYZ0k8waCFwu2JTQA5 wAeCA22WdqB0RNDfYT5UAlcbo6CFZDLmFCXnH9Jg9+Vdn2j71JP1zHCRj9A6wdrDqUkWe5NLPOZ RIGuz/gpDDYA9aGpYeQmPbgB2YO2c/QY8bm4B/5ss5SmD0wBmJ+7aPrTOgsXNylGsrcLK6Cymoa bqsj/q7xQzANmfKZBxdnJLP58lEv4X7Gz/7hpRW7XBX1FAq72iQBApzvX3HZhpjY03JMpMfbeEH CY54qz7gMjuQkWbw7jA+27cjpfOWUhFfnl2w6NO4iOpzlN8c2UYcD83pOV7qlnf3TqbUGCgmPPU Y9xZ X-Received: by 2002:a17:902:f70e:b0:2cf:afa5:b19a with SMTP id d9443c01a7336-2d64afd7c86mr130049755ad.11.1787315598800; Fri, 21 Aug 2026 05:33:18 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d62e36e1d8sm18402285ad.52.2026.08.21.05.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:33:18 -0700 (PDT) From: phucduc.bui@gmail.com To: Radhey Shyam Pandey , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Simon Horman Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH net v4 3/3] net: xilinx: axienet: Fix IRQ error handling Date: Fri, 21 Aug 2026 19:32:49 +0700 Message-ID: <20260821123249.41527-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260821123249.41527-1-phucduc.bui@gmail.com> References: <20260821123249.41527-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails, while platform_get_irq() returns a negative error code on failure. Handle both cases and preserve the original IRQ lookup errors instead of returning -ENOMEM. Fixes: 28ef9ebdb64c ("net: axienet: make use of axistream-connected attribute optional") Signed-off-by: bui duc phuc --- Changes in v4 : - Add error handling for irq_of_parse_and_map() drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 3927ababf833..68b580191508 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -2971,10 +2971,14 @@ static int axienet_probe(struct platform_device *pdev) dev_err(&pdev->dev, "could not map DMA regs\n"); return PTR_ERR(lp->dma_regs); } - if (lp->rx_irq <= 0 || lp->tx_irq <= 0) { + if (!lp->rx_irq || !lp->tx_irq) { dev_err(&pdev->dev, "could not determine irqs\n"); return -ENOMEM; } + if (lp->rx_irq < 0) + return lp->rx_irq; + if (lp->tx_irq < 0) + return lp->tx_irq; if (lp->eth_irq < 0 && lp->eth_irq != -ENXIO) return lp->eth_irq; -- 2.43.0