From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20AEB474246 for ; Fri, 21 Aug 2026 14:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787321025; cv=none; b=qFAJdY2uoy/jKm0sZBBPqlhpf4YW2Pi6s/EBW/q5D9MpbM25vMbilKG8qeojDviUOdjI6VKOcxUxhtz9i8eidXo1AUlxcgGhsP9iWyGxkQA6AsDb4Niyl/otNKmXgplqWk5aRMCwep961+ZNPFNIgGw4E8JPUZdWslJsYpRn26c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787321025; c=relaxed/simple; bh=eMP6p5hO6wy6cfW8UF05xQCbUzTTpNjzlsI+ATra95M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p1UJwuzt93i00TcsnE1Fv644ewUG1B/G6XTwHm2Zp9gQHgewruvlQVtNW9pUG9K+KqVYtpsWdzbjkXkPAz//QgHn+amXSwlH70SfBZ22eO1mu2YKUTfIhqxmsejtuwRhBBaOjxf7CGnlWwY/h2tDGKKzc2GnDzvvRyUqoCMHLmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=TtFm+Z+e; arc=none smtp.client-ip=209.85.219.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="TtFm+Z+e" Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-90c50c2a257so10994996d6.1 for ; Fri, 21 Aug 2026 07:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1787321023; x=1787925823; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Om6T8MSyTD/SG92U5RChhVeEZVX1cV43aK2KvbHIThQ=; b=TtFm+Z+eGZoYP50Vmx3L6mCf1pSJQyJAAOGjJAEti3T8N2483NXU92HYIuicc7bs9a PqNxIUFSvGsfA8gVmXoAXlsyUSxWFdzMKQl6N6zQehHByi6ngdR1mPVgb/Sor+GNT5x1 WQbqx9yng1imfMPsIjsXcv+IsLobX0ePSaZHNkQIyUhy0fF+vWPZXRPbpGk2jw685r40 ZbmaDXi9KaqBMxPHYKalZtuHGO77IIXexedCsvgRSLqX0QDtKunvRbmxciK0AM5NzBBq 3jp7RaAxFwuEAxv0hrr/O2F3Mkf2NS4HhmdUe8IiQqOlEu2nnUY+F3TSWBu9/iJcBI/y PNFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787321023; x=1787925823; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Om6T8MSyTD/SG92U5RChhVeEZVX1cV43aK2KvbHIThQ=; b=frEnLBYgfBxiEBP1DhjKxZUYMoKsW7zSyFD390KnoOUTrhOysFIdtfEyh1+ELRZ2x+ w0V9wy4kWmtZE3WSs9cQRSeIRXXIeDxv/aJkfeDVy5dKpd/lCeKL0yZicR2xQpT2LKtc P5yx8ZdUjTgbRjD0aIfbRc6YGpeUJVriCMOILYNulodieTsm7nbtRNOKnyAz6lSeOHMN ZEz1aY7lAy3q4Mjx8eaIeVDLj1atamZVQOon0MzrxMxPereAOyKzxoBPWK96wGV5Gp3K T5hJtusedg+om78W2UCSyWIZMjoVbMN5aZYXHDI+h7NDhGNQCj20mvVDz46PEx8JydFV XHXw== X-Forwarded-Encrypted: i=1; AHgh+Rr/K+VHG//CGGfxqwMLj048UCCelnaboJbiM530xAnH+PnE/kk5N2lT8bWpRh9bZFXQYixXzT7xH+E/8ac=@vger.kernel.org X-Gm-Message-State: AOJu0YxpSLPHYzU3ZlOMOkWV3kQf4I/XrxBNuSC5xffb53MlLXKFW+1c 7fRM/pHMKV/NOJRpdFEAzLL3rhVUAVLdrODgPKjGpyOb9f8iuzxt8UYDJWhcpJ8PnwA= X-Gm-Gg: AR+sD12KptRr3fGHLW+ypt0HCRGeKlab50fJKsdWaQqItY+EzdBkXp7GirFHw4Hnsrf +roIrdhVPUE9ptE9L2ukbhnk8ikxhyzCe+Ln/J6kEinGXrDFR+Dq2kixRcrFnxInULhz1yVoAKs 0+pfmex7FhCxAgi5f9SGo28B83lxZHB58zspjnLNV0Vwzp1jkWgFhHieXQ8nY64hyvO4J4hxK7z kkxFYoMbSNIkmiAYNy1ub9TzuiPb6kGt5bWmMNpy52v6KO+mWQcfS6OpJvWEtB0jfhSlU9qrcXA uV+ijyOGfOrd/sFGg3EzAs5skPZBw1C4LsZb87wEG4ghJZS26fgMaX26I0B7lMeAwdmWKQKgHzv a7jsf95b6OI7AEyPmLs9r9b6c9fC4ds4qhe5BnIjoUw3oxH4fVk6S49ojSkyGOP6OE9Ec+ToqCE 51wysK9b+tFIjmXHgS1MxUSf92zQpicYgT2yRbiikibseJc/YDwoTMH6Gp3l00L1/r/5MiiD5Mr CZ603UjBtPN2SeV2WIbvdUp56vLUIih6wVQG03o8nZjnQ== X-Received: by 2002:a05:622a:2305:b0:51c:849b:86b with SMTP id d75a77b69052e-52df5ba9d6fmr58940341cf.43.1787321022876; Fri, 21 Aug 2026 07:03:42 -0700 (PDT) Received: from ziepe.ca (hlfxns010zw-159-2-239-150.pppoe-dynamic.high-speed.ns.bellaliant.net. [159.2.239.150]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52dd87823efsm51424521cf.31.2026.08.21.07.03.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 07:03:42 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wxPqP-00000006349-1gzv; Fri, 21 Aug 2026 11:03:41 -0300 Date: Fri, 21 Aug 2026 11:03:41 -0300 From: Jason Gunthorpe To: fangyu.yu@linux.alibaba.com Cc: tomasz.jeznach@linux.dev, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, baolu.lu@linux.intel.com, jroedel@suse.de, zong.li@sifive.com, andrew.jones@oss.qualcomm.com, anup@brainfault.org, kevin.tian@intel.com, atish.patra@linux.dev, skhawaja@google.com, vasant.hegde@amd.com, guoren@kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [RFC PATCH v3 02/10] iommupt: Add RISC-V dirty tracking PTE ops Message-ID: <20260821140341.GC1114497@ziepe.ca> References: <20260821132749.82070-1-fangyu.yu@linux.alibaba.com> <20260821132749.82070-3-fangyu.yu@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260821132749.82070-3-fangyu.yu@linux.alibaba.com> On Fri, Aug 21, 2026 at 09:27:42PM +0800, fangyu.yu@linux.alibaba.com wrote: > From: Fangyu Yu > > Implement the three dirty-tracking hooks required by the generic page > table framework for the RISC-V format: > > pt_entry_is_write_dirty(): > Check the D bit (bit 7) in the PTE. > > pt_entry_make_write_clean(): > Clear the D bit across the full contiguous range. > > pt_entry_make_write_dirty(): > Atomically set D via try_cmpxchg64() on a single PTE. > > Signed-off-by: Fangyu Yu > --- > drivers/iommu/generic_pt/fmt/riscv.h | 43 ++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/drivers/iommu/generic_pt/fmt/riscv.h b/drivers/iommu/generic_pt/fmt/riscv.h > index 5692c033dbde..09581798e753 100644 > --- a/drivers/iommu/generic_pt/fmt/riscv.h > +++ b/drivers/iommu/generic_pt/fmt/riscv.h > @@ -226,6 +226,49 @@ static inline void riscvpt_attr_from_entry(const struct pt_state *pts, > } > #define pt_attr_from_entry riscvpt_attr_from_entry Does this work for all stages or does it need pt_dirty_supported ? Jason