From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 832E14D2EE0 for ; Fri, 21 Aug 2026 15:06:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787324788; cv=none; b=JBVXQia+ZKLb64jgK/PIQV21+m3jGMeRSveL7d78ZzKQScFPbvElEpaRKwPgsC8O/ua6XE9y2+KNKYTjXB/QPeGA3ej5p85v/nfzZDe2b/pSGxHcHoPItSjFoGcsOSOA+ykj6pNjJRqUmWBB1vgrWvtbw5PvJiJZ1r8vDG4pHdY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787324788; c=relaxed/simple; bh=YCH1yylulf8EbgQrB2WZCIRrwVIgjivx9cOy+yUc6pQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oYgesSuXotK4zlkTvNv/yrPUY1thwVWulJS216Umt63k0dd8kMlFL8BnPZNkkw5tSqE2MHAjOf3uC7mXRe77yLjF9mvMfSMlGAxS97kQnexw9++yyYiB7sWhgGGAVXfRUssfNClaanmu+ts5hFNcHdaq6ugM/MbOd/sUIxxE9ZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Sdybhw0F; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NGZ+2a3U; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Sdybhw0F"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NGZ+2a3U" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67LCoaWQ2029284 for ; Fri, 21 Aug 2026 15:06:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=WqcCf+Dhdx6 Y50GJtvfwTO5MqJahdd7ZlfJbqzun1ro=; b=Sdybhw0FTGysGHJgAe0wLK1rFvT ZYEZNi2NjQ838nO5Ijx2og9/KhbkPqMjewzCeNGEekymYJkBgF7b4F9GBVOsG5WH zuX6dD6xAfxgDrknavd7YEDD3ACVzPMVd48uoi1pyLkNO0A0IBpP6ZGjoaffrV3K TxH/qs0TVzq29gbSkhXM3dbGvPlYr+NTaLupFySY8Taj2Fd/bcybRxd10OSkqC2/ GI/MfhzqDU9EVqxoNorp9JJFCAkolia4m9HTWyNCv+bt0RzFKPnwh2qMcxTcQFIb B6yBxN0xzJA2lQvBmZyX90n21jcgqJMX5PhqWB3W8IilwJrALlUboj0s8NA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g6fue295q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Aug 2026 15:06:25 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9368b4c5964so81000585a.1 for ; Fri, 21 Aug 2026 08:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787324784; x=1787929584; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WqcCf+Dhdx6Y50GJtvfwTO5MqJahdd7ZlfJbqzun1ro=; b=NGZ+2a3UTefLT9aSIFBmaqE78vqj7Te8j7sEVasZEIP1m9ZmN5hKPOwbL5VFgnexjX HG7/zJAHWvSSsNlpRrqOgPrhBcT1oThFDghNRKPtsU2Nf0fiqV4rZ78bvpubk5VREiab P4GbE+UxFmJBugxAd+WzbGKNeib5oS1+O4e+j7I0+J4CnFnWdLAFBwUoKA51AxQWHN4t 238rXRFqCD+KrJtSAc1kmngsm0XA1btHvskAucadeW9/ZB1SzVg5mrVcZy8eZxfg4nKf uMPGwomve1lEqZ24VfzHeFiS6W5Dxr6HifFi0skcaSaO5O2A4/lHaTz8hh0y5HwbsHRu TXhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787324784; x=1787929584; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=WqcCf+Dhdx6Y50GJtvfwTO5MqJahdd7ZlfJbqzun1ro=; b=kYiqYl6NpOQ5eAhjMu7oP3yBmKOfXtm1Ttk7aRUpGybVautS+eP+jBnWKSVt4rSuuZ Y09A9LBpB2qi7Va6SG7fYd2asjf7IwztgMWlpgdjwL/+RSRlx1am4wD7m5lXf5nIyqll 5WVEXWaC1gAanmStPo1ScM4sAfyqKKs0Mg/d0o6xZS8N8y1VpS3QZ32pyhVLp+TaaHwq CxT4ESpE4EoeHRujkgOWCPGclodIWoyGaXxtmsRF+WCmPswXXhj6hCUOSupL3uHzUdb7 tKssg7fvj5e0OIbjOH6QK7cCTtZvZkslhGEVX16mQipf/G4G9IbAMGOhSGEfVBUK62JI /elA== X-Forwarded-Encrypted: i=1; AHgh+RpA08F6uVRt8j5X3aI5lv9G1+N8+FNemKQtsNEIff7uTEhyYL/DTSgvjt5zm8fira1NKAMTuYBIfiV/U3o=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/NmF5/FZciINC4kMaWK3CC5hAz9XIrw4thwHqEQF8BHHpn0eO Z4x661rykin+VmT3Pe43dwEbDkiRloXlyAnGEiVrvNYFNI3oa2Nd4YWp+uneg8OReeJLWhOToZl BjEwb7lYfuosKG4YmOTvDFzaeyP9CS5qNfwvm80DxcFlcoVgE4qOGhQQ22nkKBdpQTo0= X-Gm-Gg: AR+sD11ckJeJ1yyhIqxJ3Jyu8azcOPqmKG9isJOt9XDQe/1eE4rSfIlz3N1HNBtLm9G ews2EyrH31bJaAV7ViEf4lJdsXglWlJMbHkivtC8urQcYQWYNOZGbEQCeGYNqgd3lsWRqBvnS/e r7IsSHYCjDr2n5yW/b6mtMN7/cAHYmj1QcVnx+EHDFXGkAmca7qtfloA5G2BwRQP00GN62pQxMP S31NqXIof0+z+wPVyhJc/Y7lEdhegunjy8TsMFc/ZaH4Ohak+liJqgTZh8AO/DausTUQiTAVPi2 CQcY8IOVSczD2kcZGUhgVeJoj0QMzgABIS/gO96l817b2r7pEjbD5ZdKULTswFtNDSuP+/BcN6Y pfghuqAzRxmaWkQU7sn0icFxWzjJlT56mExJNmonDB59JI90L2zY= X-Received: by 2002:a05:620a:6f02:b0:931:4b6:a9e6 with SMTP id af79cd13be357-937396f3282mr631548185a.47.1787324782869; Fri, 21 Aug 2026 08:06:22 -0700 (PDT) X-Received: by 2002:a05:620a:6f02:b0:931:4b6:a9e6 with SMTP id af79cd13be357-937396f3282mr631521885a.47.1787324781737; Fri, 21 Aug 2026 08:06:21 -0700 (PDT) Received: from trex (137.red-79-144-199.dynamicip.rima-tde.net. [79.144.199.137]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b14b8050sm17960936f8f.19.2026.08.21.08.06.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 08:06:20 -0700 (PDT) From: Jorge Ramirez-Ortiz To: jorge.ramirez@oss.qualcomm.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org, beanhuo@micron.com, beanhuo@iokpp.de, can.guo@oss.qualcomm.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org, jenswi@kernel.org, sumit.garg@oss.qualcomm.com Subject: [PATCH v3 1/2] ufs: rpmb: retry power-on UNIT ATTENTION on the RPMB WLUN Date: Fri, 21 Aug 2026 17:06:07 +0200 Message-ID: <20260821150612.3944782-2-jorge.ramirez@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260821150612.3944782-1-jorge.ramirez@oss.qualcomm.com> References: <20260821150612.3944782-1-jorge.ramirez@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODIxMDExNyBTYWx0ZWRfX6rCfQGbTzd8t QCN7Ah/lfEAHCYjdLzlyXcQcHBUQzMlZG+6sBlgw1gV8a5vhmtA2aGIrvqUJOwdynocZDFy1RjD XBY54lNMttMb9g6OpLbexQ6a6E6vqu0= X-Authority-Analysis: v=2.4 cv=U9+iy+ru c=1 sm=1 tr=0 ts=6a886971 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=qBhfTSQT0jQfJ5OHMlDVQg==:17 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=w0io_FmA1e-6CLxyNa8A:9 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: PehfG3FvobBbX_Y89TA0lOF70xPHSxUs X-Proofpoint-ORIG-GUID: PehfG3FvobBbX_Y89TA0lOF70xPHSxUs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIxMDExNyBTYWx0ZWRfXwDfTkjgUCkEd pXylauGxkYftbUnYuVys6i0xxCcw/v/eBqvz03xwJyh6Mc6tmuoPyFEZdWU5U+NPCXY6Vn5AK/T SP2OdrsSzqM1ssp5bKpqsZSDkPFyjvDlaSI8rXJY7MEk0NE1U1dBFG62rU4XySjjwICEUvw+1u4 8i0KmaiE/oXxIGjzEdS19GZme7JKa7PBy+jaExnw9/1XlR5k4nI39IRwd5GnkdaZnSGJVgkt1X0 y0OT+qv8+b+SsWv53wr4x0AKvxrDLI9rXjUVvXA1EhP8qCPbf7cTgHimZnwQxilAilnApHIvoD4 V+DjHP4dOIHN5emo3axJuhBf2uWSwwN20HZmvu/95tvkYvi2L0OYUInQXDvedV9sdRXInOkm2Yd EyA1fZkKcDo8/O126Ke26hc4BwQ5HrO49gApFqDIKU9WHoZjXgU/dJkCAkVYUlH+Og5HJFybLLC fjWyXvmNw2oiXeLTw4w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-21_04,2026-08-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608210117 After a power cycle, the first command sent to a UFS logical unit completes with CHECK CONDITION and a power-on UNIT ATTENTION (ASC 0x29). The SCSI core reports this to the caller instead of retrying it. For the RPMB well-known LU, that first command is the first RPMB frame sent after boot, so the frame fails. RPMB has no earlier, guaranteed access that could clear the condition beforehand, so this breaks RPMB on every cold boot. Ask the SCSI core to retry the power-on UNIT ATTENTION on the RPMB WLUN so that RPMB works from the very first access after a power cycle. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/ufs/core/ufs-rpmb.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufs-rpmb.c b/drivers/ufs/core/ufs-rpmb.c index ffad049872b9..d0c7ea7a36f4 100644 --- a/drivers/ufs/core/ufs-rpmb.c +++ b/drivers/ufs/core/ufs-rpmb.c @@ -40,6 +40,23 @@ struct ufs_rpmb_dev { static int ufs_sec_submit(struct ufs_hba *hba, u16 spsp, void *buffer, size_t len, bool send) { struct scsi_device *sdev = hba->ufs_rpmb_wlun; + /* Retry the power-on UNIT ATTENTION (ASC 0x29); the SCSI core does not. */ + struct scsi_failure failure_defs[] = { + { + .sense = UNIT_ATTENTION, + .asc = 0x29, + .ascq = SCMD_FAILURE_ASCQ_ANY, + .allowed = 3, + .result = SAM_STAT_CHECK_CONDITION, + }, + {} + }; + struct scsi_failures failures = { + .failure_definitions = failure_defs, + }; + const struct scsi_exec_args exec_args = { + .failures = &failures, + }; u8 cdb[12] = { }; cdb[0] = send ? SECURITY_PROTOCOL_OUT : SECURITY_PROTOCOL_IN; @@ -48,7 +65,8 @@ static int ufs_sec_submit(struct ufs_hba *hba, u16 spsp, void *buffer, size_t le put_unaligned_be32(len, &cdb[6]); return scsi_execute_cmd(sdev, cdb, send ? REQ_OP_DRV_OUT : REQ_OP_DRV_IN, - buffer, len, /*timeout=*/30 * HZ, 0, NULL); + buffer, len, /*timeout=*/30 * HZ, /*retries=*/0, + &exec_args); } /* UFS RPMB route frames implementation */ -- 2.54.0