From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52C283AFD17 for ; Fri, 21 Aug 2026 21:47:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787348862; cv=none; b=hAM+Q00FoENr8+XTImIyDIlSlcWFnS9rNcN6qPUjn5+z5wJPdf38BLeylVZSID1t7wGXVVxabRUl6aC8E698utiamfQAaT5lqijfhexdntddEw21Zp5cB7gy9yxGDjHtl62vMn83ullMKsojqhUSuP5VyyONyo+XDhe69H702Nc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787348862; c=relaxed/simple; bh=F4LO7wmBLLIwQF+4rvvhzn4HaS/bCVrX06hJixd63Xg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MIqgCzd3BkhpfiE4ui+7XY9UsvaAqF9alu5ldXSBtOjC+prdPCOA8lQfrdqgmYexJK6gP62E1suPoIq8Dd4U4xYDCRNFQJ+hzycECayRSC97duYxhfoBt07stFT7WlvD0wK/KTskyAxokAAE8pYTyYh/IwBJebCCxoq+7RFtFtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IZU23ykz; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IZU23ykz" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-848761b5897so623558b3a.3 for ; Fri, 21 Aug 2026 14:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787348861; x=1787953661; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fkDDTrK1TveWR5ufs0Rnfw82A2Z1a3+coe/mtCRQsac=; b=IZU23ykzsGxzVPT+PBOlLNvMBm8ESNMYGLYt4Qp5pm0BWNPnaivAjQGXZd2CL9ZEFW 8z8uwfP7EjM1p/zVRgSClgQul3bTdFTxKvZETKXnMLWcY0jBKNEQmHp3ZuSnwiTsml6d ZXJ9QRoyGG4Pb+LPb3QnBC9QPZQBMG1nfKHLICOfaLP1z2lnj3kaQxYW9vwk9FxxCtzM SdtLK3vHMeeWUbgPdJ2UsMtzZl0iYkLMBxerxsJu37wU6py1+5FgtaL5NAGcwzwGphAA PJY68alBVfNIcnftIiaYfdNEvd5EF3hytbZFjOSP7yGZNvOwoLZ6GrtOYuKHsZwIastM zWEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787348861; x=1787953661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fkDDTrK1TveWR5ufs0Rnfw82A2Z1a3+coe/mtCRQsac=; b=QPQ4wyIAskEXBw9i5ErHSgCzX6yHvbkyBALMEdu0jH4bdj1YbNyXVmVrgBRWG/t461 sGgLFo1TbetHHwU8wD/NOWQdsT03xlBiNjugHVxtUD4KKdiM0ClQgVLV+BpZ61+gMymD HkkPJrA1FxQcPmd7ExUVFyXisWwLJustJ1leLXNAyR5qIsdHVJZHEiv9q+LKSv0XDxzH CrdideegfnGOAzIdv+/UGksE3tVhKBs7G4P33qYJ2zLtc/VyNgnivVgL27lsgo+b3UAE kJllftM88QO7L/une8rYz0+r0Reaw2QmrBbTP3BdLwBfA0fJjHSglguEwH3glASySBO4 gtkA== X-Forwarded-Encrypted: i=1; AHgh+Rr1rOC7sQyqYeV6L0kR93vddqnFiSyB9TmQEGaA2zR2HlSGtL89qjK8VvYRIxoW9QDgPKuyvhhc4RvRDTg=@vger.kernel.org X-Gm-Message-State: AFuF++kaBG4782FVMXl5j7GTH/Tz89EYY5ab9SBZWgZdsXUZv+WOseng I++Miah5PxeM6u3TNcx6X7jQZUCUiriaB06+W7O9QMtgIpagLTbZvU5t X-Gm-Gg: AR+sD115HtkYmQhrwl3e9DinDi1ndQ4a5XQmsQ6iDTzPXfIabYzRd041paji6r7vvYl 7MSRFcZ3UIbqqBxypCx06uMTlumG0hTlc/sgbrAhI7BvpAYEHSqEv/POs1ffbZ0e5XwWHHMcKLH MMlT4ykSoEvqcWqpOJtn2XXAEF/B5Z8yxy1RuxuolRB3XRaJznEkon7TtoGgVEWQcGDfAdGZ/Ak 335BK3CaN/mWnrIop0h1nBlWheig+zCit+T5uYoS1FBRglGnyGa4XEf2BtxLTDF99iZQ6lsik9Q wryhMDhQeQtEywHPo1qgNczKeMYTwf46YjbBoWR0cNsgYZ18beO9+tj7+6XlLGmOpFKebknvzSM PCWz1OcYwVOQR1iLqRNTMPlLFZBqpQnnNeDtBCx6yljS2DEEok5jG2UWb+6WVDThqZuS+lOnxAx uqmJ+MktJbTUjwVHjFU47inB1fWXWNO0bf5BJ90YtABiLvPNo3Mqm56B7xFmYEcizqYa7fT4kQm 3uPMOcuItbityHHLHg= X-Received: by 2002:a05:6a20:684a:b0:3cd:1037:36d6 with SMTP id adf61e73a8af0-3cd2fa5643bmr19087616637.0.1787348860697; Fri, 21 Aug 2026 14:47:40 -0700 (PDT) Received: from localhost.localdomain ([103.16.69.193]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327bf10d497sm45664198eec.14.2026.08.21.14.47.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Aug 2026 14:47:39 -0700 (PDT) From: Aditya Dash To: "Derek J. Clark" , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Armin Wolf , Hans de Goede , Mark Pearson Cc: Guenter Roeck , Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [RFC PATCH 1/3] platform/x86: lenovo-wmi-other: Add Legion Go Full Speed control Date: Sat, 22 Aug 2026 03:17:25 +0530 Message-ID: <20260821214728.87773-2-mradityadash@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260821214728.87773-1-mradityadash@gmail.com> References: <20260821214728.87773-1-mradityadash@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Selected Legion Go firmware exposes Full Speed as Other Mode feature 0x04020000. Capability Data does not describe this feature, so lenovo-wmi-other currently ignores it. Probe the feature during HWMON setup on those products. If the read succeeds and returns a Boolean value, expose it as pwm1_enable. Value 0 selects Full Speed, and value 2 returns fan control to firmware automatic mode. Reject all other values. Assisted-by: Pi:gpt-5.6-sol Signed-off-by: Aditya Dash --- .../wmi/devices/lenovo-wmi-other.rst | 7 ++ drivers/platform/x86/lenovo/wmi-other.c | 108 +++++++++++++++++- 2 files changed, 114 insertions(+), 1 deletion(-) diff --git a/Documentation/wmi/devices/lenovo-wmi-other.rst b/Documentation/wmi/devices/lenovo-wmi-other.rst index 011054d64eac..75f2deaaef16 100644 --- a/Documentation/wmi/devices/lenovo-wmi-other.rst +++ b/Documentation/wmi/devices/lenovo-wmi-other.rst @@ -49,6 +49,13 @@ The following HWMON attributes are implemented: Due to the internal RPM divisor, the current/target RPMs are rounded down to its nearest multiple. The divisor itself is not necessary to be a power of two. +Legion Go fan controls +---------------------- + +On supported Legion Go models, Other Mode feature ``0x04020000`` controls +Full Speed mode in firmware. The driver exposes it as ``pwm1_enable``. Value 0 +enables Full Speed, and value 2 returns fan control to firmware. + LENOVO_CAPABILITY_DATA_01 ------------------------- diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86/lenovo/wmi-other.c index fbb32bf404f2..c180933e1d18 100644 --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -32,6 +32,7 @@ #include #include #include +#include #include #include #include @@ -83,6 +84,7 @@ enum lwmi_feature_id_psu { LWMI_FEATURE_ID_PSU_CHARGE_BEHAVIOUR = 0x02, }; +#define LWMI_FEATURE_ID_FAN_FULLSPEED 0x02 #define LWMI_FEATURE_ID_FAN_RPM 0x03 #define LWMI_TYPE_ID_CROSSLOAD 0x01 @@ -102,6 +104,10 @@ enum lwmi_feature_id_psu { #define LWMI_CHARGE_TYPE_STANDARD 0x00 #define LWMI_CHARGE_TYPE_LONGLIFE 0x01 +#define LWMI_ATTR_ID_FAN_FULLSPEED \ + lwmi_attr_id(LWMI_DEVICE_ID_FAN, LWMI_FEATURE_ID_FAN_FULLSPEED, \ + LWMI_GZ_THERMAL_MODE_NONE, LWMI_TYPE_ID_NONE) + #define LWMI_ATTR_ID_FAN_RPM(x) \ lwmi_attr_id(LWMI_DEVICE_ID_FAN, LWMI_FEATURE_ID_FAN_RPM, \ LWMI_GZ_THERMAL_MODE_NONE, LWMI_FAN_ID(x)) @@ -115,6 +121,50 @@ enum lwmi_feature_id_psu { static DEFINE_IDA(lwmi_om_ida); +static const struct dmi_system_id lwmi_fan_dmi_table[] = { + { + .ident = "Lenovo Legion Go 8APU1", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Legion Go 8APU1"), + }, + }, + { + .ident = "Lenovo Legion Go S 8APU1", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Legion Go S 8APU1"), + }, + }, + { + .ident = "Lenovo Legion Go S 8ARP1", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Legion Go S 8ARP1"), + }, + }, + { + .ident = "Lenovo Legion Go 8ASP2", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Legion Go 8ASP2"), + }, + }, + { + .ident = "Lenovo Legion Go 8AHP2", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Legion Go 8AHP2"), + }, + }, + {} +}; + +static bool lwmi_fan_supported(void) +{ + return dmi_check_system(lwmi_fan_dmi_table); +} + enum attribute_property { DEFAULT_VAL, MAX_VAL, @@ -144,6 +194,7 @@ struct lwmi_om_priv { int ida_id; struct lwmi_fan_info fan_info[LWMI_FAN_NR]; + bool fullspeed_supported; struct { bool capdata00_collected : 1; @@ -237,6 +288,38 @@ static int lwmi_om_fan_get_set(struct lwmi_om_priv *priv, int channel, u32 *val, return (retval == 0 || retval == 1) ? 0 : -EIO; } +static int lwmi_om_fullspeed_get(struct lwmi_om_priv *priv, long *enable) +{ + struct wmi_method_args_32 args = { + .arg0 = LWMI_ATTR_ID_FAN_FULLSPEED, + }; + u32 value; + int ret; + + ret = lwmi_dev_evaluate_int(priv->wdev, 0, LWMI_FEATURE_VALUE_GET, + (u8 *)&args, sizeof(args), &value); + if (ret) + return ret; + + if (value > 1) + return -ERANGE; + + *enable = value ? 0 : 2; + return 0; +} + +static int lwmi_om_fullspeed_set(struct lwmi_om_priv *priv, bool fullspeed) +{ + struct wmi_method_args_32 args = { + .arg0 = LWMI_ATTR_ID_FAN_FULLSPEED, + .arg1 = fullspeed, + }; + + /* The WMI method has no return value. */ + return lwmi_dev_evaluate_int(priv->wdev, 0, LWMI_FEATURE_VALUE_SET, + (u8 *)&args, sizeof(args), NULL); +} + /** * lwmi_om_hwmon_is_visible() - Determine visibility of HWMON attributes * @drvdata: Driver private data @@ -255,6 +338,10 @@ static umode_t lwmi_om_hwmon_is_visible(const void *drvdata, enum hwmon_sensor_t struct lwmi_om_priv *priv = (struct lwmi_om_priv *)drvdata; bool visible = false; + if (type == hwmon_pwm && priv->fullspeed_supported && channel == 0 && + attr == hwmon_pwm_enable) + return 0644; + if (type == hwmon_fan) { if (!(priv->fan_info[channel].supported & LWMI_SUPP_VALID)) return 0; @@ -311,6 +398,9 @@ static int lwmi_om_hwmon_read(struct device *dev, enum hwmon_sensor_types type, u32 retval = 0; int err; + if (type == hwmon_pwm && attr == hwmon_pwm_enable && channel == 0) + return lwmi_om_fullspeed_get(priv, val); + if (type == hwmon_fan) { switch (attr) { /* @@ -366,6 +456,17 @@ static int lwmi_om_hwmon_write(struct device *dev, enum hwmon_sensor_types type, u32 raw, min_rpm, max_rpm; int err; + if (type == hwmon_pwm && attr == hwmon_pwm_enable && channel == 0) { + switch (val) { + case 0: + return lwmi_om_fullspeed_set(priv, true); + case 2: + return lwmi_om_fullspeed_set(priv, false); + default: + return -EINVAL; + } + } + if (type == hwmon_fan) { switch (attr) { case hwmon_fan_target: @@ -420,6 +521,7 @@ static const struct hwmon_channel_info * const lwmi_om_hwmon_info[] = { HWMON_F_MIN | HWMON_F_MAX, HWMON_F_INPUT | HWMON_F_TARGET | HWMON_F_DIV | HWMON_F_MIN | HWMON_F_MAX), + HWMON_CHANNEL_INFO(pwm, HWMON_PWM_ENABLE), NULL }; @@ -440,6 +542,7 @@ static const struct hwmon_chip_info lwmi_om_hwmon_chip_info = { */ static void lwmi_om_hwmon_add(struct lwmi_om_priv *priv) { + long enable; int i, valid; if (WARN_ON(priv->hwmon_dev)) @@ -458,6 +561,9 @@ static void lwmi_om_hwmon_add(struct lwmi_om_priv *priv) if (relax_fan_constraint) dev_warn(&priv->wdev->dev, "fan RPM constraint relaxed. Use with caution\n"); + priv->fullspeed_supported = + lwmi_fan_supported() && !lwmi_om_fullspeed_get(priv, &enable); + valid = 0; for (i = 0; i < LWMI_FAN_NR; i++) { if (!(priv->fan_info[i].supported & LWMI_SUPP_VALID)) @@ -474,7 +580,7 @@ static void lwmi_om_hwmon_add(struct lwmi_om_priv *priv) } } - if (valid == 0) { + if (valid == 0 && !priv->fullspeed_supported) { dev_warn(&priv->wdev->dev, "fan reporting/tuning is unsupported on this device\n"); return; -- 2.55.0