From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B600419EED3 for ; Sat, 22 Aug 2026 01:42:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787362941; cv=none; b=uix1MRQiM1RgN7KQMSDEbjGh5glbJ36fe1IfTRG08J7z/MUeuc1XDf2SGbMePwo8Ucbi1TwW76R3PNtYPTT0dfa3al0EvvamcUKuACpD9zldR5UIH3CRus2pcXga+YkxQyal/1HHuWnDzcdQJBCaGX6veKjHM3XgL80jwEKyvCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787362941; c=relaxed/simple; bh=BTDvqqutSAcl9UkR/9EY9Le0eJofABQMeRnd0Wyatz8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rW1cLIopbrG+DW4YVtST7MFuqEn1MdTE/vl2M0bqx8KSoN5yLY49FBSxqM4o7JUNGWM+hsFDWy23W+VwIcc2r7/Q/AHdwqAUlmk5GHeFPUjwgbqvrSIw4LYyhhemigc6WtRfdlp5tlk++Y6noGP99CTg8ECPg0VU0pQzY4dS1ag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PZ2SNyfB; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PZ2SNyfB" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-cc147d86bebso1400429a12.0 for ; Fri, 21 Aug 2026 18:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787362940; x=1787967740; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bjDQfpDGN2dUsxDWsVsp0pCHr6hky9fJx/+FB+sD/H4=; b=PZ2SNyfBOnOae++1IkBVhs47hC11010H+otLK8DMMveTdGS1bNBpkVC6OM8RInHaRu buPkRIeh4ST3sjT+YcrDPxF+Yy0X8EIGo8vXdJNPJ3gDIEOzY82IgPexo/oZqYfLyIgX 6VHVk9MwMmzfTknkRtR2Pg8U2pJSED0YPFkeUEJ3OKZPpJwlFBD9iD9kEmW1VxezD1dA SJiDoksKvdyHHo2beMk9dNCQD44x2CId+Tcfou2xOLO8ThIpF1idfn3/yqKXaMqi3bYD +0AAFZ16UMeIbLw8b3Xpv9W8ec2Q6ZtEM3x5ItkTmhVsvf9ohwEez0R0rbl/VpbIJ9/N N/Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787362940; x=1787967740; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=bjDQfpDGN2dUsxDWsVsp0pCHr6hky9fJx/+FB+sD/H4=; b=mb3BIvDTuQ0TR3LiTnDeOhJQm4ezRCP699qPBthnhBptM5+ZlaAZ0X5bt6iRCZK7AE rkSUoWzZrIe/wIoi5tqIic2JR3aJr7owSgUj2tqbu3tOwUXX8xqGAEZjLFnYyhZH2ase s2Bm27HawtIX+Aau+zvzbXjkfajS8db/IGJpzqPbSbG4yVe1v27PLqoThGMv33Sy0/3H IamvtUi/8mc7tzD06P+490aarBXjGdtirDrQ47zwJRYBaWB2vnAfMO3u8F64DmJRYFZX nETXmnwxI2hAylC9SODHCDVLkkzAJVD6CVCmhAa4epQMAJVVCkDgHPOpdQdfubFYdsA6 lKLw== X-Forwarded-Encrypted: i=1; AHgh+Rolbc2vkNsNRj7ziSUjW1iliqCUlAjU1E83HeWhni1AdtB2c5FotiiOAYjF87kPNX2xSIjqRG8SSSa2TMY=@vger.kernel.org X-Gm-Message-State: AFuF++lrgnKcxptSQpx+6xumpemA1XDqp9GbJ/kfOwmpFEL8BYPZGmgl jMfPZwrTC6KoRvPZA6vksomlMnREsaIFFM54SVqZyhCANfr3M1q/hJi6 X-Gm-Gg: AR+sD12RzsqbHRh3zyuASc1HHWNzMnkZFdChf5qH+BaKq9ZLjwC7y1ehc2D6ML1KP4C fyUa4NIk9+YQE3gxul9fAQ7vG0yXcu+1r6uXtDb6n1a/XNhXgAj0gcT288eEZlq18OiX/tqBIRR mFDxubKw/gACI9IrbRQfQjKwOFhCMsJLwVn7gNAFcyXqgpWQuftNyVGNLKYwq4HzgCuMkyY7g0g g8xK6jXB2UP1Y+N8d2sO4TrWus2Wu8U8Di22G66Rzl6yTWeyedvCC4dli1O2PIxJmKfGeehtcvS KXLn8qJbRvUK/Vrel74SmEGl/7QcTrOn4IQFS4PY3zERxFgg3Oq6Qu58FXcu1KvL3PVfe5LKUFh baOITHG9tpxYHvu7RBA5A8IbtQrClukdH5PyBZ2tNvpk1Go2PvaA/ojRDs4BO75OwXIoJmTTqQX zPh99H69pkmC/8iqZs7Qjsz7H/kA5bIJzioYVMc2uTV98/otEx8S2O06BvYc+RW64/j9eQlR5LT DNvyEj4Mz63e18Thm5nQeJcJA== X-Received: by 2002:a17:90b:37c5:b0:38e:6d55:b1a6 with SMTP id 98e67ed59e1d1-395c4c35ac3mr9445067a91.3.1787362939908; Fri, 21 Aug 2026 18:42:19 -0700 (PDT) Received: from localhost.localdomain ([240e:b8f:91ce:4100:89b0:4297:d4e0:bdb6]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395c8fae7b4sm1500926a91.1.2026.08.21.18.42.15 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 21 Aug 2026 18:42:19 -0700 (PDT) From: "Lian Wang (ProcessMission)" To: "Barry Song (Xiaomi)" Cc: Lian Wang , akpm@linux-foundation.org, linux-mm@kvack.org, axelrasmussen@google.com, baolin.wang@linux.alibaba.com, baoquan.he@linux.dev, chenridong@xiaomi.com, david@kernel.org, hannes@cmpxchg.org, kasong@tencent.com, linux-kernel@vger.kernel.org, ljs@kernel.org, lyugaofei@xiaomi.com, mhocko@kernel.org, qi.zheng@linux.dev, shakeel.butt@linux.dev, stevensd@chromium.org, wangzicheng@honor.com, weixugc@google.com, yuanchu@google.com, zhangbo56@xiaomi.com Subject: Re: [PATCH 1/6] mm/mglru: batch update lrugen->nr_pages in inc_min_seq() Date: Sat, 22 Aug 2026 09:42:01 +0800 Message-ID: <20260822014208.36934-1-lianux.mm@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260821102538.22642-2-baohua@kernel.org> References: <20260821102538.22642-1-baohua@kernel.org> <20260821102538.22642-2-baohua@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Lian Wang Hi Barry, A small nit: > + unsigned long delta = 0; lrugen->nr_pages is a signed long and is documented as being able to transiently go negative while reset_batch_size() is pending. Could delta remain a long as well, so this arithmetic stays signed? In 2/6, where the declarations are combined, this could be: unsigned long protected[MAX_NR_TIERS] = {}; long delta = 0; Thanks, Lian