From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ED9B38BF62 for ; Sat, 22 Aug 2026 08:59:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787389151; cv=none; b=BAZpLubUkizb9a+0vbezCPjPlcAEdtDHHz25twuKFZ3HuiC3qv1bwyOMU4irqRekK7JDttjfRUtvpmCGVYppeYK9Q21bgSTvsiKeg+dRYlwa7eWmC0dMwqZ0NY/dNO1K+UcvJEVCHny3N4u7x5qTc+qSehX8mCCSG5M/kjPyijQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787389151; c=relaxed/simple; bh=qh4p6NiaYYKZWRo5SdC+29bJh1njzkmd5IdAQaiKg10=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V1SLlseM/SwDuXf1qWjV+A2Fy9IjKUmUqIhCAOOyMZ+aWjKhPOd2/KEU2hraLaKF19E3VWPeYoX/5mewj1PWpEaXSinJBKr2HGVJNuDgf3U2G6ylsmO7YeZ7kuAEYgqmtgFjWvw3bzVIN3Z9bWjnjbC0W9aHiMKqhOaiXceHKIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TcVXS5Ig; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TcVXS5Ig" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4998590d392so2184455e9.0 for ; Sat, 22 Aug 2026 01:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787389147; x=1787993947; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XsQREIODkCao/QDK0V814PCMzSICvR9cgatjnm3y9Ns=; b=TcVXS5Ig7krocPfP/9ao4ZyODVURPMyq6mDn0ZuHJdZ1Eoat34MD0jlK341uOkA9j4 HDi9fuGMlZPXG4xNXrBOD9bXLfJ8LsAVM3OpOZ7JFIKWSkNPlbHKr4cjzdN+QmhNXVWD F5znCQZXZ798dW19vshgt9Hyf0gBSfGYB7VWGvjSza+7wdCKlOsRY4izrsK4fAifEEp1 yjR5MIP6LdRNKcRAMcOwL8DRLn2uSliN4T7OCw3cSoJWtJZdjdAJlfajclsFdlFqqxuj CCawAFI2JFFSwmjoYis/FUT7vT1oBDvM3hBZC0AnE8Tws1vUp0C9VF9eeOp9BF7zdz9k ZObw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787389147; x=1787993947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XsQREIODkCao/QDK0V814PCMzSICvR9cgatjnm3y9Ns=; b=HozgpaJHU7dWis/kO6bTrYEMwazhr68TeNjVCf2RurVJikiNWSIgfuosrtmznwHPde fXAL0WOG6KSXFvOiTARUv2XjStNgenvtGhzYJaXiI/Oa//VS3aHEUuc05cLBY99TFQwV xft+Yk73JBco9mWBapUo0xosOi60O0EeCENQQp1txD2piR5SweSuhJwbWycX6Et8ZJF1 NLNutOZ/o/f5OQLvhAybCpnNlbWaPVvlQQVEFfg6ycWR4oWbJImdkj6zav3mECqFErO2 sdeAA9Na+YrCiPU00IwrIkn1nUmVgxHwg+OtMF3kRuzsmCrJY1J3B+Tnvi+EsMyZyo3d DWLQ== X-Forwarded-Encrypted: i=1; AHgh+RoNMxECisZjF0vqa4KDzyS33ZhOueIFXaBw+MGdEHIWicvsK2D8Q9L0WDF/zp2MxucN05EYea1WeHNvy/A=@vger.kernel.org X-Gm-Message-State: AFuF++nkCvIp7LvupfzmbKMW2BnIIF1paoQxwkwbBT6D36EMhurqdlXY ogbfld+CggvI+NqN+SU3x37+Y7n1kv55yVPLLL/uVwCiy2ZDzDrb0DKV X-Gm-Gg: AR+sD11FfZtu+vSgSVBFNTsEYrFqsiqmU8kgcxqkZ02ppw3AMdZuVxP/29+Ib4H+Xwe cXVZLrAAO7CRnfstJlx8XL3zmlsv9RAooH3qvmmjMC/kv/W+imC+cik0IF1SoT4cwEm4r8zU3Xd gGCoL3VmAxUdM6KcM+kd886q2TQz/GLKS6i8qjWbhx6KHxouxz7wtlTopovZIIovrexUSnDryT2 s+OlcrsTWzlJ+U8BS73l6ESWib/8863HjrL0MXeTJtDzmBAr115yFAFT8rQbkW7+vfT0Zkt0pjM O6OTF/6Eqt1mpZKmBzd5bND78h2O4+L7AM1HCLc0FOHmT87tfvBLA+Jv82ZEXVvBBj1h8yAabqE gHCRz4w4FikHzXVPbs5+JnwtrNPAl4v9KqyAYiQedO+GryICr4I0FOfMeLsAg/0341xz5wPFdPd hHAd1T0Lil4kKeaV6uQGg3SbYrC7JJ0ZlXil5VFppHWnvK3M4Qe5zLp8H0JUlJbwt0/17gFL8zr Z9IGRiK/P4= X-Received: by 2002:a05:600c:b86:b0:499:8156:cd3f with SMTP id 5b1f17b1804b1-499b8301913mr118647255e9.8.1787389147451; Sat, 22 Aug 2026 01:59:07 -0700 (PDT) Received: from fedora ([105.74.72.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499c359b9fcsm13596635e9.9.2026.08.22.01.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2026 01:59:06 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: jic23@kernel.org, lars@metafoo.de Cc: Michael.Hennerich@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v6 3/6] iio: dac: ad5504: separate ACPI and DT paths Date: Sat, 22 Aug 2026 04:56:50 -0400 Message-ID: <20260822085850.17527-4-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260822085850.17527-1-0rayn.dev@gmail.com> References: <20260822085850.17527-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver relied on a fragile -ENODEV check from the regulator framework to bypass voltage configuration on ACPI platforms, sharing the same fallback path as legacy pdata. Fork probe on is_acpi_device_node() to explicitly handle each path. On ACPI, skip the regulator and use a fixed 60V default via AD5504_VREF_ACPI_DEFAULT_mV. The pdata fallback remains for non-ACPI systems in this commit; it is removed in the next. Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 5c9c66b04154..6f70c57c7a82 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -5,6 +5,7 @@ * Copyright 2011 Analog Devices Inc. */ +#include #include #include #include @@ -12,10 +13,12 @@ #include #include #include +#include #include #include #include #include +#include #include #include @@ -24,6 +27,10 @@ #include +/* + * In case of ACPI, we use the 60 V as default voltage reference. + */ +#define AD5504_VREF_ACPI_DEFAULT_mV (60 * MILLI) #define AD5504_RES_MASK GENMASK(11, 0) #define AD5504_CMD_READ BIT(15) #define AD5504_CMD_WRITE 0 @@ -285,16 +292,20 @@ static int ad5504_probe(struct spi_device *spi) st = iio_priv(indio_dev); - ret = devm_regulator_get_enable_read_voltage(dev, "vcc"); - if (ret < 0 && ret != -ENODEV) - return ret; - if (ret == -ENODEV) { - if (pdata->vref_mv) - st->vref_mv = pdata->vref_mv; - else - dev_warn(dev, "reference voltage unspecified\n"); + if (is_acpi_device_node(dev_fwnode(dev))) { + st->vref_mv = AD5504_VREF_ACPI_DEFAULT_mV; } else { - st->vref_mv = ret / 1000; + ret = devm_regulator_get_enable_read_voltage(dev, "vcc"); + if (ret < 0 && ret != -ENODEV) + return ret; + if (ret == -ENODEV) { + if (pdata->vref_mv) + st->vref_mv = pdata->vref_mv; + else + dev_warn(dev, "reference voltage unspecified\n"); + } else { + st->vref_mv = ret / 1000; + } } st->spi = spi; -- 2.55.0