From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 045FD3403EA for ; Sat, 22 Aug 2026 09:47:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787392057; cv=none; b=SZzyu91Mfuebd6zNikx1l+BP/WLtdido43YLyTTbOOorvrUn18rn7RenaWcoXU/LYHDinIlBg7vHykMZKj4hsUb95l6Im5l62CymIJOEpjcI/qR49WcI5ZX8ykUde5AMafxj8J67qDcYwWVZY10rU9FntCQucoH30v/qCCgHCt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787392057; c=relaxed/simple; bh=D9OoENn65w9qMw3OOf6QdpdEmetlxpwv0r8psuzKfro=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=n1ais9lPhZ0CVp/Q/GKLjlJK85VxqfVENeOAm35984LIGIsCBFrb+EcxDvfMV6FsQkm6Lu1/MS6SRjvu2jFzovjjEsC4UUOKtfal7tX8/kBZTylUseRy+lvT+u44fNxPCgJQr5EBt0iNoyGcOXhWWPzrBZ0lNSE208oRPCOezY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UgmIiFv6; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UgmIiFv6" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-848761b5897so733580b3a.3 for ; Sat, 22 Aug 2026 02:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787392055; x=1787996855; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=90ARkRfsM0lZyMNJJUYej5kYseMm7HH5Ptx/Uv/OKT4=; b=UgmIiFv6Lb36MZjytwEkTQGjm/dd0JYZwxM5KG7XZoO8a/rxDaUMDPXrSrkrlLy0yy nU5ceFLCVP+837uYCRo4XEy+u4uQJ8s9NJlH8cVesh0TGjb5JZTWvxOVigXgQ2pg5kvG F2tAVEmjpd2djVFAnk1wGCb1DFq7MRFOAwueAp8HXVOdZhwHOOIxAzmmxDlXBforlIds EkcdxblB9Ki8qCRMSpQEnjZhE8NLgAoH2+juE1QsLa98xjXvwXmfTGJNcweJjEMNTCkz U+xwNjeacrocG6bv32SBUE/6fBh0+NLrRU18VmwBPbMiXxksq+ggXFTvTbkqAvUdqEDY kLGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787392055; x=1787996855; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=90ARkRfsM0lZyMNJJUYej5kYseMm7HH5Ptx/Uv/OKT4=; b=Y51Dru1Tc4lLJKj7D5Nir3HhB3HeGP6P2K1Pb6hou42c2Lb0Ywk4y6Lc4gc40cUi0Q wPm0476UQKUlip+X7zQkIGFq/0t4uSMVopGt0xLT8/AqsbdogkgfUqFirkxISkxrVW6R DjE5nlAuHqP+UXEzQ0JLYFARZtFsuTQlXgnbjQ/E9lYZmLsi060wyx6FT3OpBBtHsLUR 6a4k0a2VBw6c8NSx4/b+yuMLUbalfm1D4IwVWTDboz0XCuSCtq/+un6xbsawWTLnpYr3 O86ADfyc+LaoIpqQ3z4atEpcYzw7r0l5hzQCBD8csa88L4vaIgnN3dujCcC8KDKgUpKa MNeQ== X-Gm-Message-State: AFuF++kMeV0LWXRgLmuLsMj1ByJo8LvpprwC1uB6IQ4zee01EyfQ4sol hyLYd0Q+7X69oENfAb02+ewgpGGa/wPX0N+aOoLqgicByMlG1bpCIsUueyrCSg== X-Gm-Gg: AR+sD11SRjF7fgXtUcTVaaE0HVlCjLULXN1DTIkO6nxXhaGcMRw8g7Zct7XCU7A+kxN tRdr9oiGqAfLqv4tFajZHzLcYqbkzDJB4M0/QPJ6kW7cYmuM52xDcffZUK8QSUqWj/6eyNY2xZe L1hgZvnYe5zIBZNq4pjPsaqm0STDfELCsE9+Ibg50Jlh0ufOVf+K5mZEmi6UGRivipjpOc52GDX VbMJfWQ5QD3yb5tvOHWMkvvtwk9RYZXfYCL0vyqhtdL+p1IESuj7Liw0p0qFFKGKFVJyD0t2ksF 6SZe9fxPkWj6rLVljHHtHqeYvCZQ+yktNdktjkM6FmdKt+H4QPuIx0aueCDmbsbECPvwKtvRNwK FbXZhjG6/BlMau6Nx7PV9cx8VpLBDrnFOcZj6d+cNfX6izqq4PuKFU5Mhq39eHquQcI917wgmmj pHZfJnkx2XVHfrKJqIBHM/Cj8etCuV0as2JM6hV6vBzblbVhvQmezqpV5CQkM= X-Received: by 2002:a05:6a20:c91c:b0:3b4:8880:2089 with SMTP id adf61e73a8af0-3cd301784afmr24015511637.16.1787392055029; Sat, 22 Aug 2026 02:47:35 -0700 (PDT) Received: from gmail.com ([58.84.62.206]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141860c6e6dsm5527217c88.1.2026.08.22.02.47.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2026 02:47:34 -0700 (PDT) From: Sumeet Pawnikar To: rafael@kernel.org, linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, sumeet4linux@gmail.com Subject: [PATCH RESEND] powercap: intel_rapl: Fix kernel panic during PMU unbind Date: Sat, 22 Aug 2026 15:16:57 +0530 Message-ID: <20260822094657.12489-1-sumeet4linux@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sumeet Pawnikar rapl_package_add_pmu() fails internally at perf_pmu_register(), and rapl_pmu_update() leaves the global rapl_pmu.pmu structure zero-initialized via memset and returns an error. But any previously probed packages retain has_pmu = true. When the driver is subsequently unbound or removed, rapl_package_remove_pmu_locked() sees has_pmu == true and unconditionally calls perf_pmu_unregister(&rapl_pmu.pmu) on the zeroed-out structure. This attempts a list_del_rcu() on a NULL list head, immediately causing a kernel panic. Fix this by checking if the PMU is actually registered before attempting to unregister it. Signed-off-by: Sumeet Pawnikar --- drivers/powercap/intel_rapl_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c index 1006d183d508..22100f1ca222 100644 --- a/drivers/powercap/intel_rapl_common.c +++ b/drivers/powercap/intel_rapl_common.c @@ -1652,7 +1652,8 @@ void rapl_package_remove_pmu_locked(struct rapl_package *rp) return; } - perf_pmu_unregister(&rapl_pmu.pmu); + if (rapl_pmu.registered) + perf_pmu_unregister(&rapl_pmu.pmu); memset(&rapl_pmu, 0, sizeof(struct rapl_pmu)); } EXPORT_SYMBOL_NS_GPL(rapl_package_remove_pmu_locked, "INTEL_RAPL"); -- 2.43.0