From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012024.outbound.protection.outlook.com [40.107.200.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06E62248896 for ; Sat, 22 Aug 2026 20:02:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.24 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787428951; cv=fail; b=rlq0/TqMWjWJEonAo0OCGTcpw8tm/Ma2reGruOk5/RIzQ4Dynn60LtJuvdlAIpAw0GZobt/A5kFc2OfuakNzLT3KHYFL2Mzba6dUjzt/q9wmbJVj6Ov9TmhBSodXmew/1dm513+kKioa/iqQhF0oHX+uhvPeTbZWrD8WQmlP184= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787428951; c=relaxed/simple; bh=Et5nH3XyrujtRTAPllliBR+rV6jCIrz0LtygOJc6cJg=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=KTjqM7lz23JfGGKQLzmZm9yxxoyo6MEq1nciTBoIjwOtnpKUJgCHM6JejSrn5h/pHR2On6x6xRnrWzuNR+lFmZA+LADTYycHnT88noss9/V7mANqKgH9FWzUggu1i1KrM20dRnO+nxvQbl6yLeSZDyO088xYrNOWecUtparHefE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=pRpTg9VE; arc=fail smtp.client-ip=40.107.200.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="pRpTg9VE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=S/9+iMe6lPbLgfElb1cvS4uQCEtGATLL+kYiVW08zz4VnN77dUQm+xWbYpKyK0l7t29HGxLqNfPjaGC8eR/SjCg2YvV/4+wd6bKZFXXCMEgqpbowOLBJ6AjuB3an1PeFvrI5nZSlaJGieEiSuej9wEHDpvxmOiIQDI/JcCDEmVr44NvGE/p6sNWJcEV/5Qcfasi8FEZtD8EPX8f2LYUf0YASt1FwHzbWf4JcMw4c+IQHmMw6NwWMsPHGBWnIy2OAH/LeWQyWR9vNC04H4jL5AGWpPEZbJZW4DAV0lBLuVbVPbCsxblwpACo4+JlKXUJElSzTnFkh9MfRre1mm1F7uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c76e8qnZ48IjVa7fcJxlXE7lBHWwuLE4C4uF7wBFi3c=; b=pEYDQcXS54QKUTVw0OLQADFkNE5tnjqSLbWVop2jV1OO+/0+Pec2IKyqjznaZIMoDpIpD73oVD2uBSv8FWzlbHZGRRvF6QMptfHMKGX8IpJ1XJSYprPfvdyl/XcHJpSU7+BKJmIBdKu30x3AxfjhxZWv/VzoQ7V/3n80wlI3rzHFSOxasX3HAgVr7zpcWBMu76zoShiUluCnHmYRTpBxswnpsaWLScVmpK6omWT4MGUI7AuFs3wyr92WdjEgozryhBFp8Ce0jU3h4PtX9nuE3UvS7qSAaTfxBuXEBlNhXsk54BhVOlq1+Tq59swgERFXX18n2ZD4iMDIssR/48dU5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c76e8qnZ48IjVa7fcJxlXE7lBHWwuLE4C4uF7wBFi3c=; b=pRpTg9VEuwngFiq7JUu2px9+Te/O/rnJCegYhPfjgW16IXegAMcW5jpAKv2zEHmKHCK1QJcWu3rYOtTtGJ6YwDjLXZ4xO9HHWBhUH6abJe6ZPb9hGQJB+KD9inS238vOYdaWLgUhLo1ZZvP1/Y71BjBFRaF3FT7Z3yDH+Cjg2b+QC9urbIWOullyzxc1FzHmVuQ6lsHHCsynevjobIwq174cp/AwCTmrITvI6UDYUbQTzLJTG8lIJ2YPlKGOCnf5se/MnJTZGCWMdsm570i0ceoqxwG4Ay5ZLA7NgcUwlVOUIOyj63dJlzfOZN7cWPVP40/Jc5zFzdTmv9Het3SIcg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by MW6PR12MB8835.namprd12.prod.outlook.com (2603:10b6:303:240::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.11; Sat, 22 Aug 2026 20:02:27 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%4]) with mapi id 15.21.0339.010; Sat, 22 Aug 2026 20:02:26 +0000 Date: Sat, 22 Aug 2026 17:02:26 -0300 From: Jason Gunthorpe To: Nicolin Chen Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, praan@google.com, kevin.tian@intel.com, smostafa@google.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, jamien@nvidia.com Subject: Re: [PATCH v9 09/12] iommu/arm-smmu-v3-kdump: Implement is_attach_deferred() Message-ID: <20260822200226.GO244917@nvidia.com> References: <178735412602.18212.5709943748630447883.b4-review@b4> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BN9PR03CA0798.namprd03.prod.outlook.com (2603:10b6:408:13f::23) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|MW6PR12MB8835:EE_ X-MS-Office365-Filtering-Correlation-Id: c3457321-57c8-4e46-63b0-08df00884a01 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|366016|376014|56012099006|6133799003|18002099003|10067099003|22082099003|4143699003|11063799006; X-Microsoft-Antispam-Message-Info: gGZ3Y+xsSQLV1OV6Y/IQW/KbwbctE52ml38w1JIriwXbiojSg3c99I1a26/rVYSTJtn+7u6ChSXZSuOVCsTv++sMn7JArhCDVOuoB2A0cUamCJ6mFjs+DM52P0ovmSfEfk7BWv7X4y1IurmGVn91OaeUMlkRuQUUqkvVNTmaIPwPDNveKT7X4kBAv+FkiwkWXvfMce5x9T/lmFqbSK6cZNvHRZmCNz4R6wu3Vc3ftvpuM+4AuIwvYFOABk0GXhKAQglfM3b8ZF/N9Y7QZc5jYMdp3JhIQYrDhAqrOzCt1LwRVlbTgNuXJQUEaoJUsbWb/6OKCRhInhsvNHKuchJ1g0qFWuLjHE/zO/tLOmuVCw8aCVmi6uB+NIriUzz4BjKE7+GPB9Ah4lQ7VALSNRCIgeanNHsOzKjELkAV67T9sdVRsHBjereHUdqV7i0rxeow2N50c8Z4EDg2qhhuQxWo0fLVOH1YRjQgLiPBoMegUmICfc/b2kaPKpjjT0/7NKP7bcxxljtSYLis6s65nx7z77rzmkQaYBsLjUD93WD2x6xCgNFo9q/OZ9R33xbXL5MmhX8OJfxfMTq3G6ed+wNIBLliSh69qX7NWyP6oNB+jEJnUsO0UsDOzh9T6xPRiZh8LbYzeqwDY8DnZAmWgBiAqNvFskgLNHr0vWE/EjAWVkk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(366016)(376014)(56012099006)(6133799003)(18002099003)(10067099003)(22082099003)(4143699003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bJs9xeH/FK0XS8pm5wcnJ7UToP65sP1Hjbkx9PP0mpr97bZJtQW3PZyoTIhI?= =?us-ascii?Q?mn8/eoXYSV2KKIyqGZIqkeeL2XBGYidpGOboKJpFW3k0B/HBTgZ3uHqFNijl?= =?us-ascii?Q?2QhN+oDKe0SsPL420rVl3Tnqs6B0gwM3X+LPW42pJTTV5UNfwmnjXdCH75tQ?= =?us-ascii?Q?abHD2/RProbmnsWXvKrLtFZKVYNu15mRweyEQ7BsKDpyEysU413+FLRskjiE?= =?us-ascii?Q?SJ7kute8kVo+2bJMxWX7YroW/gvUKHQD0Aq7mA6HDfE1hnob4z+qMMr1OtaV?= =?us-ascii?Q?djI6RW7At+6bMMX1k18QeZ+3vWpoEWQXBnQg7sRAY3DXCfcIQUsMfd8bMiEc?= =?us-ascii?Q?SmbQ0mN7rAx6WwFjXfzc+GpV5wVPR4nvMApdkAQ9teE4SsvNvtQA1VVDeTXX?= =?us-ascii?Q?CiWHgOYtw41jHszL2Tg97zKqG8+Uu6t/ndojH8mdeLGiVed3PxvQ+By6hdtE?= =?us-ascii?Q?nQPuuJxpqvNmUiIzUZp9A7nQlTJeA9p3yENHy2vkh7gNZREq2hxgmfaYb97+?= =?us-ascii?Q?KI2sZAg4rTXFtut7e4pFqsy2Z0cLfz2o9sABhEfqyR12b0aoV66L5wX4t70m?= =?us-ascii?Q?f0JBwxDOyD8uoIGbohRm8WCTGGDa67VyezxnDxyPbHysyi1OC45udeD+7XBu?= =?us-ascii?Q?UYDSdwN4qg1/cy2yZf5xgtwBgR0nOes3FzmCUvXFGWCRm1DQLYeHBMzB1hfu?= =?us-ascii?Q?xU0oJI7Uo1b/QLaM8wE/NlIC8DqTXYZAMbjo3jDdsUF8jo/lPrV8tR2E4i//?= =?us-ascii?Q?2y3cF7NdqMZNkEZghkwMK+DBRZ5kJyJeNWyTrZjT02QxIhrqeSa9JoFptXSK?= =?us-ascii?Q?YysioCIAsNHR7zdK+JF9aP0uT1ZpUJXRoyh+UBhUYxuWaMY5G7GFAXRi2rPm?= =?us-ascii?Q?I+zzVDOHrf24XhqlEegwAAtqPovNITrNK5AvTMSiNaQuIOPg3fQMCpD7Lz/x?= =?us-ascii?Q?5hLZILq8rXrSfMF1CH0h73RKVXNM6icT6GmHiX8wOjDiQGtEUmRpptXU0K4o?= =?us-ascii?Q?cpCLJV1r9Sah4eixMhJ+1wvF6ASuCXR+bOcoGQlQAcaLkhlraiwmpMUy8c4o?= =?us-ascii?Q?tzJ5kXeP9+9y6d+BRMAwDrLYFS7ownp/e24LCzl76JYNie7nv9LAfNYKWH57?= =?us-ascii?Q?9GdvoHxw+/m7ksa78Qd88jJR9zhpYfILLYE6zET0TuVkjjzAivjAki/dFuKU?= =?us-ascii?Q?VxSAX/4rKcUZpQiiyNTBYLkO4HZHmydtgLlsKswXd8YTFHQeU+i8v6UeuezR?= =?us-ascii?Q?kigK4LJec/ro+6bntaYfNWM5lQ/d6MT/WpPpTVVF7rDGdM0rEkZLekrJGxCr?= =?us-ascii?Q?pQOCo5MZSpCVKEixA1+11+2r/JLGd7CzWvJkhcShq+GbQKHpbnImTEjyxlUK?= =?us-ascii?Q?q5JwcXivn0UXCkXj5ztXzT8tmZNcdNC5zDziFiF3ljzkAVj766gG7nvxpTdT?= =?us-ascii?Q?Kk/6uzTyuZ4ktWsYWfUl2tkZ/T9aL12cU9pUYHU7k7GIh68v2RH6SSc6Vwf3?= =?us-ascii?Q?AdsG4TYHOroCPxQ4sP+AXwndbKx098f67Dm3+87fShPmwD0QV7/I2BOfYM4q?= =?us-ascii?Q?/+5jGAKUwA2qBeHQIjjkOJ8XTL3AopfWRfct9q0P0FMdhfLA3nmlKEXxMfEQ?= =?us-ascii?Q?Twx8VpHFu2Es0wdg8hVlZILvrN7AkExF88rDHsyQSyaZgtfllaWkDf5y43aq?= =?us-ascii?Q?RRxRki0qld+1jB7h7Fq1njpvGIRrAb9xCLPSCMZeDUU4sUo8?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3457321-57c8-4e46-63b0-08df00884a01 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2026 20:02:26.8141 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fSYUTvZnwnOcKO/RcW4875gIxixlreiHCgRzuLX/l39wpsqhB/MDkJkUi0gc8kdB X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8835 On Sat, Aug 22, 2026 at 11:16:35AM -0700, Nicolin Chen wrote: > On Fri, Aug 21, 2026 at 08:15:26PM -0300, Jason Gunthorpe wrote: > > > @@ -1276,6 +1292,12 @@ arm_smmu_kdump_adopt_deferred_l2_strtab(struct arm_smmu_device *smmu, u32 sid, > > > { > > > return -EOPNOTSUPP; > > > } > > > + > > > +static inline bool > > > +arm_smmu_kdump_is_attach_deferred(struct arm_smmu_master *master) > > > +{ > > > + return false; > > > +} > > > > > > ? > > This is for !CONFIG_CRASH_DUMP case. I think we need it. Hmm, I am testing b4 review.. I had written #define arm_smmu_kdump_is_attach_deferred NULL ? And I now realize b4 review drops lines starting with a # Jason