From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00CCA303A0D for ; Sun, 23 Aug 2026 04:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787460544; cv=none; b=Uyz/489aqo+Ry0zsIXV1y4VrvhbfZi9DO7yHia3mHbIwTwpwqtPoBR6T2umzDdptOkwU/hlDsHFqfIZiERVUl2l0/uIzXv+CeTOS41anfks0YPlj6oh5MWGStBGBi3wtPFbZMCLjNBuYbkGPWkd/Zp8nWLuXQdvIDIynwEsoBXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787460544; c=relaxed/simple; bh=F+0vuiycaJvFPWmw//1urs2k2rOSC8DbaT8Oh+hH1FM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gNOGhwcs0SrXzVpPBYR6TUbHbl1LJ/3wA18U4JrSIJX18cUnmFGdpcDdcF6o3GVhJahitkEU6L1jdrcSeoyzT+CUK6VK62tmOf+I9LismbEZa+Y6jT1tL659JFeFDEgJ6gRWr7Luxv0gfpr810OSy94aOWwPO9t+5THPo5LzHLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hoO6GZfz; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hoO6GZfz" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-cbedd5aece4so2425560a12.0 for ; Sat, 22 Aug 2026 21:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787460542; x=1788065342; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=/QF2AuM00HE391Q4c/R+W2Bvyni/B/dT5eEtEIhGwlY=; b=hoO6GZfzq9DVod38Lap/G3aY5seiEGu/4cjmrKL1J9Ge3lsk6gCvgB0vLr6YlHPFQR XJW/SEDdBAcMjYGSuuvz3ZribBLKeVJLd12bL0fpkpAhG9ZTxlQBj01WNAdf096A3636 Fk3wAwd4SUD4ojk+Dn1XldXe+hm5LVm9rLQ/SPHDq76ikO7BYQMLXasPXD+O0lqo0SXf ni23J61PPLEQIaQC7FVnHdtesyk5CmnwrFjmG5IwKTI0+EXjTi0kVXIlcmMcAriDaOGf foj4Cyb089qRRqN+He+rSboWVe/sVDyjIP2lLXuwZAiJZHaEEZwRY/BuHh+71AoBu9w/ x+sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787460542; x=1788065342; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/QF2AuM00HE391Q4c/R+W2Bvyni/B/dT5eEtEIhGwlY=; b=I2MblOkvD6yEi2EgXW1t6/OyH+Wq0ksXR6O8bySf4WdbeFuHZVrFI0Wg5xhc1UmbqG 70hmZguExphQTzMtYL3zQ2YogmZonFtcToLGOkdH+TUk/ibcLH/3TZw3x0CJ/UG12zlf KTFeV8m4qHbHfngzgtPTTdPJTNqkzzQPciL0btLHFmTdMcnL3XGK45bLGsAq/WzjftFg 4RPFHGUFwFRoXlahncZ8y37F+df740pLPbGGFQlsyi7MvqY+4spUvFcbx5czKBoZ3rvJ uWaFuVZzLJpU5NZ6pmto9XxSSM7Pgq9hy0Z5C+gCIbiPFDr6cef6PCbaG/drwPMpGXGa Ds2g== X-Forwarded-Encrypted: i=1; AHgh+RpNG3IHOP8vNIYz1jM1yfBdtj/yIlWNp+ei0PApYX78gx/HfKw9NgbGkmhhrJAKQqxkAY51mKzZ13RpSxw=@vger.kernel.org X-Gm-Message-State: AFuF++moAE6Tl92lmNwPJ1/LW3LYLHo1BWzyeonMQ8u5aUffFP51RdKv g7blCtObA9VD0bEQOlEgd0JiE8xitFE99WKFM2Uatn0fmZkxfuCU7+RY X-Gm-Gg: AR+sD10FyfeKsMaO1lcgsv96L9fsU1+MUh1iVa0sg/4yuIhJOLHxcJU1fG5rj23zlpU FP+IRKyuvda7M3K6C+oFPtryc/GYb7GUJqSKvvoUhyQFPFdwXAPTLFZUALbmwOZxbWyjrh4i6QW WNzFOSYrXgaN4W63NyBlUdnqotHzgQYDz558tEj+Hj8N88G8ebNSYJSPerSB2KQzWV7UJHUqWjq oXqCGTNLES0zmLnRarPxKCHQ0KJtY7GYQLgOjZOmCAsxTF9pzteBQm/RXfKwh7DbGyGl6xziAFm p9GIxKo16bqWWE06CakLrnQdzgitYsZILoZc8ciL5YnyAUXxyx6dowWjbN5UafCEZUq4dPLRpNS RY8olcF1yaDen3NlNSDj5xhata2ny3VmmPXS8zKsCEp8EUz6dAcjPCbg/p9Rcr7DRcXluWi0GFZ pBM8XQJum6GNgPqIqIwUDu5OxpO9vKmEr7U72Um9/KbFIng/jI4HsizIpYjrgksqBBrs/rIFUEy lXURRFS8/BrtFamHybMDWpRBzeBSlNMOntBP3IFcd5KKu8w/lvBXPqCXcJiQ+OuWlI0N3WOJRIE kpXxt3Ftlm94hfBq2vZQRSAxPsGYBWRKqWymDA== X-Received: by 2002:a17:90b:39a3:b0:384:927f:3db9 with SMTP id 98e67ed59e1d1-395c4bdddaemr12910103a91.1.1787460542163; Sat, 22 Aug 2026 21:49:02 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395e49d8d26sm4824412a91.10.2026.08.22.21.49.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2026 21:49:01 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] dmaengine: bestcomm: ioremap early Date: Sat, 22 Aug 2026 21:49:00 -0700 Message-ID: <20260823044900.11466-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Doing so allows handling potential -EPROBE_DEFER before any work gets done. Replace the open-coded resource lookup, request_mem_region, ioremap and the manual iounmap/release_mem_region cleanup in probe/remove with the managed devm_platform_get_and_ioremap_resource() helper. This removes the now-unused error-unmap/release paths and simplifies probing. This also fixes a resource size mismatch between allocating and freeing. >From sashiko: > release_mem_region(res_bcom.start, sizeof(struct mpc52xx_sdma)); This is a pre-existing issue, but does this mismatch in size during release cause a permanent resource leak? The memory region is requested earlier in mpc52xx_bcom_probe() using the device tree node size: if (!request_mem_region(res_bcom.start, resource_size(&res_bcom), DRIVER_NAME)) { However, the error path above attempts to release the region using a fixed compile-time size: sizeof(struct mpc52xx_sdma). Since __release_region() strictly verifies the boundaries of the requested resource, if these sizes differ, the check fails and the I/O memory region is never freed. Driver unbinding in mpc52xx_bcom_remove() also uses this same fixed size. Signed-off-by: Rosen Penev --- drivers/dma/bestcomm/bestcomm.c | 45 ++++++++------------------------- 1 file changed, 10 insertions(+), 35 deletions(-) diff --git a/drivers/dma/bestcomm/bestcomm.c b/drivers/dma/bestcomm/bestcomm.c index 432b43520ddc..44ff4a42376b 100644 --- a/drivers/dma/bestcomm/bestcomm.c +++ b/drivers/dma/bestcomm/bestcomm.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include @@ -365,13 +364,19 @@ bcom_engine_cleanup(void) static int mpc52xx_bcom_probe(struct platform_device *op) { struct device_node *ofn_sram; - struct resource res_bcom; + struct resource *res_bcom; + void __iomem *regs; int rv; /* Inform user we're ok so far */ printk(KERN_INFO "DMA: MPC52xx BestComm driver\n"); + /* Get, reserve & map io */ + regs = devm_platform_get_and_ioremap_resource(op, 0, &res_bcom); + if (IS_ERR(regs)) + return PTR_ERR(regs); + /* Get the bestcomm node */ of_node_get(op->dev.of_node); @@ -402,35 +407,13 @@ static int mpc52xx_bcom_probe(struct platform_device *op) /* Save the node */ bcom_eng->ofnode = op->dev.of_node; - /* Get, reserve & map io */ - if (of_address_to_resource(op->dev.of_node, 0, &res_bcom)) { - printk(KERN_ERR DRIVER_NAME ": " - "Can't get resource\n"); - rv = -EINVAL; - goto error_sramclean; - } - - if (!request_mem_region(res_bcom.start, resource_size(&res_bcom), - DRIVER_NAME)) { - printk(KERN_ERR DRIVER_NAME ": " - "Can't request registers region\n"); - rv = -EBUSY; - goto error_sramclean; - } - - bcom_eng->regs_base = res_bcom.start; - bcom_eng->regs = ioremap(res_bcom.start, sizeof(struct mpc52xx_sdma)); - if (!bcom_eng->regs) { - printk(KERN_ERR DRIVER_NAME ": " - "Can't map registers\n"); - rv = -ENOMEM; - goto error_release; - } + bcom_eng->regs = regs; + bcom_eng->regs_base = res_bcom->start; /* Now, do the real init */ rv = bcom_engine_init(); if (rv) - goto error_unmap; + goto error_sramclean; /* Done ! */ printk(KERN_INFO "DMA: MPC52xx BestComm engine @%08lx ok !\n", @@ -439,10 +422,6 @@ static int mpc52xx_bcom_probe(struct platform_device *op) return 0; /* Error path */ -error_unmap: - iounmap(bcom_eng->regs); -error_release: - release_mem_region(res_bcom.start, sizeof(struct mpc52xx_sdma)); error_sramclean: kfree(bcom_eng); bcom_sram_cleanup(); @@ -463,10 +442,6 @@ static void mpc52xx_bcom_remove(struct platform_device *op) /* Cleanup SRAM */ bcom_sram_cleanup(); - /* Release regs */ - iounmap(bcom_eng->regs); - release_mem_region(bcom_eng->regs_base, sizeof(struct mpc52xx_sdma)); - /* Release the node */ of_node_put(bcom_eng->ofnode); -- 2.55.0