From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7899932AADB for ; Sun, 23 Aug 2026 05:03:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787461387; cv=none; b=EBUqFKYh8NPa0MzOj6U4zsapRmxruWNeQQifwOewjHWFKrwpqZlRigZBTcTaxwMsFswHkfJSvw+4evs9fNrnHZlJT4AQD5CoJqTqaYyNMZtjYXJc8CpRLF2VE9KPaJxUeVTGBiWF/9il5djL+kRy9S8yW9P2Dw89RM6LWnsi5Pk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787461387; c=relaxed/simple; bh=hAD+G8Mo3UdF052YHyiR11j6lNr/zx7gMxKV+5Xp3yE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZWdusUn2462f05vx5sCBMoiy79m0FpTy80vHaCJQTwR+32YPa9gL0EVRzOZZsBXocqoPCMVyM9wJ8QevBTH6D6qaaHFYbmxzi1QYyVPAIAsVzE61TV1zWApAYiODQM6UXed/j2G1QjxbLaulHrbRVNTrveC1GIysxakxm0QyHXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IMTSgjIW; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IMTSgjIW" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2caea3f742bso37862395ad.0 for ; Sat, 22 Aug 2026 22:03:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787461386; x=1788066186; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=JA5XMiOxCtI6Cv6cvLy2e2rZtS3fpKUachOjJ9i3SoA=; b=IMTSgjIWtEC8dUwd50XAiRmDJBfL0+UpPCJJIs5SqEU6IML/CeuJVrg7AhF1LdgcM7 Ht3TTMGu1SF//pSY0njiS22exCo68uckKn3TZBFYV0NbPJMS2GD66VccTgFigVDIxyO6 BMxoYTm3NdnmnvugM3AiHGUt8Mg85F77PTfl2PG6W55OpqreASLq6T7M5tZoihoDaLBO a0Wzqdlk2XpaZ4D/UraPRtvrC3GB/Zh0HN9zbaRMf2bRoNICVB2wDRA+UX2dvdL/CQld LaTsdYauI0Au6mi6lYVWB7Cnirz1G0QpgiuqJ2KklrzunPTNku0Hcf3ZGE3w+dhNcGeN mP1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787461386; x=1788066186; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JA5XMiOxCtI6Cv6cvLy2e2rZtS3fpKUachOjJ9i3SoA=; b=s5DEhCkasqzd/k/namCIkOjKojbRtXybNWJsHFDxjyvTxvWfgxambmia0P80epD01P BvrwKSehYlxx+3yGpunaOcHEWdvmzy5OAeA3MwNP7KocGUGeacW4SApPexGlobPvAxU6 wmwG3r5m0biMgqPu2479Tq9ET54M3aiCn80taxmBz7RdmVNApiblDez2/ohK8QEI54hi EBGyjbqy0yH+n/wMMvsZh7DiITqNHSsnyIQW5dTa2tpYJrYkfMsDhkKLqJzgEucOu6FE 234CLI5r5JPpcbsnMRDQxhzmz0OtlB/qnsJ80OUd7GvMLp4xuGD/peKwkZDPUagNXW57 cJ2Q== X-Forwarded-Encrypted: i=1; AHgh+RqYJOKQAlFp7ztmlDqsSGtxATj3JNQ9KvdzMI9gRDQTDoPc3oMEm7f5eiL4VaaQbI6iyEoYS6/IkRJOLN0=@vger.kernel.org X-Gm-Message-State: AFuF++lktw4+aG8AoMv7iAeVzXFF15wHl/N9JYIR4fHx7lD3xzN6rRaj q+6Tixclu12B1HZaEpdWPqE4/MjqATzQbYz+ZSeXh2SoY2Zb+aOi+Fm5wsXSzg== X-Gm-Gg: AR+sD12AXBQO8NqEY6IvhF5W44S3vj57PmywPRmq32ZAB1HJh6kNBc+FVg1zH2jN3a5 wkxvntRrtEw2dNVCpbucKIh1sBB535m5/nmtXKzHjTYPHA98ZudRu0050Zm0CUNjyjKPG+Yrbim Q4TezSfY7NhYyrkeysKkoAS5XVZ/JaF9gRX5Z6JdE12E84F0ZKW1bGEP+wPljxgINXyqbHfzaiM EWmAT9I0MBwNUyg2pvUMP374JT0OthPpAQZMRd9dB/l4gh7MunvUXnqbo2q1ddoXwUwUb6PftZI 4vhbQvqDa1OkIRVFa7+A+SdlM7Fkg7PGhL8bxsRtyniy7XfsJYVycKjCFXEt8UEClvZ9CW2oDTH ED/t1DKhLHtDpIHefTlyJUEVL8msvkfhp4T7MvpO4en8/tkBV0dtrzqeFetNNug8nBONnGtDYhg pgVr5ssAfsAM1B1u7HPn3JJDauCMKBrzA6ebrxTn6ehMS795StgOZCilXlqzpbGTyKd6ZRRJDUH v7LI+QjmLPKAqmJUBMmcidhLv8+s59KaC3aHJSKI2hekA1yqdGHnkCkAyY6VQOy2btPy0HVCMZ+ mckvHHqsuAAwPYjmYANJgTvecBkvHztUwfYBAA== X-Received: by 2002:a05:6a20:7292:b0:3b4:7e2d:a3c2 with SMTP id adf61e73a8af0-3cd301c72f7mr26440958637.18.1787461385654; Sat, 22 Aug 2026 22:03:05 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc199daeccbsm134270a12.7.2026.08.22.22.03.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2026 22:03:05 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Ludovic Desroches , Vinod Koul , Frank Li , linux-arm-kernel@lists.infradead.org (moderated list:MICROCHIP AT91 DMA DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCHv4] dmaengine: at_hdmac: use devm APIs in at_dma_probe() Date: Sat, 22 Aug 2026 22:03:03 -0700 Message-ID: <20260823050303.17725-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert resource allocation and setup in probe() to use devm-managed APIs. Simplify the error handling path and remove explicit cleanup code. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev Reviewed-by: Frank Li --- v4: adjust subject and description again v3: fix subject and description v2: remove list_del drivers/dma/at_hdmac.c | 50 ++++++++++-------------------------------- 1 file changed, 11 insertions(+), 39 deletions(-) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 971f8bc9ec48..49a85ac66e83 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -1986,40 +1986,34 @@ static int __init at_dma_probe(struct platform_device *pdev) atdma->dma_device.cap_mask = plat_dat->cap_mask; atdma->all_chan_mask = (1 << plat_dat->nr_channels) - 1; - atdma->clk = devm_clk_get(&pdev->dev, "dma_clk"); + atdma->clk = devm_clk_get_enabled(&pdev->dev, "dma_clk"); if (IS_ERR(atdma->clk)) return PTR_ERR(atdma->clk); - err = clk_prepare_enable(atdma->clk); - if (err) - return err; - /* force dma off, just in case */ at_dma_off(atdma); - err = request_irq(irq, at_dma_interrupt, 0, "at_hdmac", atdma); + err = devm_request_irq(&pdev->dev, irq, at_dma_interrupt, 0, "at_hdmac", atdma); if (err) - goto err_irq; + return err; platform_set_drvdata(pdev, atdma); /* create a pool of consistent memory blocks for hardware descriptors */ - atdma->lli_pool = dma_pool_create("at_hdmac_lli_pool", + atdma->lli_pool = dmam_pool_create("at_hdmac_lli_pool", &pdev->dev, sizeof(struct at_lli), 4 /* word alignment */, 0); if (!atdma->lli_pool) { dev_err(&pdev->dev, "Unable to allocate DMA LLI descriptor pool\n"); - err = -ENOMEM; - goto err_desc_pool_create; + return -ENOMEM; } /* create a pool of consistent memory blocks for memset blocks */ - atdma->memset_pool = dma_pool_create("at_hdmac_memset_pool", + atdma->memset_pool = dmam_pool_create("at_hdmac_memset_pool", &pdev->dev, sizeof(int), 4, 0); if (!atdma->memset_pool) { dev_err(&pdev->dev, "No memory for memset dma pool\n"); - err = -ENOMEM; - goto err_memset_pool_create; + return -ENOMEM; } /* clear any pending interrupt */ @@ -2086,10 +2080,10 @@ static int __init at_dma_probe(struct platform_device *pdev) dma_has_cap(DMA_SLAVE, atdma->dma_device.cap_mask) ? "slave " : "", plat_dat->nr_channels); - err = dma_async_device_register(&atdma->dma_device); + err = dmaenginem_async_device_register(&atdma->dma_device); if (err) { dev_err(&pdev->dev, "Unable to register: %d.\n", err); - goto err_dma_async_device_register; + return err; } /* @@ -2098,27 +2092,15 @@ static int __init at_dma_probe(struct platform_device *pdev) * dma_request_channel(). */ if (pdev->dev.of_node) { - err = of_dma_controller_register(pdev->dev.of_node, + err = devm_of_dma_controller_register(&pdev->dev, pdev->dev.of_node, at_dma_xlate, atdma); if (err) { dev_err(&pdev->dev, "could not register of_dma_controller\n"); - goto err_of_dma_controller_register; + return err; } } return 0; - -err_of_dma_controller_register: - dma_async_device_unregister(&atdma->dma_device); -err_dma_async_device_register: - dma_pool_destroy(atdma->memset_pool); -err_memset_pool_create: - dma_pool_destroy(atdma->lli_pool); -err_desc_pool_create: - free_irq(platform_get_irq(pdev, 0), atdma); -err_irq: - clk_disable_unprepare(atdma->clk); - return err; } static void at_dma_remove(struct platform_device *pdev) @@ -2127,22 +2109,12 @@ static void at_dma_remove(struct platform_device *pdev) struct dma_chan *chan, *_chan; at_dma_off(atdma); - if (pdev->dev.of_node) - of_dma_controller_free(pdev->dev.of_node); - dma_async_device_unregister(&atdma->dma_device); - - dma_pool_destroy(atdma->memset_pool); - dma_pool_destroy(atdma->lli_pool); - free_irq(platform_get_irq(pdev, 0), atdma); list_for_each_entry_safe(chan, _chan, &atdma->dma_device.channels, device_node) { /* Disable interrupts */ atc_disable_chan_irq(atdma, chan->chan_id); - list_del(&chan->device_node); } - - clk_disable_unprepare(atdma->clk); } static void at_dma_shutdown(struct platform_device *pdev) -- 2.55.0