From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 009FF2C1584 for ; Sun, 23 Aug 2026 11:23:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484223; cv=none; b=WxUH9EgVBVEw7BiltBbskqKKXZ6KSpS2bWskvhPO+0fOG39+HJk18yWOFi92HifO4AbhHNRej64uD3Dv3+1rxrxeWmzs3KcSwgo6f6IElOvA2wBUArR/Tw5wm9b0/KvS4TEkTPfiOk62WXflIm1Vj8WPdC4qZObjy5GXhxTNc18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484223; c=relaxed/simple; bh=6YnGbDa3II5yQFFGSG0xde4hTK1WFyDJufvbsOoaquU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZDWnYXEuaMM3Kv1sWZU312K77owXnP1YH8wPNP0QrP0Mvgnq+MUIw9wSfnFoZuOmCJ8oyxev7QM1r1spJBDeLmQ1xMxx9F4XMbfzTX/Z6GIahlzwG/igPQdhcZ99r3wfjBVkDSp9OKLibD1o+SkY6u66eOkoQquQQH/2ty6wWGc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=skvhPev3; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="skvhPev3" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-38dcbade417so2795012a91.1 for ; Sun, 23 Aug 2026 04:23:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787484221; x=1788089021; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Ptr1EEhFklyxnn+iSEo4f01MRD0E2W0ubYCaeM8hlqs=; b=skvhPev3VaPtisfFv4HxT5XBdj/xrtTvscyO/usto5qZ3FDP2UTIQwoM4L1ZITeOKV lXj9P4mcfQLNP2V12c/5zYz5fuiOGETtJMCFylgbYVphmo3rN3B55tbiQ+GKtt/39lOR 1J1WyiqDDNWdhaQ5ScaqeOXPZXGXsrFhg7IfhoUU12K3CsUjdQMFeUxtuI8YdMpZg8NT L6BMFmR+yPKBZsKPs/gz+f3YSkz2ULK33PL5L2BKpu7jN/j0OLO2HkNAok30OHZVfIjt 11JHctpWWU1CLAauFnePzuBwJ8PVugHBpd+/w1HM+1jW9YFFgqYsuQ7noqBM+QNx2tD6 jXIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787484221; x=1788089021; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ptr1EEhFklyxnn+iSEo4f01MRD0E2W0ubYCaeM8hlqs=; b=pxq9ab/xQ4NLOBbZqGhAqIPXy8Gln1bOaUBRMP8nM2vxPxmRUqkKdM5X3BPVhMxZO6 a2DduVchpXRKse4/r6t3dLHykbgyVC5r7929V8e2KGlH9fAIrBRs2DsPeI2mNYaNBiMT nriKIiFYG/Vw8LyIUX0J+vWE/ezPvNc4tBOVWD/gXPOzECsc9F1X9P2LhNG04PWaBzzu N3KTndocbp/wZmSYeswYgabKCQ1Yt4v+jO9qOLI/nlQvQ93KZYwvDCUOuOSuBvYzbpaj U5fzSj4A8mbKF70ChSS3yGI0Wtt3/T5sQX0lxnr5YwXoBkY+Ipu7qganENmgHHcccoll iZTw== X-Gm-Message-State: AFuF++mI0MiimlLfaTpoJYh1rvJNbmxzY2ah4tjw5YpiWzLHmDLQuYef x1Pt8x5Wt0TaFGcBJI9EHyyr0Zr0EQNDOdEuZzCslQ+4AmpYOwkThinX7JimKEag X-Gm-Gg: AR+sD10Fnl65PHS+tTBOOWHyOCbbyOYunT9qPQvB74o1E4FVpoxv/oQkmlwo2N796lR 37MvMcqeUU7cXcFRpHDmDKFDlFjyU0/G3rOTaFS1XOgpWIur83l10s6DcTiYBOV/WEixTKF0r6+ kTi/Qnv1+UZoy41g7h3vVIjmbWflGxd3VFQQZjMsMB3DwUCMZjY1qCTAL3ulDfKpzNkpEJAn+aJ AXpfQ+bnzJfr/JkMt8H4etyh47jHPQOSn9+A6XyYdDhy3+iVcaBp6jChc2IepVLm4k3SPmNQI3g e1iSebAhnPO6bQrEmARwFEFJUesh31753tPZS2alrxAMvzBOQrw3TYxdDKZ6Bb1MF5jLp6Eq+F9 C/nKcSDeyaUlkaq9QlBBLsv3bsnGQ2oZb4SUYFuwSWE6RBmbqxLMCnki0tkNTjFNgDI41lqUaxU YfnxbLRnJEdMM5aYS79rY+nf9S0HHceewzm3Ljo1W0cGPZh1Q6vzFFUqhXCjKlvrmCsHVAqCFlg VOU3QhQ1ZWRPXbEhzNKUeok5kxRM2n89IbAB0zGxYD4r8k5bmF8FuUBAgD0QbEo/L3H7XZVBnlq X-Received: by 2002:a17:90b:530c:b0:395:5404:95 with SMTP id 98e67ed59e1d1-395c35516a0mr34599458a91.12.1787484221193; Sun, 23 Aug 2026 04:23:41 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:94:a5e3:6c88:cdf4:5469:310]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1418600535csm13753057c88.0.2026.08.23.04.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 04:23:40 -0700 (PDT) From: manushprajwal To: jassisinghbrar@gmail.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH] mailbox: mtk-cmdq: fix runtime PM usage counter leak in cmdq_mbox_flush Date: Sun, 23 Aug 2026 16:53:21 +0530 Message-ID: <20260823112321.2039-1-manushprajwal555@gmail.com> X-Mailer: git-send-email 2.46.2.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit cmdq_mbox_flush() calls pm_runtime_get_sync() and returns its error code directly on failure. Per Documentation/power/runtime_pm.rst, pm_runtime_get_sync() does not drop the usage counter on error, so the caller is expected to release the reference itself. The early return here skips that, leaking a runtime PM usage count on cmdq->mbox.dev on every failed resume. Fix it by calling pm_runtime_put_noidle() before returning, matching the pattern used by other pm_runtime_get_sync() callers in the same subsystem (e.g. drivers/i2c/busses/i2c-tegra.c, drivers/gnss/sirf.c). Signed-off-by: manushprajwal --- drivers/mailbox/mtk-cmdq-mailbox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index e523c84b4..2010aadbc 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -565,8 +565,10 @@ static int cmdq_mbox_flush(struct mbox_chan *chan, unsigned long timeout) int ret; ret = pm_runtime_get_sync(cmdq->mbox.dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put_noidle(cmdq->mbox.dev); return ret; + } spin_lock_irqsave(&thread->chan->lock, flags); if (list_empty(&thread->task_busy_list)) -- 2.46.2.windows.1