The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Vernon Yang <vernon2gm@gmail.com>
To: akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org
Cc: nico.pache@linux.dev, ryan.roberts@arm.com, dev.jain@arm.com,
	baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev,
	zokeefe@google.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, stable@vger.kernel.org,
	Vernon Yang <yanglincheng@kylinos.cn>
Subject: [PATCH v3 0/3] mm: khugepaged: fix tracepoint UAF
Date: Mon, 24 Aug 2026 17:29:32 +0800	[thread overview]
Message-ID: <20260824092935.73892-1-vernon2gm@gmail.com> (raw)

From: Vernon Yang <yanglincheng@kylinos.cn>

The khugepaged tracepoints take a folio pointer and call folio_pfn(),
but by then the folio may no longer be valid: freed after folio_put(),
folio_unlock() or pte_unmap_unlock(), or not a folio at all but an
xarray-encoded swap entry. On classic SPARSEMEM, dereferencing it oopses
khugepaged as soon as the trace event is enabled; on other memory models
it merely prints a bogus pfn.

Pass the pfn to the tracepoints directly, captured while the folio is
still pinned, closing the use-after-free windows in
mm_khugepaged_scan_file(), mm_khugepaged_scan_pmd() and
mm_khugepaged_collapse_file().

This series is based on mm-new.

V2 -> V3:
- Place folio_pfn() inside the xas_for_each() loop in PATCH#1.
- Already defaulted the pfn value to -1, to simple it in PATCH#2.

V1 -> V2:
- Instead of passing the folio, just pass the pfn directly.
- Using the folio_pfn() before dropping the reference or the page table
  lock.

V2 : https://lore.kernel.org/linux-mm/20260815051924.194810-1-vernon2gm@gmail.com/
V1 : https://lore.kernel.org/linux-mm/20260811133655.267739-1-vernon2gm@gmail.com/

Vernon Yang (3):
  mm: khugepaged: fix swap entry value to folio_pfn()
  mm: khugepaged: fix folio is used after pte_unmap_unlock()
  mm: khugepaged: fix folio is used after folio_put/unlock()

 include/trace/events/huge_memory.h | 18 +++++++++---------
 mm/khugepaged.c                    | 15 ++++++++++++---
 2 files changed, 21 insertions(+), 12 deletions(-)


base-commit: a032d41a86cb82a747bc14d9c82b3e153a9a9ab7
--
2.53.0


             reply	other threads:[~2026-08-24  9:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24  9:29 Vernon Yang [this message]
2026-08-24  9:29 ` [PATCH v3 1/3] mm: khugepaged: fix swap entry value to folio_pfn() Vernon Yang
2026-08-24 11:54   ` David Hildenbrand (Arm)
2026-08-26  2:44     ` Vernon Yang
2026-08-26  7:57       ` David Hildenbrand (Arm)
2026-08-26  8:07         ` Lorenzo Stoakes (ARM)
2026-08-26  8:08           ` David Hildenbrand (Arm)
2026-08-26  8:11             ` Lorenzo Stoakes (ARM)
2026-08-26  8:16               ` David Hildenbrand (Arm)
2026-08-26  8:24                 ` David Hildenbrand (Arm)
2026-08-26  8:35                   ` Lorenzo Stoakes (ARM)
2026-08-26  9:10                     ` David Hildenbrand (Arm)
2026-08-26  9:21                     ` Vernon Yang
2026-08-26 11:04                       ` Lorenzo Stoakes (ARM)
2026-08-26  9:08         ` Vernon Yang
2026-08-24  9:29 ` [PATCH v3 2/3] mm: khugepaged: fix folio is used after pte_unmap_unlock() Vernon Yang
2026-08-24 11:57   ` David Hildenbrand (Arm)
2026-08-26  2:46     ` Vernon Yang
2026-08-26  7:58       ` David Hildenbrand (Arm)
2026-08-26  8:12   ` Lorenzo Stoakes (ARM)
2026-08-26  8:42     ` Lorenzo Stoakes (ARM)
2026-08-24  9:29 ` [PATCH v3 3/3] mm: khugepaged: fix folio is used after folio_put/unlock() Vernon Yang
2026-08-24 11:59   ` David Hildenbrand (Arm)
2026-08-26  2:47     ` Vernon Yang
2026-08-26  8:09   ` Lorenzo Stoakes (ARM)
2026-08-26  8:14     ` David Hildenbrand (Arm)
2026-08-26  8:23       ` Lorenzo Stoakes (ARM)
2026-08-26  8:41     ` Lorenzo Stoakes (ARM)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260824092935.73892-1-vernon2gm@gmail.com \
    --to=vernon2gm@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=nico.pache@linux.dev \
    --cc=ryan.roberts@arm.com \
    --cc=stable@vger.kernel.org \
    --cc=usama.arif@linux.dev \
    --cc=yanglincheng@kylinos.cn \
    --cc=zokeefe@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox