From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D2E5403AE6 for ; Mon, 24 Aug 2026 10:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787566159; cv=none; b=fS20CU+o7Fq42dotaWb6efCLMaK6ak4WoxY8gIrQ7zpFxcobPY3Mb0y1bUQ0z8FPh6qanqJZVMOPMKw5hH5OYdGRgIKawAXGrpIDIEcC5dYlhQrWz0XPdHz6hVC01VrPDOF6aoaPplY1Qi0FH7PAEXg7M616+fHUrm7AiINvMsU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787566159; c=relaxed/simple; bh=rt+YiZukszKHGQvjLh5hc6FPjItUlYmWlb0CsbP8AGY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UUv1St/pcrcSYlJfqUI8/HxsiM9+fBvhPPWN/ySl/6//DqXw0ld4bQuGj5IL/1TpIUK0bnSjUtsjn5nuys/1FK7E6p19SRRzrrHadtkSsxGb1fIVlmovDT+ycaEOMmOGAGSfug4ZJv8B+ltWtfZWjyEY90yxFrZKjTSqlQTvVpA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e1i+R6Go; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e1i+R6Go" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ce7d2adef4so43292725ad.3 for ; Mon, 24 Aug 2026 03:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787566157; x=1788170957; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=g8YaeJXoEsR+KIxdOfRdm9BJRSQRSpPIKEb03BqqpcM=; b=e1i+R6GotbIXlUjKFsWLRPtCIoJ/nPvcR8sX5VuiNDY/CZmwATfEeL96K6YUK66VRB BgRo0NL11QlJYXk4mNopHLHmiD6RJPOmoIWy5Cttnw/RvwIE1yZwHyWkchSKmG62KSSy QVn2Hs6r5W3K4f3zezgfnF5hZjP1zLinbf8U+P6lO0I+jeWHPettWvmVOPrvYVQZYK7+ K2oNCdopXI99l0qCHypkXok7ZI3H/8KzPKGe2evTCEUKK1bwY9jO1hzzcV7RgEFlIEC5 lGta5+OfJ0RXU3sKVpfN32ioxTixu7zTSHmppwZSoQtSpDECgK2hX+5lvqNwN3ETvlJa RkKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787566157; x=1788170957; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=g8YaeJXoEsR+KIxdOfRdm9BJRSQRSpPIKEb03BqqpcM=; b=FYgLMVlh7yr8WPF+zw02jcLFvsB45FTGqEtEYu+uOCoCAMD3g7uVccJwEk2wzfyO1S bQi5M7vaGcKf78OApP9ZbJ+0eITn6BBC30I7+zFrbgqZ55JtrACT0rp43vu6es1pzZQ0 wWMwd8gzK63owyeOKGiodH37sjwCWevrXnbjftN5+XGE5q/gS7Hg9x3LMjS2tbQrNgZI qjfbxOnoV5E3J+D+YmOCXgU47cEUlJt+/n9EgfjdRJqdbmyCCYunW/1WtWXJ97ip3Xai S9LLw+IfTYnBM9ZO2VrFX2t/3nb7fqPnqfmdQCmldmL8OjP+oKUUjOIZbwpeS5w1nthC 4FTg== X-Forwarded-Encrypted: i=1; AHgh+Rql6x/8IJAMOPME3iSeKG3kCKzh1exV9p0rh1OPIHn323G7rhML3KCb0UdLY1TQDd4rnE8mlnSympe/qEY=@vger.kernel.org X-Gm-Message-State: AFuF++mG0VxNZFyVg/R6ZLGYYrAys676C1eikvCi15nksEGCwZJPnBdY M7GK1/cZM5hFavTQQoDC7b3YWGVovQKF6uUmhLalW3TJVjUJqUTrlLWR X-Gm-Gg: AR+sD133cMF8eZ3vgX0x/YEx8jbkpa6vnEv9+hUFTF4OsNqJw/yzHJQSCmrxghHG6qv LyLcDnGBRNcUbpmZV4IuAMJeGjXsr9WRr/cqW8J1uOKRZj9+0Ma2opVK7Sh89J9B2Dn9Ol2Zz3t EvJxufnC/wN4R+ivNqby637u2wW6SycMSi15k48wr0Rb3Lr3UytRNQYQY736rrMkE0yjhhi4t0K +LYsFh2wHQPRulIxMAvQBAZm0UKEfIVTEL37dgLO4yiQHtzPK6Mz558q36FcEc1Q2Mdl8L5IEgW EZz25g4lxRa/NvSAm0PX1fjHXc2uD2jEs5u6SsoLilP3OMAQ4BhKxu/w3Z4Tzsy3FOz27zqLwZG LuFaOEaY1MAAuRH4Xv36LbYlfLtQHFudBSSldTR4eqvvVaDPPLB9cwARq65DexS5e9WkEEZUSzf UUL7aNIC3P6f2ZeEnDr1zlCRlKrethnM3aL6NvrSfVgcw7aDNRosyd2DM62OBag+phADoR8d/Mu A3diqWzDfoB5tt0OrEX+yIZ3I57hu7RkG/ueVlZHZWbGJVVEaIq4mYR7+cxCSWJQfpLvBx/JfhH SUnD X-Received: by 2002:a17:902:e802:b0:2ca:d91d:d3a7 with SMTP id d9443c01a7336-2d64b0c8bb5mr447392395ad.10.1787566156947; Mon, 24 Aug 2026 03:09:16 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d676761beasm15666115ad.5.2026.08.24.03.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 03:09:16 -0700 (PDT) From: phucduc.bui@gmail.com To: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chen-Yu Tsai , Jernej Skrabec Cc: Samuel Holland , Linus Walleij , Kees Cook , Bartosz Golaszewski , Arnd Bergmann , Stefan Roese , Maxime Ripard , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH net] net: ethernet: sun4i-emac: Fix IRQ error handling Date: Mon, 24 Aug 2026 17:09:01 +0700 Message-ID: <20260824100901.31675-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails. The current code checks for -ENXIO and therefore does not detect the failure. Check for a zero return value and convert it to -ENXIO. Fixes: 492205050d77 ("net: Add EMAC ethernet driver found on Allwinner A10 SoC's") Signed-off-by: bui duc phuc --- drivers/net/ethernet/allwinner/sun4i-emac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c index 42174249ef61..942454e29488 100644 --- a/drivers/net/ethernet/allwinner/sun4i-emac.c +++ b/drivers/net/ethernet/allwinner/sun4i-emac.c @@ -996,9 +996,9 @@ static int emac_probe(struct platform_device *pdev) /* fill in parameters for net-dev structure */ ndev->base_addr = (unsigned long)db->membase; ndev->irq = irq_of_parse_and_map(np, 0); - if (ndev->irq == -ENXIO) { + if (!ndev->irq) { netdev_err(ndev, "No irq resource\n"); - ret = ndev->irq; + ret = -ENXIO; goto out_iounmap; } -- 2.43.0