From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56E7E3515F8 for ; Mon, 24 Aug 2026 20:07:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787602074; cv=none; b=U0N7fZTB4CJS7FIv7dinHgeb6CBSKn4lUmtXx95Pu/PuSbep9PDQyyfVW0X68eUhQs6EHVaEoF/tyOhXGn8pUo/ABhyRcovI3PPeY2k9ZX3PKNJZjfvAZVKw3tZCLtyA1st6HaTwDrGpfDpavjBoaEbHDuyFo3JTIIhhY6ns9i0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787602074; c=relaxed/simple; bh=4yM/sFeVr7m7tc32JHxEfeAb8FWrpW3YgqN7edtegr4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kvpoHPL3QqWnQm/seYJMMaCKATgBOmpprZc2UqDRq6vzze3ed2LHE93E8t+oUngbykqHG67WibhbcwTj0aWPRIIeik8xqU2GPYX/hyjd7gbx7svhBYE3Ape3KxG7UoIc8ZMqa5mxGoaWV69MJotsMWllghQUcQk0vjKkRzz0el0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AcgQ4Nw8; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AcgQ4Nw8" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5b015b2d792so3775450e87.3 for ; Mon, 24 Aug 2026 13:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787602071; x=1788206871; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pxOp/lB+MXkBAiCJKeOanQBiepDI4CPw5IwKo8UCfQw=; b=AcgQ4Nw8l5MmiKUYPX5KMcYu9cSrfjDutjgTx8m7hwc0exzSsp3ynVtcSC/m6FlNXE AYV6HOFayb66XUIBuHxVY6dZCz/puBuzuSANPmTkH5oAs9BOyyBPd+ZxQBVHWT6A+Ki4 zO/TAgQbDmtqSq2xRYwTw4YOcqvgfcl34KHM/ct8A18lHLcyhti7nFwbobldmCzz+acJ Ztxsu+GjxPBS2+DD6VSgnUeDSFJBQy3fohDXhUJxOga57YEwqBbp8v5eBShNI2JhxW7M HMRMPJBCq8Iby6v0hHglUMMWd+I+LQdoHxqv/86/rJny96gDqgT0VPtb+NB3Tv5+NP5X J2PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787602071; x=1788206871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=pxOp/lB+MXkBAiCJKeOanQBiepDI4CPw5IwKo8UCfQw=; b=mO1raa3q8OuJtcwMnIeTODkS9BiX88rcsRDwUrv1Tj5iaoNx9tQBmzseAAHOVRWJJa Z8J1tsgxPbMNqquylKMKCWoZ8ntJ2v9xAKlaOOO44WHId9NdpBbk5sPXHsjfXLA3UjgV t97oEtO7yC7Sl+HQ35uaNul6B/9hUbYk966I4oC/ExTapPOJNrvi/KRr0ltZi/letWfX qudqfzdzHJRXp8XBhBVHl3+XZzdcsHK8qQNjUaFgtOVPtBqS8KTw2rwNz0jE+7SqbkBj 6msNazDGMU5KfSHGYV74ZnoavlQWntY/cWtpwxUUoOEmrnoGX7VKualE+tE7b0ZNAKBT RyhQ== X-Forwarded-Encrypted: i=1; AHgh+Rq3Pqrg+rVK7wqNkaK8GjO6WONrGL3pamIjUH73uNlItTsDXqhq0+MSjUagnILp1LaflwyTyL6PcjIlFNw=@vger.kernel.org X-Gm-Message-State: AFuF++mdRvELnLOKEsT+Mfb9A1Qp0+bLGp6PKyL+IYBs7Ypjiu/3FnJq 0Flhkj4aXsOUJKvSQ2lr5Un4WoRGBYBJlKPYLtBPUiG4/SYzYhnQ9EN3 X-Gm-Gg: AR+sD12R83fAdeqKb+Rhq7jijFj0rq5NstaTUy3M6wOO3QdHePV4W/XAg6wkY6XjzG4 LEZ8k8pgNk5pacSBmiWrzxLqQKGfnN+I/F6D2LWV8RyYDlRPz0YvlD+Tz5K01kfJv2uqYN8RmPR NOUXMZliPCXU2BMcgDAPk6zW6jCwpZq9/00mOvwLS3QzhNcIVc2bpoyMouiV+QDQM+Dypf7rurW y84eUfkyNCGIa8xFhj0KzEmTgFDb/yVZL3kagwQpU1EdzWq1dxes4FFajNKQhca6Hcv5oDvD01j ZUX6liNql7djVm7G/oNw0gmoD8oDi0smJspZp998qw9fxIEJwuK+q8pFtz7/DYcvBxhTR1UjgtT DLwngMetp3KsK8x7KXhBbB5wV2Eu8+d4Xdpe1OuHPh3ToRtuPI+JPlzAXoj47RxKkVg/59kHzPX +38OOk5gxWpXVtyctzHNUG7ZnlRP9viifVDCjM88JBJ+KeasK8I83u8SiwegUqg+QmjjbO/Jpcd r6jsh0C4rk6nQDlWpBfobCvfCSZwDyVmDJqx5HqhtZ3VH5duybwBMuWhes= X-Received: by 2002:a05:6512:8381:b0:5b0:23b4:be97 with SMTP id 2adb3069b0e04-5b48421a625mr7340848e87.6.1787602071055; Mon, 24 Aug 2026 13:07:51 -0700 (PDT) Received: from yantra.. (dsl-trebng21-58c187-236.dhcp.inet.fi. [88.193.135.236]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b48ce069adsm1914745e87.59.2026.08.24.13.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 13:07:50 -0700 (PDT) From: Rupesh Majhi To: jic23@kernel.org Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Eddie James , Joel Stanley , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/3] iio: pressure: dps310: add triggered buffer support Date: Mon, 24 Aug 2026 22:52:54 +0300 Message-ID: <20260824200456.393895-1-zoone.rupert@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260823001914.224aba09@jic23-huawei> References: <20260817170725.1074078-3-zoone.rupert@gmail.com> <20260823001914.224aba09@jic23-huawei> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, 23 Aug 2026 00:19:14 +0100 Jonathan Cameron wrote: > Use the sparse markings to make it clear and testable - thus not needing the > comment. __must_hold(&data->lock) Patch 6 opts dps310.o into the analysis, so they are checked and not just documentation. Clean under clang 23.1.0, and it does run: dropping the lock around dps310_fill_scan() fails the build. Patch is last and touches only the Makefile, so drop it if IIO would rather not opt in yet. > It isn't necessary to use guard/scoped_guard() for all locks in a driver > if they actually hurt readability. I think that is the case here. Plain lock and unlock in the trigger handler and in the FIFO work. Kept guard() in the three places where the lock covers a whole function. Rupesh