From: Rob Herring <robh@kernel.org>
To: zhaoguohan@kylinos.cn
Cc: Tomeu Vizoso <tomeu@tomeuvizoso.net>,
dri-devel@lists.freedesktop.org, Oded Gabbay <ogabbay@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Frank Li <Frank.Li@nxp.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] accel/ethosu: check MMIO mapping errors in probe
Date: Mon, 24 Aug 2026 16:49:53 -0500 [thread overview]
Message-ID: <20260824214953.GB50486-robh@kernel.org> (raw)
In-Reply-To: <20260716065219.931088-1-zhaoguohan@kylinos.cn>
On Thu, Jul 16, 2026 at 02:52:19PM +0800, zhaoguohan@kylinos.cn wrote:
> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
>
> devm_platform_ioremap_resource() returns an error pointer when the register
> resource cannot be mapped. ethosu_probe() stores it and continues until
> initialization dereferences it through MMIO accessors.
>
> Return the mapping error before initializing the device.
>
> Fixes: 5a5e9c0228e6 ("accel: Add Arm Ethos-U NPU driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>
> ---
> drivers/accel/ethosu/ethosu_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied, thanks.
Rob
prev parent reply other threads:[~2026-08-24 21:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 6:52 [PATCH] accel/ethosu: check MMIO mapping errors in probe zhaoguohan
2026-08-24 21:49 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260824214953.GB50486-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomeu@tomeuvizoso.net \
--cc=tzimmermann@suse.de \
--cc=zhaoguohan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox