From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail3-165.sinamail.sina.com.cn (mail3-165.sinamail.sina.com.cn [202.108.3.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D0C517A314 for ; Tue, 25 Aug 2026 06:25:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.108.3.165 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787639156; cv=none; b=YbLKcmkL8RgsAd1aJi7ODb1M/WvuNovFsy00FJYzPxihDvME45eg8GzlI1MRhxcFkG8gcaCxLfU/EY4MAoCqQmoNrk3VG7eErdGHelJ+tbSV0Jk+u8Eiw/rjoNIjQvhB513X2MAQuVKfLFkQALjyCHwW+caaGbET6ZjsNxcklU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787639156; c=relaxed/simple; bh=dUMSqSVcFGMunPYmuhY7MzZq9ngfehg9Fdxl2QXuk10=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sFP62iyZi9w22ldTOmO//Q7NdbQoIRy35rDNAV2tHu/5uaLuRRA1HHSB8MHAePXwtoVCfBcbk4v2T941u+it+udtQSWxI+pqBqFIsLOJmeeC5EosTaI+2AkmSpkZnlInZxDH4tlyv6+uawAlldJ/SnrjXX6Cyn4WwtmLgdyan5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b=Y/CX0q+T; arc=none smtp.client-ip=202.108.3.165 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b="Y/CX0q+T" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sina.com; s=201208; t=1787639152; bh=7bAYI7eCw/MYQdq1y7RwqclS0q/FhTPCE9GWfgseLNM=; h=From:Subject:Date:Message-ID; b=Y/CX0q+TQPb7bVywN8bJRyvHO/j/ynn47Di8EKdgNPJH/M3ul8xp8pK45lhWtls2b oR1bS0b5HuEb+BLuGQl47CrkOBF1wEHtt2lCnRvxGCTPU8nBbRyAPx5Wv1g7iBeRbD mcrvzW6KWXHKDj7yMIGTkk/+9ywlby8HNxruiDow= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([114.249.62.194]) by sina.com (10.54.253.33) with ESMTP id 6A8D355C00002E70; Tue, 25 Aug 2026 14:25:40 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 3155476685210 X-SMAIL-UIID: E802616010994DC8BD3B85AEC7EE0424-20260825-142540-1 From: Hillf Danton To: Shin'ichiro Kawasaki Cc: Eric Dumazet , syzbot , Nilay Shroff , Keith Busch , boqun@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, peterz@infradead.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [net?] WARNING: locking bug in tcp_tsq_handler Date: Tue, 25 Aug 2026 14:25:21 +0800 Message-ID: <20260825062523.1481-1-hdanton@sina.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 25 Aug 2026 14:44:35 +0900 Shin'ichiro Kawasaki wrote: > On Aug 25, 2026 / 03:50, Eric Dumazet wrote: > > > > I think 19bdb70c77d3 should be reverted. > > Just reverting the commit will reintroduce the other lockdep WARN that the > commit addressed. I hope to have another fix to avoid the WARN. > I do not think you know the root cause of that lockdep warn, so reverting 19bdb70c77d3 is the right thing to do because of [11, 12]. [11] ffa1e7ada456 ("block: Make request_queue lockdep splats show up earlier") [12] Subject: Re: [PATCH] nbd: don't warn when reclassifying a busy socket lock Subject: Re: [PATCH] nbd: don't warn when reclassifying a busy socket lock