From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69CAC3921E9
	for <linux-kernel@vger.kernel.org>; Tue, 25 Aug 2026 06:53:44 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1787640825; cv=none; b=uyPCGaCi+pNesCzE90e3/h6L6WUA/q/cyE/kxF5tm5f62oS0Nit5lXfOnRd7QpI3wucj7ZU0DDfmI02Ftm0Xu0I42bgv2UJetWh6y05WLMnc3p3QLP6kzlKI0QO9w3+u7dllsOQg/PC8VSaf7SMXHegHc/IZr+QCI7YfY2ZDhxc=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1787640825; c=relaxed/simple;
	bh=kolpvy6cqz/cwwKZH4CBWkCTDaE0+4wlU+COtNMOULc=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=G8wvUsz+zTKymdJ4GIK9u1Z58E7CVcDk3IP8blEyqx8EaLtTHnHXelRkjAuDvDynuQeuTu11y6aP5MF5l+EFaRHhn+irbt312fsD0uc0+U2H57RNVNR1J3eRojk5u12Pxqrd/jRHd1ZKnH1R7SyFpwfZBc84K9ts8VPSIsfxkcY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=rSlvhS/i; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=wxW1vFPX; arc=none smtp.client-ip=193.142.43.55
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="rSlvhS/i";
	dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="wxW1vFPX"
Date: Tue, 25 Aug 2026 08:53:40 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1787640822;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=CWCoIsXVouPCHxajw7YngQHQGthSsKgjpstaA17Y3Ac=;
	b=rSlvhS/ixxEH3ODwHognwCN8ZTbEHksGpJrj2K4KCGX2HOogLZiNbfwdJRd/DEeyeeaGVd
	AYyHpmYdPRrsYPbjb2C4MXkhWr3ULUvI1D5xAZAeqLJg+oJ4AUlzoK1mFCeE33DVgm8eFu
	Ixgi9OM80Cp60YGKGglxKMq71EuTG1UKNPCW8mSDwvFoYUq+sda9M69XHamSt8jVIkoISe
	kybrBHmvX4xEPPvOEhYo4YIAjrrPpcaOzRl7ZHOrN0fUc9s/xuoAyo4FRQcXq1nprKAD13
	35yujVGlUyV/b4jF6v1Cj7sOeywFy27r7qKnvrxjy+YtLzG3XfuLcmIjG/1g+g==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1787640822;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=CWCoIsXVouPCHxajw7YngQHQGthSsKgjpstaA17Y3Ac=;
	b=wxW1vFPXbPiaYubHvaCI7IAXi5fhMUer1HWmyj1Dxjao4J3O81bkW3gEy3//5iB1YBXvga
	0vlhwYIaAEEci3DA==
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Enlin Mu <enlin.mu@linux.dev>
Cc: peterz@infradead.org, tglx@kernel.org, boqun@kernel.org,
	lyude@redhat.com, joelagnelf@nvidia.com,
	linux-kernel@vger.kernel.org, enlin.mu@unisoc.com
Subject: Re: [PATCH v2] softirq: Remove redundant h->action from
 preempt_count mismatch error
Message-ID: <20260825065340.PBy31xfe@linutronix.de>
References: <20260825011509.8505-1-enlin.mu@linux.dev>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20260825011509.8505-1-enlin.mu@linux.dev>

On 2026-08-25 09:15:09 [+0800], Enlin Mu wrote:
> When a preempt_count mismatch is detected in handle_softirqs(), the
> error message currently prints the softirq action handler (h->action).
> 
> However, as Thomas Gleixner pointed out, the action handler for a given
> softirq vector is always a known, fixed function (e.g., run_timer_softirq
> for TIMER_SOFTIRQ). Printing it provides zero diagnostic value. The real
> issue typically lies in the functions invoked *within* that handler, not
> the handler entry point itself.
> 
> Therefore, as suggested by Sebastian Andrzej Siewior, remove h->action
> from the print statement entirely to clean up the error message.
> 
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Enlin Mu <enlin.mu@unisoc.com>
> Signed-off-by: Enlin Mu <enlin.mu@linux.dev>

Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Sebastian