From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ADF03F0767 for ; Tue, 25 Aug 2026 09:25:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787649959; cv=none; b=BZRnqvSWhhYLGR35OeCUqWEVbxYWTwDClqPMRY+Jr1iLuMbDJnKsVnDxltOu/GLObaeFAOwrQOfXfgoxh06huHQP+o/gPGKDyk8xMEGufb+oLtAlHYF+4anSyDsn2D7nVjibKBsfJkB0X6e3etfd/mF3hXQNc6mWlCwqggNq/4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787649959; c=relaxed/simple; bh=gNbMxqUlA6wa4NuZncaIpEqWzCwySUvzyrK2sISa1Ng=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KkDnSGvlu/ni6dN8rPMMxNDR8GuaC+33wTA/JpG9FU8GQI4A2QcD8E4EcSSZBPMSfxMgQqvhOd2HKtqeGyPIE2vTj0Dd8OkIMH0ogsepIRxLBtXM9hWkBuuGJnOUebHJ6W5BF/wIngTZ3q4ff0vRjLMszq+aSxCtTROvUfeyTwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UqlKnHX1; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UqlKnHX1" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-6a36982a875so6763610a12.0 for ; Tue, 25 Aug 2026 02:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787649955; x=1788254755; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=j2rSGrpetz4sib6pgIqVxIKVNTVPOp3P2Cb6kEKa91o=; b=UqlKnHX1wSj25cS5angTIDbbehrqU22GyODjgeQyvc7pkKXFnOqPGhsVQIhPparGME +YW0JZwzvfTfKGcwgIdCZjdtn22gNm5PNuhDPToBE+YrvURsegUYRWZyc/Qpp20HIjMl 83iGeu0Tm7gOkRcpwg4GUx0rQPI78UKv8RKrBlYiJWQx/OmghIpSYaL1Q6vQz4BnYRb7 fbSzghmzS2pe1kWG4Q3UI9vKS4E+lSFyf1E9EPeYX3looAf9KPluSod409oonmEPMm24 zaplVCFMj8Yu4WQ9reWt5id3WHP2kARGB+3XNXdnZ2qbWRfrduAy2OERr/T0aUAkST6/ Wh7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787649955; x=1788254755; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=j2rSGrpetz4sib6pgIqVxIKVNTVPOp3P2Cb6kEKa91o=; b=emgbfoqPAUksgygxXP1EAuryb7mssUd4wJG9Iv+PkkWozVa0W9IaycjG+pZ4XtdJzb oL0XJm+Xj7c7qxX0YBrTcq/34CYogVXJGL95TLX3ZbJCxjfDf7iRErvOjZRp8jLMTcGE MiLXHSIjxugG0/a12d7QTe3HVI5sXxkheHvcC7UqyGPmQ0bF3cpDULUSoa4wYN2bKD3D yow5EaoRdPwEw3NGXiIjH489+Wpr5vqSl+DErdct4h7j/yTrB3SMihFpxDugvNh3riQF cROgF8JIVHuEQ/2v5sOpxPEAz1yXXuc7j9vRFvARPhn3iJc07IUg3ZwG/x3e2CtZ9pXV cBlA== X-Forwarded-Encrypted: i=1; AHgh+Rr0yw/CzXD+4e0UDWuZAAekslSvEZyfVai/uINUi5xsetRzK0lngVj+IKdZh5ZaiJ9ub1H+byYR7xOxDBM=@vger.kernel.org X-Gm-Message-State: AFuF++kl+wT59mUnxDm271TjmzuYF1QoZTs3/jsyzTMwsr6OR6j+MN5C 7PuiKyzBPJ4//hwTrs/yglmk13nMEsL8mxxoUMwPvA6uBneDvvE9pxksXiVoAQ== X-Gm-Gg: AR+sD135cGcJi7cO5a3RsqgGZq1y+y0LgZk+P5v1eILZHaid3cLytWkUwnndlGsKlYY KbR4fIWG9A4qmLrRvKOsRctJXE+9ymYqlBhbLs4GsEwnS37HKAPCGgQmGUKSlM4FfEZhx2fjWjt L2FtGKr6n5M2z9Bi3sctGAQb9hIbApJsIPeJ12i9XTkPgZ4RbhL8P30zsmS0fNvmGpN50KcWmxg sG09lO7sKRBMmexfgZQ0dGLNxXxebsMK4R3ha3YR+/28iV2tq9arcOJi/5YbjuCXrT4gAkWzzDP 8aebPHhXR7/Ua6Edrt4OzsJ8G+s1jI2cEeV8q9vFC4kXFaBrY61f1cwmMONMWMtgx43+jZXOQw0 hGNuONNoaomvagQ3m06L2Unsjr5Wc+Xaitq3kBrJ9ZfdrPSXCC4VdwKHwS7dYx/iJ6TxguePn1H EzvwrM16/Cmza07/OmWCwRe1Q8uSr18hm7G1Vl0uiVN1w3tFB4FzV9LmZ/mnO+8DRObaFQ3jl/z DTsLo4KfXEQ/AljEX4s0D6DnG81YNYIMd2JTIPfKVKlDAxgbseU/e880tHmg60MnQBNWJYUwPZW 68R8EP3883NdQmQ4BTH8if5pIhsiDjDw/Q== X-Received: by 2002:a17:907:934d:b0:c20:9447:bd5e with SMTP id a640c23a62f3a-c246a5f6d65mr3680207766b.9.1787649954768; Tue, 25 Aug 2026 02:25:54 -0700 (PDT) Received: from fractal.tuxedo-gray.ts.net (c-78-82-25-228.bbcust.telenor.se. [78.82.25.228]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c249606bd05sm1612570866b.2.2026.08.25.02.25.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 02:25:54 -0700 (PDT) From: Johan Dahlin To: Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Dahlin Subject: [PATCH 0/5] hwmon: (nct6683) Fan control for ASRock B850 Steel Legend WiFi Date: Tue, 25 Aug 2026 11:25:41 +0200 Message-ID: <20260825092546.669450-1-jdahlin@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fan control does not work on an ASRock B850 Steel Legend WiFi (NCT6686D, EC firmware 1.0 build 10/29/24). The driver does not recognise the board's customer ID, so it only probes with force=1. Its pwm attributes are then read-only, and even once writable the EC ignores them until the fan is put in manual mode through register 0xa00, which the driver does not expose. Writes that do get through are sometimes silently discarded, because the settling delay in store_pwm() is too short on this firmware. This series fixes those one at a time. Patch 1 stands on its own: a write that succeeds on the first attempt issues the same register sequence as today, so boards that work now are unaffected. The fan control changes are exposed on verified boards only. With the whole series applied, all six fans report and pwm[1-6]_enable read 2 after probe: fan1: 815 RPM fan2: 631 RPM fan5: 386 RPM fan6: 354 RPM With pwm5 in manual mode: written applied fan5 60 60 337 RPM 100 100 443 RPM 150 150 627 RPM 200 200 794 RPM 255 255 933 RPM Writing 2 back returns the fan to the EC, as does unloading the driver. Without patch 1, two of six writes were lost and the fan kept following its previous value. Each patch was also built individually. I have no access to Mitac, MSI or Intel hardware. Johan Dahlin (5): hwmon: (nct6683) Retry pwm writes until they take effect hwmon: (nct6683) Add customer ID for ASRock B850 Steel Legend WiFi hwmon: (nct6683) Add pwm[1-8]_enable hwmon: (nct6683) Restore fan control mode on driver removal hwmon: (nct6683) Enable pwm control on ASRock B850 Steel Legend WiFi Documentation/hwmon/nct6683.rst | 7 ++ drivers/hwmon/nct6683.c | 124 +++++++++++++++++++++++++++++--- 2 files changed, 122 insertions(+), 9 deletions(-) -- 2.53.0