From: Tao Cui <cui.tao@linux.dev>
To: axboe@kernel.dk
Cc: hch@lst.de, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, cui.tao@linux.dev,
Tao Cui <cuitao@kylinos.cn>
Subject: [PATCH 2/3] loop: replace simple_strtol() with kstrtoint()
Date: Tue, 25 Aug 2026 20:57:19 +0800 [thread overview]
Message-ID: <20260825125720.181793-3-cui.tao@linux.dev> (raw)
In-Reply-To: <20260825125720.181793-1-cui.tao@linux.dev>
From: Tao Cui <cuitao@kylinos.cn>
simple_strtol() is deprecated and swallows errors. Use kstrtoint()
in the max_loop setup code; an invalid option keeps the default and
now says so.
Signed-off-by: Tao Cui <cuitao@kylinos.cn>
---
drivers/block/loop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 68a9cc7aeb13..8ba146e76a59 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -2341,7 +2341,8 @@ module_exit(loop_exit);
#ifndef MODULE
static int __init max_loop_setup(char *str)
{
- max_loop = simple_strtol(str, NULL, 0);
+ if (kstrtoint(str, 0, &max_loop))
+ pr_warn("loop: invalid max_loop, keeping default\n");
#ifdef CONFIG_BLOCK_LEGACY_AUTOLOAD
max_loop_specified = true;
#endif
--
2.43.0
next prev parent reply other threads:[~2026-08-25 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 12:57 [PATCH 0/3] loop: three small cleanups Tao Cui
2026-08-25 12:57 ` [PATCH 1/3] loop: drop a stale reference to loop_validate_size() Tao Cui
2026-08-25 12:57 ` Tao Cui [this message]
2026-08-25 12:57 ` [PATCH 3/3] loop: drop the unused argument of lo_req_flush() Tao Cui
2026-08-25 22:29 ` [PATCH 0/3] loop: three small cleanups Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825125720.181793-3-cui.tao@linux.dev \
--to=cui.tao@linux.dev \
--cc=axboe@kernel.dk \
--cc=cuitao@kylinos.cn \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox