From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: David Howells <dhowells@redhat.com>,
Paulo Alcantara <pc@manguebit.org>,
netfs@lists.linux.dev, linux-afs@lists.infradead.org,
linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/9] netfs, cachefiles: Miscellaneous fixes
Date: Tue, 25 Aug 2026 14:20:34 +0100 [thread overview]
Message-ID: <20260825132045.1000787-1-dhowells@redhat.com> (raw)
Hi Christian,
Here are some miscellaneous fixes for netfslib and one for cachefiles, if
you could pick them up?
The first six are all in unbuffered/DIO write:
(1) Fix an uninitialised return value from netfs_unbuffered_write().
(2) Fix the normal error return, preferring partial transfer size over
request error over immediate error (e.g. EINTR).
(3) Fix the async error return, preferring partial transfer size over
error.
(4) Fix the update of i_size on partial transfer ending in an error.
(5) Fix a subrequest leak in an error path.
(6) Fix the code to handle subrequest allocation failure.
Then there's:
(7) Fix synchronisation issues with using a progressive rolling buffer for
readahead by fetching everything into it upfront so that the issues
don't arise. Dropping the refs so acquired is deferred until after
I/O is begun.
(8) Fix read progress reporting to avoid 64-bit tearing on a 32-bit
machine. This has been modified from the previous submission as part
of a different series to take account of a sashiko reported issue[1].
(9) Fix a potential UAF/KASAN warning reported by sashiko[1] in cachefiles
in which the coherency data buffer is cast to a __be64* and
dereferenced in a tracepoint - even though it might not be at least
that large (or aligned).
The patches can also be found here:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes
Thanks,
David
Changes
=======
ver #2)
- Imported a patch to add subreq alloc failure handling in unbuffered/DIO
write.
- Fixed a number of issues reported by Sashiko[2]:
- Added four patches to fix bugs in unbuffered/DIO write.
- Added a patch to fix readahead rolling buffer issues.
- Fixed the cachefiles xattr stuff to use max() not min() when
allocating.
- Fixed the cachefiles trace comment with regard to alignment.
- Fixed netfs_read_set_unlock_at() to use folioq_count(), not
folio_nr_slots().
[1] https://sashiko.dev/#/patchset/20260810144746.574036-1-dhowells%40redhat.com
[2] https://sashiko.dev/#/patchset/20260824120224.504575-1-dhowells%40redhat.com
David Howells (7):
netfs: Fix unbuffered/DIO write partial transfer error return
netfs: Fix error vs transferred passed to ->ki_complete()
netfs: Fix i_size update for partial transfer
netfs: Fix subreq ref leak
netfs: Fix readahead synchronisation issues by loading all folios
upfront
netfs: Fix read progress reporting
cachefiles: Fix potential UAF/KASAN warning
Edward Adam Davis (1):
netfs: break unbuffered write when netfs_alloc_subrequest() fails
Karl Mehltretter (1):
netfs: Fix uninitialized return value in netfs_unbuffered_write()
fs/cachefiles/xattr.c | 16 ++---
fs/netfs/buffered_read.c | 103 ++++++++++++++++++------------
fs/netfs/direct_write.c | 30 +++++----
fs/netfs/internal.h | 2 +
fs/netfs/misc.c | 19 ++++++
fs/netfs/objects.c | 32 ++++++----
fs/netfs/read_collect.c | 65 +++++++++++++++----
fs/netfs/read_retry.c | 7 ++
fs/netfs/read_single.c | 2 +
fs/netfs/rolling_buffer.c | 81 ++++++++++++++---------
fs/netfs/write_issue.c | 2 +
include/linux/netfs.h | 3 +-
include/linux/rolling_buffer.h | 6 +-
include/trace/events/cachefiles.h | 19 +++++-
include/trace/events/netfs.h | 24 +++++++
15 files changed, 291 insertions(+), 120 deletions(-)
next reply other threads:[~2026-08-25 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 13:20 David Howells [this message]
2026-08-25 13:20 ` [PATCH v2 1/9] netfs: Fix uninitialized return value in netfs_unbuffered_write() David Howells
2026-08-25 13:20 ` [PATCH v2 2/9] netfs: Fix unbuffered/DIO write partial transfer error return David Howells
2026-08-25 13:20 ` [PATCH v2 3/9] netfs: Fix error vs transferred passed to ->ki_complete() David Howells
2026-08-25 13:20 ` [PATCH v2 4/9] netfs: Fix i_size update for partial transfer David Howells
2026-08-25 13:20 ` [PATCH v2 5/9] netfs: Fix subreq ref leak David Howells
2026-08-25 13:20 ` [PATCH v2 6/9] netfs: break unbuffered write when netfs_alloc_subrequest() fails David Howells
2026-08-25 13:20 ` [PATCH v2 7/9] netfs: Fix readahead synchronisation issues by loading all folios upfront David Howells
2026-08-25 13:20 ` [PATCH v2 8/9] netfs: Fix read progress reporting David Howells
2026-08-25 13:20 ` [PATCH v2 9/9] cachefiles: Fix potential UAF/KASAN warning David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825132045.1000787-1-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=christian@brauner.io \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox