The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Khawar Ahemad <ahemadkhawar123@gmail.com>
To: daniel@iogearbox.net
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, magnus.karlsson@intel.com,
	maciej.fijalkowski@intel.com, sdf@fomichev.me, ast@kernel.org,
	kuba@kernel.org, pabeni@redhat.com,
	syzbot+aa48b5fe7bfda62d1682@syzkaller.appspotmail.com
Subject: Re: [PATCH bpf-next] xsk: Fix circular locking dependency in xsk_bind
Date: Tue, 25 Aug 2026 21:12:54 +0530	[thread overview]
Message-ID: <20260825154254.86328-1-ahemadkhawar123@gmail.com> (raw)
In-Reply-To: <20260825152152.86092-1-ahemadkhawar123@gmail.com>

Hi Daniel,

Thank you for the quick review and pointer. You are completely right —
I missed that xsk_notifier() calls xp_clear_dev() while holding xs->mutex,
which acquires netdev_lock_ops() internally.

Please drop this patch. I will step back and do a more thorough analysis
of the full locking design between xs->mutex, net->xdp.lock, and
xp_clear_dev().

Thanks,
Khawar Ahemad <ahemadkhawar123@gmail.com>

  parent reply	other threads:[~2026-08-25 15:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25 15:21 [PATCH bpf-next] xsk: Fix circular locking dependency in xsk_bind Khawar Ahemad
2026-08-25 15:39 ` Daniel Borkmann
2026-08-25 15:42 ` Khawar Ahemad [this message]
2026-08-25 16:21 ` bot+bpf-ci
2026-08-25 20:07 ` [syzbot ci] " syzbot ci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260825154254.86328-1-ahemadkhawar123@gmail.com \
    --to=ahemadkhawar123@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=syzbot+aa48b5fe7bfda62d1682@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox