From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cheng Lingfei <chenglingfei@foxmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Felipe Balbi <balbi@kernel.org>, Peter Chen <peter.chen@nxp.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] usb: gadget: goku_udc: move debug output to debugfs
Date: Wed, 26 Aug 2026 11:25:46 +0200 [thread overview]
Message-ID: <2026082625-stoneware-trailside-ff19@gregkh> (raw)
In-Reply-To: <tencent_D7673CCE71B03F2C90CD60873AB4A245D808@qq.com>
On Wed, Aug 26, 2026 at 05:15:06PM +0800, Cheng Lingfei wrote:
> goku_udc exposes diagnostic state through /proc/driver/udc. The single
> global proc entry collides when more than one controller is probed and
> triggers a proc registration warning.
>
> The data is intended only for debugging and is not a userspace ABI. Move it
> under the USB debugfs root and use the PCI device name for a per-device
> directory. Create the file only after the UDC has been registered.
>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Link: https://lore.kernel.org/2026082616-glue-atlas-0cfd@gregkh
> Assisted-by: Codex:gpt-5.6
> Signed-off-by: Cheng Lingfei <chenglingfei@foxmail.com>
> ---
> drivers/usb/gadget/udc/goku_udc.c | 47 +++++++++++++++++++++++++++------------
> drivers/usb/gadget/udc/goku_udc.h | 5 ++++-
> 2 files changed, 37 insertions(+), 15 deletions(-)
Slow down please. There's no rush here at all, and by flooding us with
new revisions it doesn't actually allow anyone to review previous ones,
AND it shows you are just pumping out LLM-generated stuff without all
that much thought.
Please wait a few days at the very least before doing new versions of
patch sets.
As pennance, please go and review some outstanding USB patches on the
mailing list, to reduce our review load :)
thanks,
greg k-h
next prev parent reply other threads:[~2026-08-26 10:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260826-b4-fix-usb-v3-0-b28366e817f3@foxmail.com>
2026-08-26 9:15 ` [PATCH v3 1/2] usb: gadget: goku_udc: move debug output to debugfs Cheng Lingfei
2026-08-26 9:25 ` Greg Kroah-Hartman [this message]
2026-08-26 10:49 ` Cheng Lingfei
2026-08-26 9:27 ` Greg Kroah-Hartman
2026-08-26 9:15 ` [PATCH v3 2/2] usb: gadget: goku_udc: fix kobject warning on probe failure Cheng Lingfei
2026-08-26 9:27 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026082625-stoneware-trailside-ff19@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=chenglingfei@foxmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox