The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Yosry Ahmed <yosry@kernel.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Jim Mattson <jmattson@google.com>,
	Maxim Levitsky <mlevitsk@redhat.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yosry Ahmed <yosry@kernel.org>,
	stable@vger.kernel.org
Subject: [PATCH v3 01/27] KVM: nSVM: Flush the TLB after forcefully leaving nested
Date: Mon, 12 Oct 2026 23:36:12 +0000	[thread overview]
Message-ID: <20261012233638.2546339-2-yosry@kernel.org> (raw)
In-Reply-To: <20261012233638.2546339-1-yosry@kernel.org>

KVM flushes the TLB on nested VM-Enter and nested VM-Exit, but not when
forcefully leaving nested. In this case, L2 TLB entries can leak into
L1. Flush the TLB after forcefully exiting L2, similar to nested
VM-Exits.

Note that vmx_leave_nested() handles this correctly, as it reuses
nested_vmx_vmexit(), which handles the necessary TLB flushes on an L2 ->
L1 transition.

Cc: stable@vger.kernel.org
Signed-off-by: Yosry Ahmed <yosry@kernel.org>
---
 arch/x86/kvm/svm/nested.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c
index af0ef678433d7..2bfc9d2c341b1 100644
--- a/arch/x86/kvm/svm/nested.c
+++ b/arch/x86/kvm/svm/nested.c
@@ -1558,6 +1558,8 @@ void svm_leave_nested(struct kvm_vcpu *vcpu)
 
 		svm_switch_vmcb(svm, &svm->vmcb01);
 
+		nested_svm_transition_tlb_flush(vcpu);
+
 		nested_svm_uninit_mmu_context(vcpu);
 		vmcb_mark_all_dirty(svm->vmcb);
 
-- 
2.56.0.385.gd3acb90ef8-goog


  reply	other threads:[~2026-10-12 23:36 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 23:36 [PATCH v3 00/27] KVM: nSVM: Optimize nSVM TLB flushes Yosry Ahmed
2026-10-12 23:36 ` Yosry Ahmed [this message]
2026-10-14 15:02   ` [PATCH v3 01/27] KVM: nSVM: Flush the TLB after forcefully leaving nested Jim Mattson
2026-10-14 15:18     ` Yosry Ahmed
2026-10-16 19:32       ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 02/27] KVM: SVM: Document number of ASIDs CPUID setting Yosry Ahmed
2026-10-14 15:07   ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 03/27] KVM: VMX: Generalize VPID allocation to be vendor-neutral Yosry Ahmed
2026-10-14 18:22   ` Jim Mattson
2026-10-14 20:38     ` Yosry Ahmed
2026-10-16 19:34       ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 04/27] KVM: x86/mmu: Support specifying reserved TLB tags Yosry Ahmed
2026-10-14 21:49   ` Jim Mattson
2026-10-14 22:07     ` Yosry Ahmed
2026-10-12 23:36 ` [PATCH v3 05/27] KVM: SVM: Add helpers to set/clear ASID flush in VMCB Yosry Ahmed
2026-10-14 22:00   ` Jim Mattson
2026-10-14 22:03     ` Yosry Ahmed
2026-10-14 22:22       ` Jim Mattson
2026-10-14 22:25         ` Yosry Ahmed
2026-10-14 22:32           ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 06/27] KVM: SVM: Fallback to flush everything if FLUSHBYASID is not available Yosry Ahmed
2026-10-14 22:45   ` Jim Mattson
2026-10-14 22:50     ` Yosry Ahmed
2026-10-14 23:27       ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 07/27] KVM: SEV: Do ASID initialization at VMCB initialization Yosry Ahmed
2026-10-14 23:31   ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 08/27] KVM: SEV: Expose sev_get_asid() outside of sev.c Yosry Ahmed
2026-10-14 23:33   ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 09/27] KVM: SEV: Explicitly initialize the per vCPU ASID on SEV VM migration Yosry Ahmed
2026-10-14 23:35   ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 10/27] KVM: SVM: Use a static ASID per vCPU Yosry Ahmed
2026-10-12 23:36 ` [PATCH v3 11/27] KVM: SVM: Only flush the fallback ASID when used by a different vCPU Yosry Ahmed
2026-10-15 21:44   ` Jim Mattson
2026-10-15 22:03     ` Yosry Ahmed
2026-10-16 19:36       ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 12/27] KVM: nSVM: Drop svm->nested.initialized Yosry Ahmed
2026-10-15 21:48   ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 13/27] KVM: nSVM: Add a placeholder ASID for L2 Yosry Ahmed
2026-10-15 21:55   ` Jim Mattson
2026-10-15 22:10     ` Yosry Ahmed
2026-10-15 22:21       ` Jim Mattson
2026-10-15 22:27         ` Yosry Ahmed
2026-10-12 23:36 ` [PATCH v3 14/27] KVM: x86: hyper-v: Rename kvm_hv_vcpu_purge_flush_tlb() Yosry Ahmed
2026-10-15 21:58   ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 15/27] KVM: x86: hyper-v: Allow purging all TLB flush FIFOs Yosry Ahmed
2026-10-15 22:02   ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 16/27] KVM: nSVM: Flush both L1 and L2 ASIDs on KVM_REQ_TLB_FLUSH Yosry Ahmed
2026-10-15 22:05   ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 17/27] KVM: nSVM: Always switch VMCB before leaving guest mode Yosry Ahmed
2026-10-15 22:08   ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 18/27] KVM: nSVM: Split nested_svm_transition_tlb_flush() into entry/exit fns Yosry Ahmed
2026-10-15 22:10   ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 19/27] KVM: nSVM: Service local TLB flushes before nested transitions Yosry Ahmed
2026-10-15 22:19   ` Jim Mattson
2026-10-15 22:34     ` Yosry Ahmed
2026-10-16 19:39       ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 20/27] KVM: x86: Add KVM_REQ_MMU_SYNC_ALL_ROOTS Yosry Ahmed
2026-10-15 22:24   ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 21/27] KVM: nSVM: Handle nested TLB flush requests through TLB_CONTROL Yosry Ahmed
2026-10-15 22:33   ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 22/27] KVM: nSVM: Flush the TLB if L1 changes L2's ASID in vmcb12 Yosry Ahmed
2026-10-15 23:09   ` Jim Mattson
2026-10-15 23:20     ` Yosry Ahmed
2026-10-15 23:50       ` Jim Mattson
2026-10-15 23:56         ` Yosry Ahmed
2026-10-16 19:24           ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 23/27] KVM: nSVM: Do not reset TLB_CONTROL in vmcb02 on nested VM-Enter Yosry Ahmed
2026-10-15 23:16   ` Jim Mattson
2026-10-15 23:22     ` Yosry Ahmed
2026-10-12 23:36 ` [PATCH v3 24/27] KVM: nSVM: Flush L2's ASID when emulating INVLPGA Yosry Ahmed
2026-10-15 23:37   ` Jim Mattson
2026-10-15 23:42     ` Yosry Ahmed
2026-10-16  0:53       ` Sean Christopherson
2026-10-16 19:41         ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 25/27] KVM: nSVM: Flush the ASID on nested transitions if shared by L1 and L2 Yosry Ahmed
2026-10-15 23:42   ` Jim Mattson
2026-10-12 23:36 ` [PATCH v3 26/27] KVM: nSVM: Use different ASIDs for " Yosry Ahmed
2026-10-16 21:17   ` Jim Mattson
2026-10-17  0:25     ` Yosry Ahmed
2026-10-19 18:49       ` Jim Mattson
2026-10-19 19:51         ` Yosry Ahmed
2026-10-26 17:33           ` Sean Christopherson
2026-10-22 22:44     ` Sean Christopherson
2026-10-22 22:45       ` Yosry Ahmed
2026-10-26 17:33         ` Sean Christopherson
2026-10-26 18:06           ` Yosry Ahmed
2026-10-27 17:50             ` Sean Christopherson
2026-10-27 17:56               ` Yosry Ahmed
2026-10-28 19:55                 ` Sean Christopherson
2026-10-28 20:00                   ` Yosry Ahmed
2026-10-28 20:21                     ` Sean Christopherson
2026-11-05 23:31               ` Sean Christopherson
2026-10-12 23:36 ` [PATCH v3 27/27] KVM: selftests: Add a test for nested TLB flushes Yosry Ahmed
2026-10-14 13:23 ` [PATCH v3 00/27] KVM: nSVM: Optimize nSVM " Jim Mattson
2026-10-14 14:37   ` Yosry Ahmed
2026-11-04 22:15     ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261012233638.2546339-2-yosry@kernel.org \
    --to=yosry@kernel.org \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlevitsk@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=stable@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox