From: Eric Biggers <ebiggers@kernel.org>
To: Emanuele Rocca <emanuele.rocca@arm.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lib/crc: arm64: use .arch_extension to enable CRC and crypto
Date: Fri, 13 Nov 2026 20:30:57 -0800 [thread overview]
Message-ID: <20261114043057.GH2025@sol> (raw)
In-Reply-To: <20261111142556.67489-1-emanuele.rocca@arm.com>
On Wed, Nov 11, 2026 at 03:25:56PM +0100, Emanuele Rocca wrote:
> Use .arch_extension instead of .arch and .cpu in crc32-core.S and
> crc-t10dif-core.S.
>
> .arch and .cpu reset the assembler's feature set, dropping extensions
> enabled via -march. See commit 9142c2f8f84b ("octeontx2: use
> arch_extension to enable LSE"), where this caused an actual build
> failure.
>
> That is not a problem here: the instructions these files use are all
> covered by the CRC and crypto extensions. Switch anyway for consistency
> and to avoid surprises if the files later use instructions outside
> generic+crc+crypto.
>
> .arch_extension is supported by binutils since 2.26 and by clang since
> 8.0.0, both older than the minimum versions currently required to build
> the kernel (2.30 and 17.0.1 respectively).
>
> Signed-off-by: Emanuele Rocca <emanuele.rocca@arm.com>
> ---
> Changes in v2:
> - Update crc-t10dif-core.S in addition to crc32-core.S
> - Clarify in commit message that this is not a functional change
>
> Link to v1:
> https://lore.kernel.org/all/20261105154145.557042-1-emanuele.rocca@arm.com/
> ---
> lib/crc/arm64/crc-t10dif-core.S | 2 +-
> lib/crc/arm64/crc32-core.S | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next
- Eric
prev parent reply other threads:[~2026-11-14 4:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 14:25 [PATCH v2] lib/crc: arm64: use .arch_extension to enable CRC and crypto Emanuele Rocca
2026-11-14 4:30 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261114043057.GH2025@sol \
--to=ebiggers@kernel.org \
--cc=ardb@kernel.org \
--cc=emanuele.rocca@arm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox