The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Yixun Lan <dlan@kernel.org>
To: Sandie Cao <sandie.cao@deepcomputing.io>
Cc: Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	devicetree <devicetree@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	spacemit <spacemit@lists.linux.dev>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support
Date: Mon, 16 Nov 2026 08:23:50 +0000	[thread overview]
Message-ID: <20261116082350-GKB100890@kernel.org> (raw)
In-Reply-To: <407ce3d77416bb2522b7906b0df3d5adf02c27ee.efc7f10c.ccd0.4025.9bef.e587b1e9e4e8@feishu.cn>

Hi Sandie,

On 14:49 Mon 16 Nov     , Sandie Cao wrote:
> Hi, Yixun:
> 
> > From: "Yixun Lan"<dlan@kernel.org>
> > Date:  Sat, Nov 14, 2026, 15:55
> 
> > Hi Sandie,
> > 
> > On 11:33 Mon 09 Nov     , Sandie Cao wrote:
> > > Add the device tree node SDHCI-0 controller for onboard Micro SD card slot.
> > > 
> > > Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
> > > ---
> > >  .../spacemit/k3-deepcomputing-fml13v05.dts    | 22 +++++++++++++++++++
> > >  1 file changed, 22 insertions(+)
> > > 
> > > diff --git a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> > > index bcd533484a73..051046fe90b2 100644
> > > --- a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> > > +++ b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> > > @@ -177,6 +177,28 @@ &combophy {
> > >          status = "okay";
> > >  };
> > >  
> > ..
> > > +/*
> > > + * Onboard SD card slot:
> > > + * Please insert or remove the SD card while the device is powered off.
> > > + * It works as a boot media. so set it to non-removable.
> > > + */
> > Is there any public schematic available for FML13V05? I guess there is
> > no CD pin (Card Detect pin)? as no "cd-gpios" property seen here
> > 
> > The above comment isn't really useful or even correct, I'd suggest
> > drop it.
> 
> In version 1 [1],  the patch is cd-gpios = <&gpio K3_GPIO(88) GPIO_ACTIVE_LOW>;
> but K3_GPIO(88) is fake cd-gpio, it's tied low on board.
So, there is gpio cd pin, but didn't work? it's hard to say without
the schematic, but can you check with hardware people, if it
can be fixed with SoC's internal GPIO BIAS pullup or pulldown?
So, gpio pin is able to reflect card insert status


> So In version2 [2], the patch changes to non-removable.
> And In version3 [3], add comment. 
> 
> The options: cd-gpio, non-removable, broken-cd  all work on this board.
> 
it works, but does not reflect the hardware status

> We just need to detect the SD card when bootup, don't need the driver 
> to detect hot-plug event , non-removable should be suitable and faster, 
> we recomment to use non-removable.
> 
No, this isn't a valid reason, it's use case should have nothing to do
with the property.

My point is: if the gpio cd pin still doesn't work, and the SD card is
actually physical plugable, then should use "broken-cd".
 
> 
> [1]: https://lore.kernel.org/all/20260922110231.3426011-1-sandie.cao
> @deepcomputing.io/
> [2]: https://lore.kernel.org/all/20261020081633.3673704-1-sandie.cao
> @deepcomputing.io/
> [3]: https://lore.kernel.org/all/20261102060012.100623-1-sandie.cao
> @deepcomputing.io/
> 
> Best regards
> Sandie
> 
> > 
> > > +&sdhci0 {
> > > +        pinctrl-names = "default","uhs";
> > > +        pinctrl-0 = <&mmc1_cfg>;
> > > +        pinctrl-1 = <&mmc1_uhs_cfg>;
> > > +        bus-width = <4>;
> > ..
> > > +        non-removable;
> > "no-removable" property usually used for emmc chip soldered on board,
> >  so there is no way it can be physically removed.. check 
> > Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> > 
> > For cases that no CD pin (or no GPIO CD pin) designed for SD card from
> > hardware schematic perspective, using "broken-cd" is a more proper way,
> > it will fallback to use poll mechanism to detect the card, please check
> > 
> > > +        no-mmc;
> > > +        no-sdio;
> > > +        disable-wp;
> > > +        cap-sd-highspeed;
> > > +        vqmmc-supply = <&aldo1>;
> > > +        sd-uhs-sdr25;
> > > +        sd-uhs-sdr50;
> > > +        sd-uhs-sdr104;
> > > +        status = "okay";
> > > +};
> > > +
> > >  &uart0 {
> > >          pinctrl-names = "default";
> > >          pinctrl-0 = <&uart0_0_cfg>;
> > > -- 
> > > 2.43.0
> > 
> > -- 
> > Yixun Lan (dlan)
> > 

-- 
Yixun Lan (dlan)

  reply	other threads:[~2026-11-16  8:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09  3:31 [PATCH v4 0/3] Enable USB and SD for Deepcomputing FML13V05 board Sandie Cao
2026-11-09  3:32 ` [PATCH v4 1/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add P1 PMIC regulator tree Sandie Cao
2026-11-09  6:38   ` Troy Mitchell
2026-11-09  3:33 ` [PATCH v4 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support Sandie Cao
2026-11-09  6:20   ` Troy Mitchell
2026-11-14  7:30   ` Yixun Lan
2026-11-16  2:54     ` Sandie Cao
2026-11-09  3:33 ` [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support Sandie Cao
2026-11-09  6:20   ` Troy Mitchell
2026-11-14  7:55   ` Yixun Lan
2026-11-16  6:49     ` Sandie Cao
2026-11-16  8:23       ` Yixun Lan [this message]
2026-11-16  9:52         ` Sandie Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116082350-GKB100890@kernel.org \
    --to=dlan@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=sandie.cao@deepcomputing.io \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox