From: David Laight <david.laight.linux@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Miroslav Cimerman <mc@raidlab.org>, Song Liu <song@kernel.org>,
Yu Kuai <yukuai@fygo.io>,
Andrew Morton <akpm@linux-foundation.org>,
Li Nan <magiclinan@didiglobal.com>, Xiao Ni <xiao@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] raid6: use normal stores in the x86 x4 xor_syndrome functions
Date: Mon, 16 Nov 2026 22:14:20 +0000 [thread overview]
Message-ID: <20261116221420.35ab3bcc@pumpkin> (raw)
In-Reply-To: <20261116210440.GE229817@google.com>
On Mon, 16 Nov 2026 21:04:40 +0000
Eric Biggers <ebiggers@kernel.org> wrote:
> On Mon, Nov 09, 2026 at 03:08:05AM +0000, Miroslav Cimerman wrote:
> > - The sfence at the end of the xor_syndrome() functions (x1, x2 versions
> > since 2014, x4 with this patch) is no longer needed, as it no longer
> > orders any non-temporal stores. Removing it made no measurable
> > difference. I am happy to send a follow-up patch that removes it from
> > all xor_syndrome() variants.
>
> Removing the 'asm volatile("sfence" : : : "memory");' too sounds good,
> but be careful: a lot of the inline asm statements in
> lib/raid/raid6/x86/avx512.c incorrectly list the memory operands as
> inputs only. So, technically they rely on that "memory" clobber. The
> constraints should be fixed accordingly.
Or, at least, put in a barrier() and a comment.
David
> Also, ideally the 'prefetchnta' on q in the x4 xor_syndrome() functions
> would become 'prefetcht0', to match the temporal stores.
>
> If the scope of this patch is just replacing the store instructions
> though, it looks fine.
>
> Reviewed-by: Eric Biggers <ebiggers@kernel.org>
>
> - Eric
>
prev parent reply other threads:[~2026-11-16 22:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 3:08 [PATCH] raid6: use normal stores in the x86 x4 xor_syndrome functions Miroslav Cimerman
2026-11-12 12:21 ` Miroslav Cimerman
2026-11-12 12:33 ` Anton Gavriliuk
2026-11-16 6:11 ` Christoph Hellwig
2026-11-16 6:39 ` AW: " Markus Stockhausen
2026-11-16 21:04 ` Eric Biggers
2026-11-16 22:14 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116221420.35ab3bcc@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=magiclinan@didiglobal.com \
--cc=mc@raidlab.org \
--cc=song@kernel.org \
--cc=xiao@kernel.org \
--cc=yukuai@fygo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox