From: David Laight <david.laight.linux@gmail.com>
To: "Theodore Tso" <tytso@mit.edu>
Cc: Gabriel Krisman Bertazi <krisman@suse.de>,
Sarthak Kukreti <sarthakkukreti@google.com>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Gabriel Krisman Bertazi <krisman@collabora.co.uk>,
Eric Biggers <ebiggers@google.com>,
Dmitry Torokhov <dtor@google.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] libfs: reject casefolded names that fold to ".", "..", or empty
Date: Tue, 17 Nov 2026 08:47:27 +0000 [thread overview]
Message-ID: <20261117084727.0cfa196a@pumpkin> (raw)
In-Reply-To: <avu0X5E298dHRBHY@mit.edu>
On Mon, 16 Nov 2026 21:00:06 -0500
"Theodore Tso" <tytso@mit.edu> wrote:
> On Mon, Nov 16, 2026 at 02:34:26PM -0500, Gabriel Krisman Bertazi wrote:
> > Either way, this issue is another example of why treating ignorable code
> > points as 0-length strings was a bad idea. I'd very much rather
> > utf8_casefold would treat all ignorable code points as foldable to
> > themselves, (i.e. commit 5c26d2f1d3f5 ("unicode: Don't special case
> > ignorable code points")), but that was tried and broke applications
> > that relied on variant selectors code-points being ignored.
>
> Sigh... I really think these characters are *evil*. I wonder if we
> should simply drop those code points unconditionally when they are fed
> to the kernel --- not only folding to themselves, but *not* preserving
> them when a misguided application tries to create a file with one of
> these misbegotten Unicode charactesr.
Doesn't that assume that filenames are UTF8 rather than just sequences
of bytes with everything except '\0' and '/' being valid.
Casefolding is itself so evil/impossible it shouldn't have been allowed.
David
>
> I'd prefer to simply reject creating them with an EINVAL, but it's
> likely that will break those stupid applications....
>
> Eventually we can have e2fsck offer to fix directories with those
> characters, and eventually we can make these characters become a bad
> memory.
>
> The other question is what *other* evil misdesigns are in the unicode
> spec that we should be preactively trying to addressw hile we're at it?
>
> - Ted
>
next prev parent reply other threads:[~2026-11-17 8:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 6:53 [PATCH 0/3] fs: reject casefolded names that fold to ".", "..", or empty Sarthak Kukreti
2026-11-13 6:53 ` [PATCH 1/3] libfs: " Sarthak Kukreti
2026-11-16 19:34 ` Gabriel Krisman Bertazi
2026-11-16 20:05 ` Eric Biggers
2026-11-17 2:00 ` Theodore Tso
2026-11-17 8:47 ` David Laight [this message]
2026-11-17 2:44 ` Sarthak Kukreti
2026-11-13 6:53 ` [PATCH 2/3] ext4: " Sarthak Kukreti
2026-11-13 6:53 ` [PATCH 3/3] f2fs: " Sarthak Kukreti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117084727.0cfa196a@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=dtor@google.com \
--cc=ebiggers@google.com \
--cc=jaegeuk@kernel.org \
--cc=krisman@collabora.co.uk \
--cc=krisman@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sarthakkukreti@google.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox