From: Eli Billauer <eli.billauer@gmail.com>
To: gregkh@linuxfoundation.org
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
Eli Billauer <eli.billauer@gmail.com>
Subject: [PATCH v2 0/8] char: xillybus: Fix issues reported by Sashiko
Date: Tue, 17 Nov 2026 12:58:54 +0100 [thread overview]
Message-ID: <20261117115902.41359-1-eli.billauer@gmail.com> (raw)
This series is a follow-up to the previously submitted patchset [1].
It addresses Sashiko review comments on surrounding code. This v2 series
is the result of Sashiko's comments on v1 [2].
Two Sashiko comments from [2] are not addressed in this patch set:
(1) "Can unbinding the device while a file descriptor is open cause a
use-after-free in xillybus_write()?" This remark is correct, but
will be fixed in a future set of patches, which makes the PCIe
driver hot-pluggable.
(2) "Should autoflush_skipped only be consumed when
channel->dont_autoflush reaches zero?" Sashiko correctly recognizes
that if two concurrent calls to xillybus_write() are made, both of
them might block indefinitely in a situation where one of them could
have returned. Concurrent calls to xillybus_write() are not an
expected usage scenario, and blocking indefinitely when the buffers
are full isn't wrong, only suboptimal. The user will never know one
of the calls is blocking in vain. On the other hand, postponing the
compensation of the missed autoflush until the last xillybus_write()
returns can theoretically postpone it forever if the user application
always has a few such calls in flight, effectively disabling the
autoflush mechanism. Either way, the usage scenarios are bizarre, and
suboptimal performance is preferred over breaking the usage model.
Regards,
Eli
[1] https://lore.kernel.org/all/20261009074557.19996-1-eli.billauer@gmail.com/
[2] https://sashiko.dev/#/patchset/20261109112800.48663-1-eli.billauer@gmail.com
Eli Billauer (8):
char: xillybus: Improve sanity check
char: xillybus: Safer access of unaligned pointers
char: xillybus: Return error in fops read method handler
char: xillybus: Rely on FMODE flags in poll method
char: xillybus: Refactor flush function
char: xillybus: Correct handling of wait queue
char: xillybus: Avoid indefinite sleep of work item
char: xillybus: Cancel delayed work items before teardown
drivers/char/xillybus/xillybus.h | 3 +
drivers/char/xillybus/xillybus_core.c | 109 ++++++++++++-----
drivers/char/xillybus/xillyusb.c | 166 +++++++++++---------------
3 files changed, 153 insertions(+), 125 deletions(-)
--
2.17.1
next reply other threads:[~2026-11-17 11:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 11:58 Eli Billauer [this message]
2026-11-17 11:58 ` [PATCH v2 1/8] char: xillybus: Improve sanity check Eli Billauer
2026-11-17 11:58 ` [PATCH v2 2/8] char: xillybus: Safer access of unaligned pointers Eli Billauer
2026-11-17 11:58 ` [PATCH v2 3/8] char: xillybus: Return error in fops read method handler Eli Billauer
2026-11-17 11:58 ` [PATCH v2 4/8] char: xillybus: Rely on FMODE flags in poll method Eli Billauer
2026-11-17 11:58 ` [PATCH v2 5/8] char: xillybus: Refactor flush function Eli Billauer
2026-11-17 11:59 ` [PATCH v2 6/8] char: xillybus: Correct handling of wait queue Eli Billauer
2026-11-17 11:59 ` [PATCH v2 7/8] char: xillybus: Avoid indefinite sleep of work item Eli Billauer
2026-11-17 11:59 ` [PATCH v2 8/8] char: xillybus: Cancel delayed work items before teardown Eli Billauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117115902.41359-1-eli.billauer@gmail.com \
--to=eli.billauer@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox