From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
James Clark <james.clark@linaro.org>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Clark Williams <williams@redhat.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH v6 0/13] perf coverage: A harness for perf, and the fixes it found
Date: Tue, 17 Nov 2026 17:04:18 -0300 [thread overview]
Message-ID: <20261117200433.45174-1-acme@kernel.org> (raw)
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Hi,
Nothing measured how much of perf the test suite reaches. Patch 1 links
the jvmti agent with EXTRA_CFLAGS, without which the coverage build
never saw its counters; patch 2 adds tools/perf/scripts/coverage.sh: it
builds perf with clang source based coverage, runs the complete perf
test suite and reports line and function coverage, optionally against a
baseline, with --table and --html like pahole's coverage_table.py. Also
as 'make -C tools/perf coverage', 'coverage-prep' and 'coverage-table'.
The useful output is the list of files with the most uncovered lines,
computed over the whole tree and not only the files the tests already
touch: that is where new tests should try to get more coverage.
The rest is what the first runs found, in the code, the build and the
tests:
- The data type resolver missed 32-bit absolute addressing (patch 3);
the DW_OP_addrx globals it also missed are fixed upstream by
c3991e42f58a3650, so patch 4 only adds the test. A struct pointer
kept in a register at -O2 had no test (patch 7).
- The flexible array member had no test; one showed the struct row at
0.00% while the member said 100.00% (patches 5-6).
- --insn-stat was printed before the loop that accounts the samples,
so --code-with-type showed zeros (patch 8).
- The libbfd probe printed a missing bfd.h error five times per
build-test run (patch 9).
- FEATURE-DUMP didn't record llvm-perf and rust, disabling both in the
build-test builds (patch 10).
- The Intel PT virtual LBR check lost every aux sample with a single
data page (patch 11).
- The dlfilter test kept samples whose IP the kernel now zeroes on a
userspace-to-kernel skid (patch 12).
- The LBR inline unwinding check failed instead of reporting Skip when
the AMD PMU rejects branch sampling (patch 13).
With coverage-prep by the developer (clang DWARF 5) and the full suite
as root on this AMD host, 105,466 of 205,823 lines were covered
(51.24%; v5: 50.67% of 205,810), 86,344 of 173,257 in tools/perf/
(49.84%). 168 tests passed, 28 skipped and one failed (20.2, the
POLL_HUP regression, outside this series). The global variable and
instruction-stats tests passed; the Intel PT hardware tests skipped,
so patch 11's 64-page AUX buffer has not yet been tested on Intel.
Patch 2's changelog excerpt shows an earlier root run.
The harness and the tests were developed with an AI coding assistant
(OpenCode), which drafted the script and the tests and helped debug the
failures; an independent local model reviewed the script and I verified
its findings before folding them in. I reviewed every change and
reproduced each failure before fixing it.
What changed from v5:
- Patch 1 is new (jvmti link); the harness is 2, 3-13 renumber, and 2
folds the sashiko-bot and local review fixes; 3-8 and 11 carry the
data type, stats and per-thread fixes; 13 skips only EOPNOTSUPP now,
reversing v3. Ian's tags: 05-07, 09 and 12 (05-07 test-only, object
if unwanted); 02-04, 08 and 13 unreviewed.
What changed from v4:
- Rebased onto perf-tools-next b7ff10b9 (52 commits).
- Patch 3: the DW_OP_addrx fix is upstream as c3991e42f58a3650 ("perf
dwarf-aux: Support DW_OP_addrx locations for global variables"), by
James Clark, so the patch is now test-only.
- Patch 12: also match "doesn't support branch stack sampling", how
evsel__open_strerror() formats EOPNOTSUPP, so the test skips on AMD
BRS (sashiko-bot).
- Ian Rogers' Reviewed-by on v3 is carried on patches 4-6, 8 and 10-11;
patches 1, 3 and 12 changed after that review and need a new look.
What changed from v3:
- Patch 1: a .profraw left half written used to make llvm-profdata drop
the whole merge, and with it the run's measurement; the bad files are
now skipped and counted (found running the harness on the arm64 boards).
- Patch 2: only set mem_ref for bare number operands when the offset is
non-zero, and guard find_data_type against reg1 == -1 (sashiko-bot).
- Patch 3: move DW_OP_addrx fallback to dwarf-aux.h so annotate-data.c
builds with older elfutils, and fix typo in Fixes SHA (sashiko-bot).
- Patch 12: only "Invalid argument"/"not supported" skips (exit 2);
stderr goes to a file, any other record failure prints it and fails.
- Ian Rogers' Reviewed-by on v3 is carried on patches 4-6, 8 and
10-11; patches 1 and 12 changed after that review and need a new look.
What changed from v2:
- Patch 2 is new: absolute addressing is resolved, so the new data type
tests pass on 32-bit non-PIE builds and skip on 32-bit PIE.
- Patches 3, 4 and 6: the C programs became 'perf test -w' workloads
(global_data, flex_array, regptr), the shell tests no longer compile
anything (Ian Rogers).
- Patch 6: regptr uses long long members, so the offsets are the same
on ILP32 and LP64.
- Patch 5: add the missing annotated_member__extent() stub, so a
build with slang but without libdw works (sashiko-bot); it is now
a method of struct annotated_member.
What changed from v1:
- Patch 9 (cs-etm) is gone: Leo Yan's series replaces it.
- Patch 1: O= is accepted by all targets, the Python extension is in
the report, -f is normalized and the delta matches its baseline.
- Patch 5: the TUI browser counts flexible array accesses too.
- Patch 7: the stats test skips without libdw.
- Patches 10 and 12: Fixes tags corrected.
Best regards,
- Arnaldo
Arnaldo Carvalho de Melo (13):
perf jvmti: Link the agent with EXTRA_CFLAGS
perf scripts: Add a coverage harness for perf
perf annotate: Handle absolute addressing in data type profiling
perf tests: Exercise DW_OP_addrx global variables
perf tests: Exercise the flexible array member path
perf annotate-data: Count flexible array accesses for the whole struct
perf tests: Exercise data type resolution from a register
perf annotate: Print the stats after the annotations
perf tests: Silence the libbfd probe in build-test
perf build: Record the display-only features in FEATURE-DUMP
perf tests: Fix the Intel PT virtual LBR check
perf test: Drop samples without an IP in the dlfilter test
perf test: Skip the LBR inline unwinding check when unsupported
tools/perf/.gitignore | 1 +
tools/perf/Makefile | 11 +-
tools/perf/Makefile.config | 4 +
tools/perf/Makefile.perf | 6 +-
tools/perf/builtin-annotate.c | 19 +-
tools/perf/scripts/coverage.sh | 984 ++++++++++++++++++
tools/perf/tests/builtin-test.c | 3 +
tools/perf/tests/make | 2 +-
tools/perf/tests/shell/addr2line_inlines.sh | 23 +-
tools/perf/tests/shell/annotate_stats.sh | 69 ++
.../perf/tests/shell/data_type_flex_array.sh | 108 ++
tools/perf/tests/shell/data_type_global.sh | 68 ++
tools/perf/tests/shell/data_type_register.sh | 60 ++
tools/perf/tests/shell/script_dlfilter.sh | 2 +-
tools/perf/tests/shell/test_intel_pt.sh | 9 +-
tools/perf/tests/tests.h | 3 +
tools/perf/tests/workloads/Build | 6 +
tools/perf/tests/workloads/flex_array.c | 55 +
tools/perf/tests/workloads/global_data.c | 55 +
tools/perf/tests/workloads/regptr.c | 61 ++
tools/perf/ui/browsers/annotate-data.c | 7 +-
tools/perf/util/annotate-arch/annotate-x86.c | 52 +-
tools/perf/util/annotate-data.c | 25 +-
tools/perf/util/annotate-data.h | 8 +
tools/perf/util/annotate.c | 25 +-
tools/perf/util/annotate.h | 7 +
26 files changed, 1648 insertions(+), 25 deletions(-)
create mode 100755 tools/perf/scripts/coverage.sh
create mode 100755 tools/perf/tests/shell/annotate_stats.sh
create mode 100755 tools/perf/tests/shell/data_type_flex_array.sh
create mode 100755 tools/perf/tests/shell/data_type_global.sh
create mode 100755 tools/perf/tests/shell/data_type_register.sh
create mode 100644 tools/perf/tests/workloads/flex_array.c
create mode 100644 tools/perf/tests/workloads/global_data.c
create mode 100644 tools/perf/tests/workloads/regptr.c
base-commit: b7ff10b9ddec8da75304c40fe4abf1ee4f9f0a43
v1-head: 3f5465bea8f5a97a
v2-head: 9706c488afffeb6d
v3-head: f2daf1586528671a
v4-head: b9e240a1b80ecd2a
v5-head: a21454e3d055c93b
v6-head: e1315408a335617d
--
2.56.0
next reply other threads:[~2026-11-17 20:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 20:04 Arnaldo Carvalho de Melo [this message]
2026-11-17 20:04 ` [PATCH v6 01/13] perf jvmti: Link the agent with EXTRA_CFLAGS Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 02/13] perf scripts: Add a coverage harness for perf Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 03/13] perf annotate: Handle absolute addressing in data type profiling Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 04/13] perf tests: Exercise DW_OP_addrx global variables Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 05/13] perf tests: Exercise the flexible array member path Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 06/13] perf annotate-data: Count flexible array accesses for the whole struct Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 07/13] perf tests: Exercise data type resolution from a register Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 08/13] perf annotate: Print the stats after the annotations Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 09/13] perf tests: Silence the libbfd probe in build-test Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 10/13] perf build: Record the display-only features in FEATURE-DUMP Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 11/13] perf tests: Fix the Intel PT virtual LBR check Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 12/13] perf test: Drop samples without an IP in the dlfilter test Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 13/13] perf test: Skip the LBR inline unwinding check when unsupported Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117200433.45174-1-acme@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox