From: Enzo Adriano <enzo.adriano.code@gmail.com>
To: andre.przywara@arm.com, wens@kernel.org
Cc: sboyd@kernel.org, bmasney+clk@redhat.com,
jbrunet+clk@baylibre.com, jernej.skrabec@gmail.com,
samuel@sholland.org, Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org,
Junhui Liu <junhui.liu@pigmoral.tech>,
Vinicius Pedrosa <vinicius.eduardo.pedrosa@gmail.com>
Subject: Re: [PATCH v2] clk: sunxi-ng: a733: Keep SCP firmware bus clocks enabled
Date: Thu, 19 Nov 2026 13:08:57 -0500 [thread overview]
Message-ID: <20261118-a733-fwclk-v2-reply@gmail.com> (raw)
In-Reply-To: <35a06829-dd6d-4ef1-aadf-245d1e7ca433@arm.com>
Hi Chen-Yu, Andre,
>>> But I think there is still the arisc on
>>> the A733, so this would more likely run the management processor (SCP) code?
The A733 CPUS domain has both an E902 and an OR100 (manual section 1.2,
figure 1-1). The vendor SCP firmware Radxa ships for Cubie A7S, called
"arisc" by Allwinner, runs on the E902: vendor BL31 writes its entry
point to E902_RST_START_ADDR_REG at 0x07032204 (manual section 5.2.3).
Radxa's BL31, in its system reset path, sends a reboot request to the
E902 through the CPUX-to-CPUS msgbox. Exactly where the no-flag reboot
stalls is not known.
> The question now is whether this SCP use case is something we deem
> useful, for mainline. If it's just about to run the BSP firmware, I
> think we shouldn't bother, we just don't support that. But if we end up
> running something like crust on the E902, then it's a different story.
For me this is only about the vendor BSP firmware; I have no other SCP
firmware for the E902 to test with. Upstream Crust has no A733 target,
and the A733 TF-A port under review resets through the watchdog, not
the msgbox [1].
>>>> So, not a fan of this. If the loaded firmware somehow needs some resources
>>>> then perhaps the software that loaded it needs to somehow tell the kernel
>>>> they are needed, like the bootloader patching the DT passed to the kernel.
Vendor U-Boot already applies DT fixups, but the A733 CCU binding and
driver do not accept protected-clocks today. A loader-declared handoff
would need a new binding and driver support, plus loader changes.
> So I wonder if we should just pragmatically add CLK_IGNORE_UNUSED, to
> not shut on the door on this SCP use case later.
> If we ever only want to use remoteproc, I think we don't need this patch.
CLK_IGNORE_UNUSED would also leave a future remoteproc driver free to
gate the core. Chen-Yu, if you are fine with it, I will test it on A7S
and send v3 based on linux-sunxi for-next, with Andre's comment wording
and a short test note. Otherwise I will drop the patch.
[1] https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/55200
Thanks,
Enzo
prev parent reply other threads:[~2026-11-19 18:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 21:38 [PATCH v2] clk: sunxi-ng: a733: Keep SCP firmware bus clocks enabled Enzo Adriano
2026-11-17 17:18 ` Andre Przywara
2026-11-18 13:41 ` Chen-Yu Tsai
2026-11-18 14:51 ` Andre Przywara
2026-11-18 15:15 ` Chen-Yu Tsai
2026-11-18 15:39 ` Andre Przywara
2026-11-19 18:08 ` Enzo Adriano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118-a733-fwclk-v2-reply@gmail.com \
--to=enzo.adriano.code@gmail.com \
--cc=alex@ghiti.fr \
--cc=andre.przywara@arm.com \
--cc=aou@eecs.berkeley.edu \
--cc=bmasney+clk@redhat.com \
--cc=jbrunet+clk@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=junhui.liu@pigmoral.tech \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=vinicius.eduardo.pedrosa@gmail.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox