From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
jonathan.downing@nautel.com,
Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
Vladimir Zapolskiy <vz@mleia.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 1/2] ASoC: fsl: lpc3xxx-i2s: Simplify error handling
Date: Wed, 18 Nov 2026 17:06:30 +0700 [thread overview]
Message-ID: <20261118100631.26658-2-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20261118100631.26658-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
Return -EBUSY directly when the I2S channel is already in use.
Also remove the redundant error pointer from the regmap initialization
error message, as dev_err_probe() already reports the error.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/fsl/lpc3xxx-i2s.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/soc/fsl/lpc3xxx-i2s.c b/sound/soc/fsl/lpc3xxx-i2s.c
index 757e0619d368..75bd148c1432 100644
--- a/sound/soc/fsl/lpc3xxx-i2s.c
+++ b/sound/soc/fsl/lpc3xxx-i2s.c
@@ -82,8 +82,7 @@ static int lpc3xxx_i2s_startup(struct snd_pcm_substream *substream, struct snd_s
if (flag & i2s_info_p->streams_in_use) {
dev_warn(dev, "I2S channel is busy\n");
- ret = -EBUSY;
- return ret;
+ return -EBUSY;
}
if (i2s_info_p->streams_in_use == 0) {
@@ -320,7 +319,7 @@ static int lpc32xx_i2s_probe(struct platform_device *pdev)
i2s_info_p->regs = devm_regmap_init_mmio(dev, iomem, &lpc32xx_i2s_regconfig);
if (IS_ERR(i2s_info_p->regs))
return dev_err_probe(dev, PTR_ERR(i2s_info_p->regs),
- "failed to init register map: %pe\n", i2s_info_p->regs);
+ "failed to init register map\n");
i2s_info_p->clk = devm_clk_get(dev, NULL);
if (IS_ERR(i2s_info_p->clk))
--
2.43.0
next prev parent reply other threads:[~2026-11-18 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 10:06 [PATCH 0/2] ASoC: fsl: lpc3xxx-i2s: Fix error handling and DMA configuration phucduc.bui
2026-11-18 10:06 ` phucduc.bui [this message]
2026-11-18 10:06 ` [PATCH 2/2] ASoC: fsl: lpc3xxx-i2s: Fix DMA depth configuration phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118100631.26658-2-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=broonie@kernel.org \
--cc=jonathan.downing@nautel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=tiwai@suse.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox