The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Joshua Crofts <crofts@kernel.org>
To: Roman Vivchar via B4 Relay <devnull+rva333.protonmail.com@kernel.org>
Cc: rva333@protonmail.com, "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] iio: light: stk3310: add vdd regulator support
Date: Wed, 18 Nov 2026 11:01:38 +0100	[thread overview]
Message-ID: <20261118110138.000003ab@kernel.org> (raw)
In-Reply-To: <20261117-6768-stk3337-v2-3-92f4c7be3bc6@protonmail.com>

On Tue, 17 Nov 2026 20:08:37 +0200
Roman Vivchar via B4 Relay <devnull+rva333.protonmail.com@kernel.org> wrote:

> @@ -745,6 +746,10 @@ static int stk3310_probe(struct i2c_client *client)
>  	device_property_read_u32(&client->dev, "proximity-near-level",
>  				 &data->ps_near_level);
>  
> +	ret = devm_regulator_get_enable(dev, "vdd");
> +	if (ret)
> +		return dev_err_probe(dev, ret, "failed to get vdd supply\n");
> +

IMO this should work, but I don't like the mixing of devm_* and non-devm_*
functions, this may cause issues down the road. Consider moving the driver
to all devm_* functions?

-- 
Kind regards,
Joshua Crofts

  reply	other threads:[~2026-11-18 10:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 18:08 [PATCH v2 0/4] iio: light: stk3310: stk3337 support + vdd supply Roman Vivchar via B4 Relay
2026-11-17 18:08 ` [PATCH v2 1/4] dt-bindings: iio: light: stk33xx: add power supply support Roman Vivchar via B4 Relay
2026-11-17 18:08 ` [PATCH v2 2/4] dt-bindings: iio: light: stk33xx: add stk3337 Roman Vivchar via B4 Relay
2026-11-17 18:08 ` [PATCH v2 3/4] iio: light: stk3310: add vdd regulator support Roman Vivchar via B4 Relay
2026-11-18 10:01   ` Joshua Crofts [this message]
2026-11-17 18:08 ` [PATCH v2 4/4] iio: light: stk3310: add stk3337 support Roman Vivchar via B4 Relay
2026-11-18 10:03   ` Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118110138.000003ab@kernel.org \
    --to=crofts@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=devnull+rva333.protonmail.com@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=rva333@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox