From: Wayne Lin <Wayne.Lin@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: "Cooper Morgan" <ext-github@cwooper.dev>,
"Eren Özen" <erenozen@protonmail.com>,
oss@oysterdaisuki.com, harry.wentland@amd.com,
alexander.deucher@amd.com, sunpeng.li@amd.com,
siqueira@igalia.com, christian.koenig@amd.com, airlied@gmail.com,
simona@ffwll.ch, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] drm/amd/display: Fix FreeSync infopacket refresh rates above 255 Hz
Date: Thu, 19 Nov 2026 11:05:04 +0800 [thread overview]
Message-ID: <20261119030504.3849327-1-Wayne.Lin@amd.com> (raw)
In-Reply-To: <HftAWPKURVjBtK_2BmUiLXOb8ghZxaEzAJSg0tlsmy5L3ckJyDWc6g65vrsVGdA3ZcytB6mPuyxaQbsPawfOZmdC1dyAo4lCbaK3Tj7Tm-U=@protonmail.com>
On Wed, 18 Nov 2026 12:46:45 +0000, Eren Özen wrote:
> Hi Wayne, Cooper,
>
> One more difference worth knowing about if v2 gets swapped in:
> ae60ec4dcfc4 ("drm/amd/display: Use FreeSync v3 infopacket for sinks
> above 255 Hz") is missing the amdgpu_dm_connector.c hunk of patch 2/2.
> The posted patch changes four files (92 insertions, 1 deletion) in both
> v1 and v2, but the commit only changes three (91 insertions).
>
> The missing hunk is the one that stores the AMD VSDB version for every
> DP/eDP sink:
>
> get_amd_vsdb(amdgpu_dm_connector, &vsdb_info);
> + amdgpu_dm_connector->vsdb_info.amd_vsdb_version = vsdb_info.amd_vsdb_version;
>
> if (vsdb_info.replay_mode) {
> amdgpu_dm_connector->vsdb_info.replay_mode = vsdb_info.replay_mode;
> - amdgpu_dm_connector->vsdb_info.amd_vsdb_version = vsdb_info.amd_vsdb_version;
>
> Without it, a native DP sink without Replay never records VSDB v3, so it
> never gets the v3 packet, and the DP side of the >255 Hz fix has no
> effect. The KUnit test added by the same patch catches this on
> amd-staging-drm-next 8dd68a79583a:
>
> # dm_test_fs_caps_dp_vsdb_version: EXPECTATION FAILED at drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/tests/amdgpu_dm_connector_test.c:9925
> Expected ctx->aconnector->vsdb_info.amd_vsdb_version == 3, but
> ctx->aconnector->vsdb_info.amd_vsdb_version == 0 (0x0)
>
> The failure is easy to miss right now, because the amdgpu_dm KUnit run
> panics earlier in dm_test_i2c_xfer_no_ddc_pin() (I've reported that on
> the "Route connector DDC over AUX" thread). With that test fixed and
> this hunk restored, all 1931 amdgpu_dm tests pass here. Patch 1/2
> (bedad38a7ddf) landed complete.
>
> Thanks,
> Eren
>
Hi Cooper, Eren,
Cooper, I am sorry. I missed the latest revision, and an older one
landed on amd-staging-drm-next instead. Since the patches are already
merged, those tags will not be added.
Eren, thank you for the report. The hunk was accidentally left out of
ae60ec4dcfc4. I will send a follow-up patch to restore it and Cc you
both.
Thanks!
Regards,
Wayne
prev parent reply other threads:[~2026-11-19 3:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 1:05 [PATCH v2 0/2] drm/amd/display: Fix FreeSync infopacket refresh rates above 255 Hz Cooper Morgan
2026-11-13 1:05 ` [PATCH v2 1/2] drm/amd/display: Saturate refresh rates in v1/v2 FreeSync infopackets Cooper Morgan
2026-11-13 1:05 ` [PATCH v2 2/2] drm/amd/display: Use FreeSync v3 infopacket for sinks above 255 Hz Cooper Morgan
2026-11-17 18:34 ` [PATCH v2 0/2] drm/amd/display: Fix FreeSync infopacket refresh rates " Cooper Morgan
2026-11-18 12:46 ` Eren Özen
2026-11-19 1:41 ` Cooper Morgan
2026-11-19 3:05 ` Wayne Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119030504.3849327-1-Wayne.Lin@amd.com \
--to=wayne.lin@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=erenozen@protonmail.com \
--cc=ext-github@cwooper.dev \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oss@oysterdaisuki.com \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox