From: luca abeni <luca.abeni@santannapisa.it>
To: Tejun Heo <tj@kernel.org>
Cc: Yuri Andriaccio <yurand2000@gmail.com>,
bsegall@google.com, cgroups@vger.kernel.org,
dietmar.eggemann@arm.com, hannes@cmpxchg.org,
juri.lelli@redhat.com, kprateek.nayak@amd.com,
linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com,
mkoutny@suse.com, peterz@infradead.org, rostedt@goodmis.org,
vincent.guittot@linaro.org, vschneid@redhat.com,
yuri.andriaccio@santannapisa.it
Subject: Re: [RFC PATCH v7 00/29] Hierarchical Constant Bandwidth Server
Date: Thu, 19 Nov 2026 15:14:16 +0100 [thread overview]
Message-ID: <20261119151416.33f90a64@linux.fritz.box> (raw)
In-Reply-To: <58cb2cbaf82c0f671213eaca46465cd5@kernel.org>
Hi all,
first of all, sorry about the delay, Yuri and I have been discussing
these issues for some time before replying. See our conclusions below.
On Tue, 17 Nov 2026 22:07:04 -1000
Tejun Heo <tj@kernel.org> wrote:
[...]
> On Wed, Nov 11, 2026 at 06:56:57PM +0100, Yuri Andriaccio wrote:
> > - `cpu.rt.max` only accepts per-CPU settings, so the global
> > "default" is removed. Removing all overrides means the cgroup is a
> > "max" cgroup, while just a single override means that the cgroup
> > has its own budget.
> > + This new interface disallows zero-runtime overrides, as a zero
> > override is equal to an empty override when there is at least one
> > non-zero override. As an example: [<CPU0 10ms 100ms>, <CPU1 0ms
> > 100ms>] is equal to just having [<CPU0 10ms 100ms>]. This seems a
> > 100ms>bit odd, how to make this better?
>
> It's odd because a missing entry means "max" when there are no entries
> and zero when there are some.
Yes, we agree this behaviour looks wrong, and should be removed,
however...
> Can a missing entry always mean "max",
> per CPU? On a CPU that a cgroup has no entry for, its tasks would be
> served by the nearest ancestor which has one.
... We believe that mixing "max" cores and cores configured with
(runtime, period) in the same cgroup is problematic, for various
reason. From the theoretical point of view, this would mean that when
migrating between cores a task can "move" from one reservation to a
different one, creating issues for schedulability analysis. All the
(runtime, period) deadline entities in a cgroup form a multi-core
reservation, as in MPR
(https://repository.upenn.edu/entities/publication/5cd778fe-4d0b-45a9-ae9e-cef48209bd8a)
if some cores are "max" and some are attached to (runtime, period)
deadline entities, the tasks move between two different multi-core
reservations, without control.
So, what about a different idea: a cgroup can be "max" or have
(runtime,period); when we set (runtime,period), this is set for all the
CPU cores, but then we can override (with runtime 0, or different
runtime/period) some cores (but we cannot override with "max").
This way, "0" still has one single meaning (no real-time tasks on this
core), but we do not mix "max" and "(runtime,period)" in the same
cgroup... Would this be acceptable?
> Zero then becomes a
> regular value which is shown on read, and the two configs in your
> example are different. The former can't run RT tasks on CPU1. The
> latter runs them on the ancestor's budget there.
We believe this property can be valid with the proposal above, too.
[...]
> The root has no ancestor to fall back to, so a missing entry can't
> mean anything there. It has to always carry an entry for every
> possible CPU, which defaults to zero, and reject "max":
>
> 0-127 runtime=0 period=1000000
We think 0 as a default would be problematic, as it means "no real-time
tasks", and 0 in the root means "no real-time tasks in all the
cgroups"... Or am I missing your point?
> > - `cpu` and `cpuset` controllers are decoupled, as it was before
> > the `cpuset` integration patch. The user/admin is responsible for
> > inconsistencies between the two controllers (i.e. empty
> > intersection between active server in the rt-cgroup and the allowed
> > cpuset just disallows executing RT tasks entirely).
>
> Yes, let's decouple them. With that, can the CPU offline lockout go
> away too? An entry for an offline CPU can stay configured and take
> effect again when the CPU comes back.
Let's decouple them, then. I am not sure about offline CPUs.
> One more thing on the unprivileged FIFO/RR tasks in cgroups. No other
> cgroup resource config grants privileges that way. e.g. If an rlimit
> is set on memory, memory.low doesn't do anything to work around it. I
> think who can use RT policies should be left to system configuration,
> i.e. RLIMIT_RTPRIO and CAP_SYS_NICE. Can you drop that patch?
OK, let's drop this patch.
Thanks,
Luca
next prev parent reply other threads:[~2026-11-19 14:14 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 16:35 [RFC PATCH v7 00/29] Hierarchical Constant Bandwidth Server Yuri Andriaccio
2026-11-09 16:35 ` [RFC PATCH v7 01/29] sched/deadline: Introduce dl_freq_invariant flag for fair/ext servers Yuri Andriaccio
2026-11-09 16:35 ` [RFC PATCH v7 02/29] sched/deadline: Do not access dl_se->rq directly Yuri Andriaccio
2026-11-09 16:35 ` [RFC PATCH v7 03/29] sched/deadline: Distinguish between dl_rq and my_q Yuri Andriaccio
2026-11-09 16:35 ` [RFC PATCH v7 04/29] sched/rt: Pass an rt_rq instead of an rq where needed Yuri Andriaccio
2026-11-09 16:35 ` [RFC PATCH v7 05/29] sched/rt: Move functions from rt.c to sched.h Yuri Andriaccio
2026-11-09 16:35 ` [RFC PATCH v7 06/29] sched/rt: Disable RT_GROUP_SCHED Yuri Andriaccio
2026-11-09 16:35 ` [RFC PATCH v7 07/29] sched/rt: Remove unnecessary runqueue pointer in struct rt_rq Yuri Andriaccio
2026-11-09 16:35 ` [RFC PATCH v7 08/29] sched/rt: Introduce HCBS specific structs in task_group Yuri Andriaccio
2026-11-09 16:35 ` [RFC PATCH v7 09/29] sched/core: Initialize HCBS specific structures Yuri Andriaccio
2026-11-09 16:35 ` [RFC PATCH v7 10/29] sched/deadline: Add dl_init_tg Yuri Andriaccio
2026-11-09 16:35 ` [RFC PATCH v7 11/29] sched/rt: Add {alloc/unregister/free}_rt_sched_group Yuri Andriaccio
2026-11-09 16:35 ` [RFC PATCH v7 12/29] sched/deadline: Account rt-cgroups bandwidth in deadline tasks schedulability tests Yuri Andriaccio
2026-11-09 16:35 ` [RFC PATCH v7 13/29] sched/rt: Implement dl-server operations for rt-cgroups Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 14/29] sched/rt: Update task event callbacks for HCBS scheduling Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 15/29] sched/rt: Remove support for cgroups-v1 Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 16/29] sched/rt: Update rt-cgroup schedulability checks Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 17/29] sched/rt: Update task's RT runqueue when switching scheduling class Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 18/29] sched/rt: Remove old RT_GROUP_SCHED data structures Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 19/29] sched/rt: Add HCBS migration code to related functions Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 20/29] sched/rt: Hook HCBS migration functions Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 21/29] sched/core: Execute enqueued balance callbacks when changing allowed CPUs Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 22/29] sched/rt: Try pull task on empty server pick Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 23/29] sched/core: Execute enqueued balance callbacks after migrate_disable_switch Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 24/29] sched/syscalls: Allow unpriviledged tasks to set RT priority inside cgroups Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 25/29] sched/rt: Enable HRTICK_DL for HCBS servers Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 26/29] Documentation: Update documentation for real-time cgroups Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 27/29] sched/rt: Integrate cpuset and cpu controllers Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 28/29] sched/rt: Prevent CPU offline operation on active rt-cgroups Yuri Andriaccio
2026-11-09 16:36 ` [RFC PATCH v7 29/29] sched/rt: Introduce multi-cpu support Yuri Andriaccio
2026-11-10 21:43 ` [RFC PATCH v7 00/29] Hierarchical Constant Bandwidth Server Tejun Heo
2026-11-11 17:56 ` Yuri Andriaccio
2026-11-17 15:49 ` Juri Lelli
2026-11-18 8:07 ` Tejun Heo
2026-11-19 11:23 ` Juri Lelli
2026-11-19 14:27 ` luca abeni
2026-11-19 14:36 ` Juri Lelli
2026-11-19 14:42 ` luca abeni
2026-11-19 14:14 ` luca abeni [this message]
2026-11-16 14:25 ` Juri Lelli
2026-11-17 13:00 ` Yuri Andriaccio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119151416.33f90a64@linux.fritz.box \
--to=luca.abeni@santannapisa.it \
--cc=bsegall@google.com \
--cc=cgroups@vger.kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yurand2000@gmail.com \
--cc=yuri.andriaccio@santannapisa.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox