The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Gleb Pesin via B4 Relay <devnull+dormancygrace.gmail.com@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>,
	 Antoine Tenart <atenart@kernel.org>,
	 Herbert Xu <herbert@gondor.apana.org.au>,
	 "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] crypto: eip93 - return request validation errors synchronously
Date: Fri, 20 Nov 2026 19:37:18 +0000	[thread overview]
Message-ID: <20261120-eip93-sync-errors-v1-1-1a83ae607181@gmail.com> (raw)

From: Gleb Pesin <dormancygrace@gmail.com>

The skcipher and AEAD paths validate requests before submitting them
to the hardware. On validation failure they invoke the completion
callback and return the same error. Callers handle that return value
as a synchronous failure and can complete the request a second time.

Return the validation error directly in both paths. Keep completion
callbacks in the hardware result handlers.

Codex (gpt-6.2-sol) assisted with comparing the two paths, preparing the
change and writing the changelog. The corresponding OpenWrt 6.18.64
driver object was cross-compiled on MIPS.

Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
Reported-by: Herbert Xu <herbert@gondor.apana.org.au>
Closes: https://lore.kernel.org/linux-crypto/aXxmIuU9PKJiDs7n@gondor.apana.org.au/
Signed-off-by: Gleb Pesin <dormancygrace@gmail.com>
---
 drivers/crypto/inside-secure/eip93/eip93-aead.c   | 4 +---
 drivers/crypto/inside-secure/eip93/eip93-cipher.c | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/crypto/inside-secure/eip93/eip93-aead.c b/drivers/crypto/inside-secure/eip93/eip93-aead.c
index 0b7a899b1..12134b6aa 100644
--- a/drivers/crypto/inside-secure/eip93/eip93-aead.c
+++ b/drivers/crypto/inside-secure/eip93/eip93-aead.c
@@ -47,10 +47,8 @@ static int eip93_aead_send_req(struct crypto_async_request *async)
 	int err;
 
 	err = check_valid_request(rctx);
-	if (err) {
-		aead_request_complete(req, err);
+	if (err)
 		return err;
-	}
 
 	return eip93_send_req(async, req->iv, rctx);
 }
diff --git a/drivers/crypto/inside-secure/eip93/eip93-cipher.c b/drivers/crypto/inside-secure/eip93/eip93-cipher.c
index 4dd7ab750..7b6d510f4 100644
--- a/drivers/crypto/inside-secure/eip93/eip93-cipher.c
+++ b/drivers/crypto/inside-secure/eip93/eip93-cipher.c
@@ -38,10 +38,8 @@ static int eip93_skcipher_send_req(struct crypto_async_request *async)
 
 	err = check_valid_request(rctx);
 
-	if (err) {
-		skcipher_request_complete(req, err);
+	if (err)
 		return err;
-	}
 
 	return eip93_send_req(async, req->iv, rctx);
 }

---
base-commit: 26ca5f34841f0a86d0883664a1c13be89a01d351
change-id: 20261120-eip93-sync-errors-fd700c897151

Best regards,
--  
Gleb Pesin <dormancygrace@gmail.com>



                 reply	other threads:[~2026-11-20 19:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120-eip93-sync-errors-v1-1-1a83ae607181@gmail.com \
    --to=devnull+dormancygrace.gmail.com@kernel.org \
    --cc=ansuelsmth@gmail.com \
    --cc=atenart@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dormancygrace@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox