The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Tim JH Chen <tim770802@gmail.com>
To: ah@foundata.com
Cc: Chih.Hung.Huang@wnc.com.tw, andrew+netdev@lunn.ch,
	chandrashekar.devegowda@intel.com, davem@davemloft.net,
	edumazet@google.com, haijun.liu@mediatek.com, horms@kernel.org,
	ilpo.jarvinen@linux.intel.com, johannes@sipsolutions.net,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	loic.poulain@oss.qualcomm.com, netdev@vger.kernel.org,
	pabeni@redhat.com, ricardo.martinez@linux.intel.com,
	ryazanov.s.a@gmail.com, tim.jh.chen@wnc.com.tw
Subject: Re: [PATCH net v6 2/4] net: wwan: t7xx: do not exit the TX push kthread on resume failure
Date: Fri, 20 Nov 2026 10:32:00 +0800	[thread overview]
Message-ID: <20261120023200.133268-1-tim770802@gmail.com> (raw)
In-Reply-To: <20261106054532.201311-1-ah@foundata.com>

Hi Andreas,

Thanks for the report. The trace matches the sequence described in the
commit message: pm_runtime_resume_and_get() returned -EINVAL after the
runtime suspend failure left dev->power.runtime_error set, the thread
returned, and kthread_stop() in t7xx_dpmaif_tx_thread_rel() later ran on
the stale task pointer.

The fix is v7 patch 4/6: https://lore.kernel.org/netdev/20261120015556.131547-5-tim770802@gmail.com/
Its commit message now describes your case, including the remove that
hung in D state holding pci_rescan_remove_lock, and carries a
Reported-by: and Closes: for your mail. If you would rather not be
credited, tell me and I will drop the tag in the next revision.

> One question on the retry. In my case the failure is permanent:
> runtime_error is latched, so rpm_resume() returns -EINVAL from then on.
> With this patch the crash goes away, but TX stays dead and the thread
> retries every 20 ms for as long as the TX lists are non-empty. Is that
> the intended end state, or should something report the dead data path?

The intent of this patch is only that the thread stays alive until
teardown so kthread_stop() is safe; it does not try to recover the data
path. A latched runtime_error is not cleared by anything in the driver
today, and recovering from a failed runtime suspend is a separate
problem from this fix.

You are right that polling every 20 ms for as long as the lists are
non-empty is not a good steady state. In v7 the thread retries once per
second instead, and the first failure of a streak is logged, so the
dead data path is reported once rather than silently. It still does not
recover the data path from a latched runtime_error.

Thanks,
Tim

  reply	other threads:[~2026-11-20  2:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02  1:46 [PATCH net v6 0/4] net: wwan: t7xx: fix DPMAIF data path vs system PM suspend Tim JH Chen
2026-10-02  1:46 ` [PATCH net v6 1/4] net: wwan: t7xx: fix runtime PM usage count underflow on -EACCES Tim JH Chen
2026-10-06  2:13   ` netdev-bot+sashiko
2026-10-02  1:46 ` [PATCH net v6 2/4] net: wwan: t7xx: do not exit the TX push kthread on resume failure Tim JH Chen
2026-11-06  5:45   ` Andreas Haerter
2026-11-20  2:32     ` Tim JH Chen [this message]
2026-10-02  1:46 ` [PATCH net v6 3/4] net: wwan: t7xx: fix race between TX/RX data path and system PM suspend Tim JH Chen
2026-10-06  2:13   ` netdev-bot+sashiko
2026-10-02  1:46 ` [PATCH net v6 4/4] net: wwan: t7xx: complete NAPI on the not-started RX poll early return Tim JH Chen
2026-10-06  2:13   ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120023200.133268-1-tim770802@gmail.com \
    --to=tim770802@gmail.com \
    --cc=Chih.Hung.Huang@wnc.com.tw \
    --cc=ah@foundata.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=chandrashekar.devegowda@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=haijun.liu@mediatek.com \
    --cc=horms@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ricardo.martinez@linux.intel.com \
    --cc=ryazanov.s.a@gmail.com \
    --cc=tim.jh.chen@wnc.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox