From: "William A. Kennington III" <william@wkennington.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Havard Skinnemoen <hskinnemoen@google.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"William A. Kennington III" <william@wkennington.com>
Subject: Re: [PATCH] USB: cdc-acm: refuse writes after disconnect
Date: Fri, 20 Nov 2026 06:55:48 +0000 [thread overview]
Message-ID: <20261120065548.940641-1-william@wkennington.com> (raw)
In-Reply-To: <92980914-a5f3-43fb-8bf3-714674f1b1fb@suse.com>
On Thu, Nov 19, 2026 at 09:24:51AM +0100, Oliver Neukum wrote:
> Hi,
>
> thank you for the patch. It raises a question, though.
> It is not clear to me when you use READ_ONCE/WRITE_ONCE
> and when you touch the disconnected flag directly.
I added READ_ONCE() around the unlocked acm->disconnected and then just
added the WRITE_ONCE() for consistency. I guess the rest doesn't use it
so let me just remove both of these.
Thanks,
William
prev parent reply other threads:[~2026-11-20 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 14:56 [PATCH] USB: cdc-acm: refuse writes after disconnect William A. Kennington III
2026-11-19 8:24 ` Oliver Neukum
2026-11-20 6:55 ` William A. Kennington III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120065548.940641-1-william@wkennington.com \
--to=william@wkennington.com \
--cc=gregkh@linuxfoundation.org \
--cc=hskinnemoen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox